From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A394EC32772 for ; Tue, 23 Aug 2022 18:00:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oyvDlVsm2QwvK99ZvaTteszNtNf4l5jGPGx7G64KimQ=; b=2deKhbvd4eVTFq BjLNM0KIGnNYO4Vjw4BfaHGJFWdmRz98PxQwrGJpnE2yVN7510Ig1C983mlWCfXhiEOY+mDs/TYt9 6Hii3/GN9LhwZK8wlp1ofQHXSGF8WoBf8GE1WjfK5ogQ5VNs+U6UOOIJlHTNRpKRluxT/jxNe6awg xQCXAwDq2x5sFFuWzPNnKn47UCO4Dw5bFSnwstGnKLou7R+qqqqxv0y8nan0PTz35ulzb0+qwpHbx z0lao67Sx2Wr5HbWM9sNX01fOWcX3hLdYRkZbZQGIodcyVrblOn4m5ojWhwFIqaf/tvL/Z7NJ8ADW aVoMLE8H4aXQld8uk1bA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQYBt-007vf0-12; Tue, 23 Aug 2022 17:59:53 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQYBq-007vc9-4P; Tue, 23 Aug 2022 17:59:51 +0000 Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oQYBm-0006NS-G1; Tue, 23 Aug 2022 19:59:46 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Stephen Boyd , Jagan Teki Cc: Kever Yang , Krzysztof Kozlowski , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, Michael Turquette , Krzysztof Kozlowski Subject: Re: [PATCH v3 10/19] dt-bindings: clock: rockchip: Document RV1126 CRU Date: Tue, 23 Aug 2022 19:59:45 +0200 Message-ID: <6086608.Sb9uPGUboI@diego> In-Reply-To: References: <20220818124132.125304-1-jagan@edgeble.ai> <20220818212913.7FC43C433D6@smtp.kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220823_105950_213349_3E11ED1D X-CRM114-Status: GOOD ( 17.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Freitag, 19. August 2022, 23:20:03 CEST schrieb Jagan Teki: > On Fri, 19 Aug 2022 at 02:59, Stephen Boyd wrote: > > > > Quoting Jagan Teki (2022-08-18 05:41:23) > > > + > > > + clocks: > > > + maxItems: 1 > > > + > > > + clock-names: > > > + const: xin24m > > > + > > > + rockchip,grf: > > > + $ref: /schemas/types.yaml#/definitions/phandle > > > + description: > > > + Phandle to the syscon managing the "general register files" (GRF), > > > + if missing pll rates are not changeable, due to the missing pll > > > + lock status. > > > + > > > +required: > > > + - compatible > > > + - reg > > > + - "#clock-cells" > > > + - "#reset-cells" > > > > Why aren't clocks required? > > I don't see any clocks being used by cru in rv1126 [1] so that is the > reason I didn't add any. Let me know if it is something that is > mandatory to add even if it's unused. > [1] https://github.com/rockchip-linux/kernel/blob/develop-4.19/arch/arm/boot/dts/rv1126.dtsi#L1074 Our clock drivers normally just expect that xin24m to be present but that xin24m _is_ a clock dependency for the cru and for a lot of Rockchip SoCs Johan did update both the binding and the dtsi-s to make that explicit when converting the binding over to yaml See for example the rk3399. Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel