From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8DBFCC433F5 for ; Wed, 4 May 2022 14:54:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aa05yRYS9scJ0de556vTuXO6Cl7p+/pRwmwsWucZId8=; b=r0il3IKRKYxCgo Dqf1sTJ272dd1ktYzKA4YDqaGTaOq8KMKpMZCLHOIoXaGpsXqLPA8Q8BFYDsb/TItCfSg3W9mJ5f+ hA3E6FIpbc9oR65/hKAIBsmLHqhoHm6hxqQjBP1q+mQ2FNo0m04aOU775zjQ8CWvE8By+byUlwkjl BcLabFVmbO8PAJLHPTFIzQ53RPs0vlR7Ntcnk9JyBMp4J6BLTUJgIqvowkpMB2Mc43TeLXUyJR4TX LsHiCGebV2pjjJJidYyMdl3j533XteYzEFHQk9ynYSh+4R7IK8CQ4o+YqMgqM6/MImVQ6Xa4bRXhI IXFbL/Xb2tvQVfOge3yQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmGNR-00BIg1-7G; Wed, 04 May 2022 14:53:17 +0000 Received: from mout.kundenserver.de ([217.72.192.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmGNN-00BIec-IG; Wed, 04 May 2022 14:53:15 +0000 Received: from [192.168.1.107] ([37.4.249.94]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.183]) with ESMTPSA (Nemesis) id 1N33AR-1nycCJ2lsj-013PzA; Wed, 04 May 2022 16:53:02 +0200 Message-ID: <60a0ad1e-92d5-5032-7672-3da9ea606348@i2se.com> Date: Wed, 4 May 2022 16:53:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 1/3] staging: vchiq_arm: add reference to vchiq device in vchiq_state Content-Language: en-US To: Adrien Thierry , Nicolas Saenz Julienne , Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org References: <20220502183045.206519-1-athierry@redhat.com> <20220502183045.206519-2-athierry@redhat.com> From: Stefan Wahren In-Reply-To: <20220502183045.206519-2-athierry@redhat.com> X-Provags-ID: V03:K1:4cx/fI0q0KQihxnCwEmGDzKTjM9ADUWFfTLZ70HcPtSmBPtzahB tzLsZgHMfnal8Gkulfc3wqdhrUtbyCt+x/LY2fmxFFGIJ5S/eJEKsXmkd32xqciBBYjxpgR 0S7xAdvzXOcpEU2me8qm9YZoAo7qFrB82C2kdLMlkSTReFEQRqiJwx/yv6M6GfZa4xwDdTq zM9dCAUSc/piWdx9EKCgg== X-UI-Out-Filterresults: notjunk:1;V03:K0:lOcrTv35cJQ=:RHlZO0yymYI3yjUoZtDKn+ ofNSiUS/KnFs0t/BNFDxNipWThxlBnVdoi3XwxbQn0oupM6HCW519Ptma1i5Z0g04oyGpxLvT XregvIGc+RF6b/Cvg10bgHzuxf4pg+PzBBGQkWd+bNrbmlwtsSTkaJzFvvuYPkFI77/P5JFED zPOCgWVvv4EjcVSEQT9qYQi/41s1nFQB1vi6NWEL9EXdRZHD5ps0DzvExam+6uoLgLWBn0lO3 R08+rxP67KfaR2oFL6ZHXvFuH1iOutci2fzQadt8FFoqd4TC23wEZJqGAC9hPIvCSROpAwcQT QGE8EQrf/KN7feUFSXmmqL1Fut/NSL/0H8kG7cUWlpYGwKS8O/e3n33UDwjq3Bns2QHcSqtrf xtcMlda88JzWNwXvs21KAcxgAXnD/Go96t8Bca9qGb9bgGgft8DMTWE93I+zTw/v43hhO6W+x QbFtsa/FxQEjILqH510c0GsQduSd95iit/sfP/S7amXClId3yX8SiRVPrm2fioiqxktRuErP8 uQ8Vfjg7jvth3iI+2IWegWUw4VLOAwLt053ySVkR3TGkI6jslVtiGFol22u05K+Ye5Wb2fSew DkOfFFymcfQ7og18CRe+TetTy4K+zf6E9G5nUsDJ2rzW/egKgs78xOWwbUUSeT8mnOOgXfWju +2OSxrVIDnxKa2YyxhvRiuNLvfhWQjBv2LiLSUJ6cqB3gqsBmuCBSQ8BejWNh6V+dUdwyaBsC 31acJXmjlojhvzto X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220504_075313_947802_8787472A X-CRM114-Status: GOOD ( 21.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Adrien, Am 02.05.22 um 20:30 schrieb Adrien Thierry: > Add a reference to the vchiq device in the vchiq_state structure. This > allows the device structure to be passed around, which will be useful in > order to get rid of the global g_dev structure. the patch looks good to me. It would be nice to mention that with adding the device reference it would possible to introduce common kernel logging. Best regards > > Signed-off-by: Adrien Thierry > --- > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +- > .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 4 +++- > .../staging/vc04_services/interface/vchiq_arm/vchiq_core.h | 3 ++- > 3 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > index 0596ac61e286..e6e0737c85fc 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > @@ -519,7 +519,7 @@ int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state) > *(char **)&g_fragments_base[i * g_fragments_size] = NULL; > sema_init(&g_free_fragments_sema, MAX_FRAGMENTS); > > - err = vchiq_init_state(state, vchiq_slot_zero); > + err = vchiq_init_state(state, vchiq_slot_zero, dev); > if (err) > return err; > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c > index 8f99272dbd6f..0d5c39d7c6e2 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c > @@ -2142,7 +2142,7 @@ vchiq_init_slots(void *mem_base, int mem_size) > } > > int > -vchiq_init_state(struct vchiq_state *state, struct vchiq_slot_zero *slot_zero) > +vchiq_init_state(struct vchiq_state *state, struct vchiq_slot_zero *slot_zero, struct device *dev) > { > struct vchiq_shared_state *local; > struct vchiq_shared_state *remote; > @@ -2169,6 +2169,8 @@ vchiq_init_state(struct vchiq_state *state, struct vchiq_slot_zero *slot_zero) > > memset(state, 0, sizeof(struct vchiq_state)); > > + state->dev = dev; > + > /* > * initialize shared state pointers > */ > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h > index 82b7bd7b54b2..352017ff5309 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h > @@ -315,6 +315,7 @@ struct vchiq_slot_zero { > }; > > struct vchiq_state { > + struct device *dev; > int id; > int initialised; > enum vchiq_connstate conn_state; > @@ -458,7 +459,7 @@ extern struct vchiq_slot_zero * > vchiq_init_slots(void *mem_base, int mem_size); > > extern int > -vchiq_init_state(struct vchiq_state *state, struct vchiq_slot_zero *slot_zero); > +vchiq_init_state(struct vchiq_state *state, struct vchiq_slot_zero *slot_zero, struct device *dev); > > extern enum vchiq_status > vchiq_connect_internal(struct vchiq_state *state, struct vchiq_instance *instance); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel