From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, peter.griffin@linaro.org,
andre.draszik@linaro.org, jyescas@google.com,
kernel-team@android.com, stable@vger.kernel.org
Subject: Re: [PATCH v2 5/6] firmware: samsung: acpm: Fix out-of-bounds read and infinite loop in RX path
Date: Tue, 28 Apr 2026 16:04:16 +0300 [thread overview]
Message-ID: <60f71fd7-1079-4936-b4b0-9d45a2c112ce@linaro.org> (raw)
In-Reply-To: <20260427-acpm-fixes-sashiko-reports-v2-5-1ff8de94a997@linaro.org>
FYI, I checked sashiko's review on the set, and I shall act on this patch
and extend the checks for tx_front >= achan->qlen and add zero length checks
for qlen and mlen that were read from SRAM. I'll do that in v3.
The rest of the review feedback doesn't apply, so together with the changes
proposed in patch 4/6 that will be all.
Cheers,
ta
next prev parent reply other threads:[~2026-04-28 13:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 15:04 [PATCH v2 0/6] firmware: samsung: acpm: Various fixes for sashiko bug reports Tudor Ambarus
2026-04-27 15:04 ` [PATCH v2 1/6] firmware: samsung: acpm: Fix cross-thread RX length corruption Tudor Ambarus
2026-04-27 15:04 ` [PATCH v2 2/6] firmware: samsung: acpm: Fix mailbox channel leak on probe error Tudor Ambarus
2026-04-27 15:04 ` [PATCH v2 3/6] firmware: samsung: acpm: Fix dummy stubs to return ERR_PTR Tudor Ambarus
2026-04-27 15:04 ` [PATCH v2 4/6] firmware: samsung: acpm: Fix memory ordering race in RX path Tudor Ambarus
2026-04-28 9:52 ` Krzysztof Kozlowski
2026-04-28 12:57 ` Tudor Ambarus
2026-04-29 11:05 ` Tudor Ambarus
2026-04-27 15:04 ` [PATCH v2 5/6] firmware: samsung: acpm: Fix out-of-bounds read and infinite loop " Tudor Ambarus
2026-04-28 13:04 ` Tudor Ambarus [this message]
2026-04-27 15:04 ` [PATCH v2 6/6] firmware: samsung: acpm: Fix infinite loop on sequence number exhaustion Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60f71fd7-1079-4936-b4b0-9d45a2c112ce@linaro.org \
--to=tudor.ambarus@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=jyescas@google.com \
--cc=kernel-team@android.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox