* [PATCH 0/6] dev_err_probe usage for imx8qxp DPU pipeline
@ 2023-12-18 10:57 Alexander Stein
2023-12-18 10:57 ` [PATCH 1/6] drm/bridge: imx8qxp-pxl2dpi: Use dev_err_probe Alexander Stein
` (5 more replies)
0 siblings, 6 replies; 12+ messages in thread
From: Alexander Stein @ 2023-12-18 10:57 UTC (permalink / raw)
To: Liu Ying, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Daniel Vetter, Shawn Guo, Sascha Hauer, Fabio Estevam
Cc: Alexander Stein, Pengutronix Kernel Team, NXP Linux Team,
dri-devel, linux-arm-kernel
Hi everyone,
while working on i.MX8QXP DPU/LVDS output I come across these fixes simplifying
the code and improving debugging, while also creating less noise.
It touches several files as the output pipeline is rather complex.
Best regards,
Alexander
Alexander Stein (6):
drm/bridge: imx8qxp-pxl2dpi: Use dev_err_probe
drm/bridge: imx: imx8qxp-ldb: Use dev_err_probe
drm/bridge: imx: imx-ldb-helper: Use dev_err_probe
drm/bridge: imx8qxp-pixel-link: Use dev_err_probe
drm/bridge: dpu-dprc: Use dev_err_probe
drm/bridge: dpu-core: Don't print error on -EPROBE_DEFER
drivers/gpu/drm/bridge/imx/imx-ldb-helper.c | 13 ++-----
drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c | 37 ++++++-------------
.../gpu/drm/bridge/imx/imx8qxp-pixel-link.c | 19 +++-------
drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c | 26 ++++---------
drivers/gpu/drm/imx/dpu/dpu-core.c | 7 ++--
drivers/gpu/drm/imx/dpu/dpu-dprc.c | 12 +++---
6 files changed, 39 insertions(+), 75 deletions(-)
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/6] drm/bridge: imx8qxp-pxl2dpi: Use dev_err_probe
2023-12-18 10:57 [PATCH 0/6] dev_err_probe usage for imx8qxp DPU pipeline Alexander Stein
@ 2023-12-18 10:57 ` Alexander Stein
2023-12-18 10:57 ` [PATCH 2/6] drm/bridge: imx: imx8qxp-ldb: " Alexander Stein
` (4 subsequent siblings)
5 siblings, 0 replies; 12+ messages in thread
From: Alexander Stein @ 2023-12-18 10:57 UTC (permalink / raw)
To: Liu Ying, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Daniel Vetter, Shawn Guo, Sascha Hauer, Fabio Estevam
Cc: Alexander Stein, Pengutronix Kernel Team, NXP Linux Team,
dri-devel, linux-arm-kernel
This simplifies the code and gives additional information upon deferral.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c | 26 ++++++--------------
1 file changed, 7 insertions(+), 19 deletions(-)
diff --git a/drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c b/drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c
index 4a886cb808ca..3a1d5795d002 100644
--- a/drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c
+++ b/drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c
@@ -403,20 +403,12 @@ static int imx8qxp_pxl2dpi_bridge_probe(struct platform_device *pdev)
return -ENOMEM;
p2d->regmap = syscon_node_to_regmap(np->parent);
- if (IS_ERR(p2d->regmap)) {
- ret = PTR_ERR(p2d->regmap);
- if (ret != -EPROBE_DEFER)
- DRM_DEV_ERROR(dev, "failed to get regmap: %d\n", ret);
- return ret;
- }
+ if (IS_ERR(p2d->regmap))
+ return dev_err_probe(dev, ret, "failed to get regmap\n");
ret = imx_scu_get_handle(&p2d->ipc_handle);
- if (ret) {
- if (ret != -EPROBE_DEFER)
- DRM_DEV_ERROR(dev, "failed to get SCU ipc handle: %d\n",
- ret);
- return ret;
- }
+ if (ret)
+ return dev_err_probe(dev, ret, "failed to get SCU ipc handle\n");
p2d->dev = dev;
@@ -427,13 +419,9 @@ static int imx8qxp_pxl2dpi_bridge_probe(struct platform_device *pdev)
}
p2d->next_bridge = imx8qxp_pxl2dpi_find_next_bridge(p2d);
- if (IS_ERR(p2d->next_bridge)) {
- ret = PTR_ERR(p2d->next_bridge);
- if (ret != -EPROBE_DEFER)
- DRM_DEV_ERROR(dev, "failed to find next bridge: %d\n",
- ret);
- return ret;
- }
+ if (IS_ERR(p2d->next_bridge))
+ return dev_err_probe(dev, PTR_ERR(p2d->next_bridge),
+ "failed to find next bridge\n");
ret = imx8qxp_pxl2dpi_set_pixel_link_sel(p2d);
if (ret)
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/6] drm/bridge: imx: imx8qxp-ldb: Use dev_err_probe
2023-12-18 10:57 [PATCH 0/6] dev_err_probe usage for imx8qxp DPU pipeline Alexander Stein
2023-12-18 10:57 ` [PATCH 1/6] drm/bridge: imx8qxp-pxl2dpi: Use dev_err_probe Alexander Stein
@ 2023-12-18 10:57 ` Alexander Stein
2023-12-18 10:57 ` [PATCH 3/6] drm/bridge: imx: imx-ldb-helper: " Alexander Stein
` (3 subsequent siblings)
5 siblings, 0 replies; 12+ messages in thread
From: Alexander Stein @ 2023-12-18 10:57 UTC (permalink / raw)
To: Liu Ying, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Daniel Vetter, Shawn Guo, Sascha Hauer, Fabio Estevam
Cc: Alexander Stein, Pengutronix Kernel Team, NXP Linux Team,
dri-devel, linux-arm-kernel
This simplifies the code and gives additional information upon deferral.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c | 37 ++++++++----------------
1 file changed, 12 insertions(+), 25 deletions(-)
diff --git a/drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c b/drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c
index 7984da9c0a35..423196d2204d 100644
--- a/drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c
+++ b/drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c
@@ -557,10 +557,8 @@ static int imx8qxp_ldb_parse_dt_companion(struct imx8qxp_ldb *imx8qxp_ldb)
imx8qxp_ldb->companion = of_drm_find_bridge(companion_port);
if (!imx8qxp_ldb->companion) {
- ret = -EPROBE_DEFER;
- DRM_DEV_DEBUG_DRIVER(dev,
- "failed to find bridge for companion bridge: %d\n",
- ret);
+ ret = dev_err_probe(dev, -EPROBE_DEFER,
+ "failed to find bridge for companion bridge\n");
goto out;
}
@@ -590,22 +588,14 @@ static int imx8qxp_ldb_probe(struct platform_device *pdev)
return -ENOMEM;
imx8qxp_ldb->clk_pixel = devm_clk_get(dev, "pixel");
- if (IS_ERR(imx8qxp_ldb->clk_pixel)) {
- ret = PTR_ERR(imx8qxp_ldb->clk_pixel);
- if (ret != -EPROBE_DEFER)
- DRM_DEV_ERROR(dev,
- "failed to get pixel clock: %d\n", ret);
- return ret;
- }
+ if (IS_ERR(imx8qxp_ldb->clk_pixel))
+ return dev_err_probe(dev, PTR_ERR(imx8qxp_ldb->clk_pixel),
+ "failed to get pixel clock\n");
imx8qxp_ldb->clk_bypass = devm_clk_get(dev, "bypass");
- if (IS_ERR(imx8qxp_ldb->clk_bypass)) {
- ret = PTR_ERR(imx8qxp_ldb->clk_bypass);
- if (ret != -EPROBE_DEFER)
- DRM_DEV_ERROR(dev,
- "failed to get bypass clock: %d\n", ret);
- return ret;
- }
+ if (IS_ERR(imx8qxp_ldb->clk_bypass))
+ return dev_err_probe(dev, PTR_ERR(imx8qxp_ldb->clk_bypass),
+ "failed to get bypass clock\n");
imx8qxp_ldb->dev = dev;
@@ -640,13 +630,10 @@ static int imx8qxp_ldb_probe(struct platform_device *pdev)
}
imx8qxp_ldb_ch->phy = devm_of_phy_get(dev, ldb_ch->np, "lvds_phy");
- if (IS_ERR(imx8qxp_ldb_ch->phy)) {
- ret = PTR_ERR(imx8qxp_ldb_ch->phy);
- if (ret != -EPROBE_DEFER)
- DRM_DEV_ERROR(dev, "failed to get channel%d PHY: %d\n",
- imx8qxp_ldb->active_chno, ret);
- return ret;
- }
+ if (IS_ERR(imx8qxp_ldb_ch->phy))
+ return dev_err_probe(dev, PTR_ERR(imx8qxp_ldb_ch->phy),
+ "failed to get channel%d PHY\n",
+ imx8qxp_ldb->active_chno);
ret = ldb_find_next_bridge_helper(ldb);
if (ret)
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 3/6] drm/bridge: imx: imx-ldb-helper: Use dev_err_probe
2023-12-18 10:57 [PATCH 0/6] dev_err_probe usage for imx8qxp DPU pipeline Alexander Stein
2023-12-18 10:57 ` [PATCH 1/6] drm/bridge: imx8qxp-pxl2dpi: Use dev_err_probe Alexander Stein
2023-12-18 10:57 ` [PATCH 2/6] drm/bridge: imx: imx8qxp-ldb: " Alexander Stein
@ 2023-12-18 10:57 ` Alexander Stein
2024-01-04 19:20 ` Francesco Dolcini
2023-12-18 10:57 ` [PATCH 4/6] drm/bridge: imx8qxp-pixel-link: " Alexander Stein
` (2 subsequent siblings)
5 siblings, 1 reply; 12+ messages in thread
From: Alexander Stein @ 2023-12-18 10:57 UTC (permalink / raw)
To: Liu Ying, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Daniel Vetter, Shawn Guo, Sascha Hauer, Fabio Estevam
Cc: Alexander Stein, Pengutronix Kernel Team, NXP Linux Team,
dri-devel, linux-arm-kernel
This simplifies the code and gives additional information upon deferral.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
drivers/gpu/drm/bridge/imx/imx-ldb-helper.c | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/bridge/imx/imx-ldb-helper.c b/drivers/gpu/drm/bridge/imx/imx-ldb-helper.c
index 6967325cd8ee..9b872cfb849c 100644
--- a/drivers/gpu/drm/bridge/imx/imx-ldb-helper.c
+++ b/drivers/gpu/drm/bridge/imx/imx-ldb-helper.c
@@ -172,7 +172,7 @@ int ldb_find_next_bridge_helper(struct ldb *ldb)
{
struct device *dev = ldb->dev;
struct ldb_channel *ldb_ch;
- int ret, i;
+ int i;
for (i = 0; i < MAX_LDB_CHAN_NUM; i++) {
ldb_ch = ldb->channel[i];
@@ -182,14 +182,9 @@ int ldb_find_next_bridge_helper(struct ldb *ldb)
ldb_ch->next_bridge = devm_drm_of_get_bridge(dev, ldb_ch->np,
1, 0);
- if (IS_ERR(ldb_ch->next_bridge)) {
- ret = PTR_ERR(ldb_ch->next_bridge);
- if (ret != -EPROBE_DEFER)
- DRM_DEV_ERROR(dev,
- "failed to get next bridge: %d\n",
- ret);
- return ret;
- }
+ if (IS_ERR(ldb_ch->next_bridge))
+ return dev_err_probe(dev, PTR_ERR(ldb_ch->next_bridge),
+ "failed to find next bridge\n");
}
return 0;
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 4/6] drm/bridge: imx8qxp-pixel-link: Use dev_err_probe
2023-12-18 10:57 [PATCH 0/6] dev_err_probe usage for imx8qxp DPU pipeline Alexander Stein
` (2 preceding siblings ...)
2023-12-18 10:57 ` [PATCH 3/6] drm/bridge: imx: imx-ldb-helper: " Alexander Stein
@ 2023-12-18 10:57 ` Alexander Stein
2023-12-18 10:57 ` [PATCH 5/6] drm/bridge: dpu-dprc: " Alexander Stein
2023-12-18 10:57 ` [PATCH 6/6] drm/bridge: dpu-core: Don't print error on -EPROBE_DEFER Alexander Stein
5 siblings, 0 replies; 12+ messages in thread
From: Alexander Stein @ 2023-12-18 10:57 UTC (permalink / raw)
To: Liu Ying, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Daniel Vetter, Shawn Guo, Sascha Hauer, Fabio Estevam
Cc: Alexander Stein, Pengutronix Kernel Team, NXP Linux Team,
dri-devel, linux-arm-kernel
This simplifies the code and gives additional information upon deferral.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
.../gpu/drm/bridge/imx/imx8qxp-pixel-link.c | 19 ++++++-------------
1 file changed, 6 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c b/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c
index ed8b7a4e0e11..b8cc1df3e572 100644
--- a/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c
+++ b/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c
@@ -338,12 +338,9 @@ static int imx8qxp_pixel_link_bridge_probe(struct platform_device *pdev)
return -ENOMEM;
ret = imx_scu_get_handle(&pl->ipc_handle);
- if (ret) {
- if (ret != -EPROBE_DEFER)
- DRM_DEV_ERROR(dev, "failed to get SCU ipc handle: %d\n",
- ret);
- return ret;
- }
+ if (ret)
+ return dev_err_probe(dev, ret,
+ "failed to get SCU ipc handle\n");
ret = of_property_read_u8(np, "fsl,dc-id", &pl->dc_id);
if (ret) {
@@ -379,13 +376,9 @@ static int imx8qxp_pixel_link_bridge_probe(struct platform_device *pdev)
return ret;
pl->next_bridge = imx8qxp_pixel_link_find_next_bridge(pl);
- if (IS_ERR(pl->next_bridge)) {
- ret = PTR_ERR(pl->next_bridge);
- if (ret != -EPROBE_DEFER)
- DRM_DEV_ERROR(dev, "failed to find next bridge: %d\n",
- ret);
- return ret;
- }
+ if (IS_ERR(pl->next_bridge))
+ return dev_err_probe(dev, PTR_ERR(pl->next_bridge),
+ "failed to find next bridge\n");
platform_set_drvdata(pdev, pl);
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 5/6] drm/bridge: dpu-dprc: Use dev_err_probe
2023-12-18 10:57 [PATCH 0/6] dev_err_probe usage for imx8qxp DPU pipeline Alexander Stein
` (3 preceding siblings ...)
2023-12-18 10:57 ` [PATCH 4/6] drm/bridge: imx8qxp-pixel-link: " Alexander Stein
@ 2023-12-18 10:57 ` Alexander Stein
2023-12-18 12:03 ` Alexander Stein
2023-12-18 10:57 ` [PATCH 6/6] drm/bridge: dpu-core: Don't print error on -EPROBE_DEFER Alexander Stein
5 siblings, 1 reply; 12+ messages in thread
From: Alexander Stein @ 2023-12-18 10:57 UTC (permalink / raw)
To: Liu Ying, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Daniel Vetter, Shawn Guo, Sascha Hauer, Fabio Estevam
Cc: Alexander Stein, Pengutronix Kernel Team, NXP Linux Team,
dri-devel, linux-arm-kernel
This simplifies the code and gives additional information upon deferral.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
drivers/gpu/drm/imx/dpu/dpu-dprc.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/imx/dpu/dpu-dprc.c b/drivers/gpu/drm/imx/dpu/dpu-dprc.c
index 261c9566721e..6467ad960080 100644
--- a/drivers/gpu/drm/imx/dpu/dpu-dprc.c
+++ b/drivers/gpu/drm/imx/dpu/dpu-dprc.c
@@ -612,7 +612,8 @@ static int dpu_dprc_probe(struct platform_device *pdev)
dprc->prgs[i] = dpu_prg_lookup_by_phandle(dev, "fsl,prgs", i);
if (!dprc->prgs[i])
- return -EPROBE_DEFER;
+ return dev_err_probe(dev, -EPROBE_DEFER,
+ "Failed to lookup fsl,prgs\n");
if (i == 1)
dpu_prg_set_auxiliary(dprc->prgs[i]);
@@ -623,11 +624,10 @@ static int dpu_dprc_probe(struct platform_device *pdev)
ret = devm_request_irq(dev, wrap_irq, dpu_dprc_wrap_irq_handler,
IRQF_SHARED, dev_name(dev), dprc);
- if (ret < 0) {
- dev_err(dev, "failed to request dpr_wrap irq(%u): %d\n",
- wrap_irq, ret);
- return ret;
- }
+ if (ret < 0)
+ return dev_err_probe(dev, ret,
+ "failed to request dpr_wrap irq(%u)\n",
+ wrap_irq);
platform_set_drvdata(pdev, dprc);
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 6/6] drm/bridge: dpu-core: Don't print error on -EPROBE_DEFER
2023-12-18 10:57 [PATCH 0/6] dev_err_probe usage for imx8qxp DPU pipeline Alexander Stein
` (4 preceding siblings ...)
2023-12-18 10:57 ` [PATCH 5/6] drm/bridge: dpu-dprc: " Alexander Stein
@ 2023-12-18 10:57 ` Alexander Stein
2023-12-18 12:03 ` Alexander Stein
5 siblings, 1 reply; 12+ messages in thread
From: Alexander Stein @ 2023-12-18 10:57 UTC (permalink / raw)
To: Liu Ying, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Daniel Vetter, Shawn Guo, Sascha Hauer, Fabio Estevam
Cc: Alexander Stein, Pengutronix Kernel Team, NXP Linux Team,
dri-devel, linux-arm-kernel
-517 errors are just annoying. dev_err_probe can't be used here either
as this would hide the error message already set in us->init.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
drivers/gpu/drm/imx/dpu/dpu-core.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/imx/dpu/dpu-core.c b/drivers/gpu/drm/imx/dpu/dpu-core.c
index d6116b3e4ed7..ea2558a14a6c 100644
--- a/drivers/gpu/drm/imx/dpu/dpu-core.c
+++ b/drivers/gpu/drm/imx/dpu/dpu-core.c
@@ -592,9 +592,10 @@ static int dpu_submodules_init(struct dpu_soc *dpu, unsigned long dpu_base)
ret = us->init(dpu, j, us->ids[j], us->types[j],
pec_ofs, dpu_base + us->ofss[j]);
if (ret) {
- dev_err(dpu->dev,
- "failed to initialize %s%d: %d\n",
- us->name, us->ids[j], ret);
+ if (ret != -EPROBE_DEFER)
+ dev_err(dpu->dev,
+ "failed to initialize %s%d: %d\n",
+ us->name, us->ids[j], ret);
return ret;
}
}
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 5/6] drm/bridge: dpu-dprc: Use dev_err_probe
2023-12-18 10:57 ` [PATCH 5/6] drm/bridge: dpu-dprc: " Alexander Stein
@ 2023-12-18 12:03 ` Alexander Stein
0 siblings, 0 replies; 12+ messages in thread
From: Alexander Stein @ 2023-12-18 12:03 UTC (permalink / raw)
To: Liu Ying, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Daniel Vetter, Shawn Guo, Sascha Hauer, Fabio Estevam
Cc: Pengutronix Kernel Team, NXP Linux Team, dri-devel,
linux-arm-kernel
Am Montag, 18. Dezember 2023, 11:57:17 CET schrieb Alexander Stein:
> This simplifies the code and gives additional information upon deferral.
Please ignore. I just noticed this file is added in a locally applied series.
Thanks
Alexander
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> drivers/gpu/drm/imx/dpu/dpu-dprc.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/imx/dpu/dpu-dprc.c
> b/drivers/gpu/drm/imx/dpu/dpu-dprc.c index 261c9566721e..6467ad960080
> 100644
> --- a/drivers/gpu/drm/imx/dpu/dpu-dprc.c
> +++ b/drivers/gpu/drm/imx/dpu/dpu-dprc.c
> @@ -612,7 +612,8 @@ static int dpu_dprc_probe(struct platform_device *pdev)
>
> dprc->prgs[i] = dpu_prg_lookup_by_phandle(dev, "fsl,prgs",
i);
> if (!dprc->prgs[i])
> - return -EPROBE_DEFER;
> + return dev_err_probe(dev, -EPROBE_DEFER,
> + "Failed to lookup
fsl,prgs\n");
>
> if (i == 1)
> dpu_prg_set_auxiliary(dprc->prgs[i]);
> @@ -623,11 +624,10 @@ static int dpu_dprc_probe(struct platform_device
> *pdev)
>
> ret = devm_request_irq(dev, wrap_irq, dpu_dprc_wrap_irq_handler,
> IRQF_SHARED, dev_name(dev), dprc);
> - if (ret < 0) {
> - dev_err(dev, "failed to request dpr_wrap irq(%u): %d\n",
> - wrap_irq, ret);
> - return ret;
> - }
> + if (ret < 0)
> + return dev_err_probe(dev, ret,
> + "failed to request dpr_wrap
irq(%u)\n",
> + wrap_irq);
>
> platform_set_drvdata(pdev, dprc);
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 6/6] drm/bridge: dpu-core: Don't print error on -EPROBE_DEFER
2023-12-18 10:57 ` [PATCH 6/6] drm/bridge: dpu-core: Don't print error on -EPROBE_DEFER Alexander Stein
@ 2023-12-18 12:03 ` Alexander Stein
0 siblings, 0 replies; 12+ messages in thread
From: Alexander Stein @ 2023-12-18 12:03 UTC (permalink / raw)
To: Liu Ying, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Daniel Vetter, Shawn Guo, Sascha Hauer, Fabio Estevam
Cc: Pengutronix Kernel Team, NXP Linux Team, dri-devel,
linux-arm-kernel
Am Montag, 18. Dezember 2023, 11:57:18 CET schrieb Alexander Stein:
> -517 errors are just annoying. dev_err_probe can't be used here either
> as this would hide the error message already set in us->init.
Please ignore. I just noticed this file is added in a locally applied series.
Thanks
Alexander
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> drivers/gpu/drm/imx/dpu/dpu-core.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/imx/dpu/dpu-core.c
> b/drivers/gpu/drm/imx/dpu/dpu-core.c index d6116b3e4ed7..ea2558a14a6c
> 100644
> --- a/drivers/gpu/drm/imx/dpu/dpu-core.c
> +++ b/drivers/gpu/drm/imx/dpu/dpu-core.c
> @@ -592,9 +592,10 @@ static int dpu_submodules_init(struct dpu_soc *dpu,
> unsigned long dpu_base) ret = us->init(dpu, j, us->ids[j], us->types[j],
> pec_ofs, dpu_base + us-
>ofss[j]);
> if (ret) {
> - dev_err(dpu->dev,
> - "failed to initialize %s%d:
%d\n",
> - us->name, us-
>ids[j], ret);
> + if (ret != -EPROBE_DEFER)
> + dev_err(dpu->dev,
> + "failed to
initialize %s%d: %d\n",
> + us-
>name, us->ids[j], ret);
> return ret;
> }
> }
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 3/6] drm/bridge: imx: imx-ldb-helper: Use dev_err_probe
2023-12-18 10:57 ` [PATCH 3/6] drm/bridge: imx: imx-ldb-helper: " Alexander Stein
@ 2024-01-04 19:20 ` Francesco Dolcini
2024-01-04 19:28 ` Francesco Dolcini
0 siblings, 1 reply; 12+ messages in thread
From: Francesco Dolcini @ 2024-01-04 19:20 UTC (permalink / raw)
To: Alexander Stein
Cc: Liu Ying, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Daniel Vetter, Shawn Guo, Sascha Hauer, Fabio Estevam,
Pengutronix Kernel Team, NXP Linux Team, dri-devel,
linux-arm-kernel
On Mon, Dec 18, 2023 at 11:57:15AM +0100, Alexander Stein wrote:
> This simplifies the code and gives additional information upon deferral.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 3/6] drm/bridge: imx: imx-ldb-helper: Use dev_err_probe
2024-01-04 19:20 ` Francesco Dolcini
@ 2024-01-04 19:28 ` Francesco Dolcini
2024-01-08 9:36 ` Alexander Stein
0 siblings, 1 reply; 12+ messages in thread
From: Francesco Dolcini @ 2024-01-04 19:28 UTC (permalink / raw)
To: Francesco Dolcini
Cc: Alexander Stein, Liu Ying, Andrzej Hajda, Neil Armstrong,
Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Daniel Vetter, Shawn Guo, Sascha Hauer, Fabio Estevam,
Pengutronix Kernel Team, NXP Linux Team, dri-devel,
linux-arm-kernel
On Thu, Jan 04, 2024 at 08:20:37PM +0100, Francesco Dolcini wrote:
> On Mon, Dec 18, 2023 at 11:57:15AM +0100, Alexander Stein wrote:
> > This simplifies the code and gives additional information upon deferral.
> >
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>
mumble, looking at this more closely with your change you stop using
the print wrapper from drm_print.h. Probably a more generic solution is
needed there?
Francesco
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 3/6] drm/bridge: imx: imx-ldb-helper: Use dev_err_probe
2024-01-04 19:28 ` Francesco Dolcini
@ 2024-01-08 9:36 ` Alexander Stein
0 siblings, 0 replies; 12+ messages in thread
From: Alexander Stein @ 2024-01-08 9:36 UTC (permalink / raw)
To: Francesco Dolcini, Francesco Dolcini
Cc: Liu Ying, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Daniel Vetter, Shawn Guo, Sascha Hauer, Fabio Estevam,
Pengutronix Kernel Team, NXP Linux Team, dri-devel,
linux-arm-kernel
Hi Francesco,
thanks for the feedback.
Am Donnerstag, 4. Januar 2024, 20:28:08 CET schrieb Francesco Dolcini:
> On Thu, Jan 04, 2024 at 08:20:37PM +0100, Francesco Dolcini wrote:
> > On Mon, Dec 18, 2023 at 11:57:15AM +0100, Alexander Stein wrote:
> > > This simplifies the code and gives additional information upon deferral.
> > >
> > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> >
> > Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>
>
> mumble, looking at this more closely with your change you stop using
> the print wrapper from drm_print.h. Probably a more generic solution is
> needed there?
You are talking about DRM_DEV_ERROR()? Well, it's deprecated, see [1]. Instead
of dev_err, I rather use dev_err_probe because this is what we want to use
here.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/
include/drm/drm_print.h#n365
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2024-01-08 9:37 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-18 10:57 [PATCH 0/6] dev_err_probe usage for imx8qxp DPU pipeline Alexander Stein
2023-12-18 10:57 ` [PATCH 1/6] drm/bridge: imx8qxp-pxl2dpi: Use dev_err_probe Alexander Stein
2023-12-18 10:57 ` [PATCH 2/6] drm/bridge: imx: imx8qxp-ldb: " Alexander Stein
2023-12-18 10:57 ` [PATCH 3/6] drm/bridge: imx: imx-ldb-helper: " Alexander Stein
2024-01-04 19:20 ` Francesco Dolcini
2024-01-04 19:28 ` Francesco Dolcini
2024-01-08 9:36 ` Alexander Stein
2023-12-18 10:57 ` [PATCH 4/6] drm/bridge: imx8qxp-pixel-link: " Alexander Stein
2023-12-18 10:57 ` [PATCH 5/6] drm/bridge: dpu-dprc: " Alexander Stein
2023-12-18 12:03 ` Alexander Stein
2023-12-18 10:57 ` [PATCH 6/6] drm/bridge: dpu-core: Don't print error on -EPROBE_DEFER Alexander Stein
2023-12-18 12:03 ` Alexander Stein
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).