From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA653C3DA6E for ; Mon, 8 Jan 2024 09:37:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fS1+iVc5Nauoj2PHrBa6Kp40DXt0U67yt3y2Gh6lAIk=; b=S5lnHSvq+VhqLS /xhoGHDvEUeAT6kcaDUWW9qWonGTs4YtZfus151OsL20Ih0CP/AjPvwo0MBMR9cbu5xm3nWXxZhv2 f1/BMYZKha2jPONuXDYMKdo0X6x84mfaHPkmskqOrbyJqbQjlUCnb49Lf8gyOddwQAoAr6bPSatZw bdF0UmUGSbLZSIkfFE4Bg7XkG7Uoq6apM6wR8H2HXPID5hSU7zuHdpV1BgXFUal4W5nfkQf7/3uas qn47XxlIvANDRCFeOh71rV9K2XxTLYqalPwA05OXYxSQZA+sDovDkEKcectuBFKBs0c9DO3ENACAY I9h64cN+ec/QX0zLuzig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rMm4D-004Ur0-0F; Mon, 08 Jan 2024 09:37:09 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rMm4A-004Uov-1G for linux-arm-kernel@lists.infradead.org; Mon, 08 Jan 2024 09:37:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1704706626; x=1736242626; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=9u6X44w9k8SfVi17eVGHwXQBmC6WQZ/mGwNTui5DzTc=; b=JWmLTNqzDlpddX0mIIqLV1WNnWQobsZN6S2G32rDppG1GnzXasfn6sTM 2GNxaAalh2LGUWVA+7qBL/sG3YWxsqrq8sojn0hHmpK0sMimGRCrCpGId GIequx3Yi0fSU0HCQXU27BhkL6+MLkum3u4biAIH9lMzSTZSB9OReOc32 DibwY+LqdGpE1MuPdKhSwqeZPJOYI6puOqs1MJGvVcp+NnfXqqvBbYkI3 ZuWnSBVzX9qvlZlh9CpHd8SPFLyZBJ9hJjm0sL5T2owtHDZF2i+kaF+Vp YPxPxf6iVM583R3QYj+TWfmJo5U5biL/ffYA+JWXA2NowDgj5amDQv3fa Q==; X-IronPort-AV: E=Sophos;i="6.04,340,1695679200"; d="scan'208";a="34781875" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 08 Jan 2024 10:36:58 +0100 Received: from steina-w.localnet (steina-w.tq-net.de [10.123.53.25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 0EE9F280075; Mon, 8 Jan 2024 10:36:58 +0100 (CET) From: Alexander Stein To: Francesco Dolcini , Francesco Dolcini Cc: Liu Ying , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Fabio Estevam , Pengutronix Kernel Team , NXP Linux Team , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/6] drm/bridge: imx: imx-ldb-helper: Use dev_err_probe Date: Mon, 08 Jan 2024 10:36:57 +0100 Message-ID: <6100371.DvuYhMxLoT@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20240104192808.GB20694@francesco-nb> References: <20231218105718.2445136-1-alexander.stein@ew.tq-group.com> <20240104191928.GA20694@francesco-nb> <20240104192808.GB20694@francesco-nb> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240108_013706_746152_47C23900 X-CRM114-Status: GOOD ( 11.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Francesco, thanks for the feedback. Am Donnerstag, 4. Januar 2024, 20:28:08 CET schrieb Francesco Dolcini: > On Thu, Jan 04, 2024 at 08:20:37PM +0100, Francesco Dolcini wrote: > > On Mon, Dec 18, 2023 at 11:57:15AM +0100, Alexander Stein wrote: > > > This simplifies the code and gives additional information upon deferr= al. > > > = > > > Signed-off-by: Alexander Stein > > = > > Reviewed-by: Francesco Dolcini > = > mumble, looking at this more closely with your change you stop using > the print wrapper from drm_print.h. Probably a more generic solution is > needed there? You are talking about DRM_DEV_ERROR()? Well, it's deprecated, see [1]. Inst= ead = of dev_err, I rather use dev_err_probe because this is what we want to use = here. [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tre= e/ include/drm/drm_print.h#n365 -- = TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel