From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm: Support for the PXN CPU feature on ARMv7
Date: Wed, 26 Nov 2014 09:48:52 +0100 [thread overview]
Message-ID: <6108655.KIqtjFdn4U@wuerfel> (raw)
In-Reply-To: <1416981921-19643-1-git-send-email-js07.lee@gmail.com>
On Wednesday 26 November 2014 15:05:21 Jungseung Lee wrote:
> +#if __LINUX_ARM_ARCH__ >= 6 && !defined(CONFIG_ARM_LPAE)
> +static inline bool cpu_has_classic_pxn(void)
> +{
> + static unsigned int vmsa = ~0UL;
> +
> + if (cpu_architecture() != CPU_ARCH_ARMv7)
> + return false;
> + if (vmsa == 4)
> + return true;
> +
> + vmsa = (read_cpuid_ext(CPUID_EXT_MMFR0) & 0xf) >> 0;
> + return vmsa == 4;
> +}
> +#else
> +static inline bool cpu_has_classic_pxn(void)
> +{
> + return false;
> +}
> +#endif
> +
>
As mentioned before, please turn the #ifdef into an "if (IS_ENABLED(...))" check.
The 'if (vmsa == 4)' check above looks like it came from an earlier version
and is always false, so just drop that.
Arnd
next prev parent reply other threads:[~2014-11-26 8:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 6:05 [PATCH v2] arm: Support for the PXN CPU feature on ARMv7 Jungseung Lee
2014-11-26 8:48 ` Arnd Bergmann [this message]
2014-11-26 10:05 ` Jungseung Lee
2014-11-26 12:07 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6108655.KIqtjFdn4U@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox