From: stillcompiling@gmail.com (Joshua Clayton)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/7] Change snvs rtc and poweroff to use syscon add pwrkey driver
Date: Wed, 20 May 2015 07:46:18 -0700 [thread overview]
Message-ID: <6111368.e0EOBSJsmZ@jclayton-pc> (raw)
In-Reply-To: <CAHrpEqSpeMO=zLyii8qZUznP+9EAQqJ-D3O8hbXj99m+UNvpzA@mail.gmail.com>
>
> + snvs_np = of_get_parent(pdev->dev.of_node);
> + if (!snvs_np)
> + return -ENODEV;
> +
> + data->snvs = syscon_node_to_regmap(snvs_np);
> + of_node_put(snvs_np);
> +
> + if (!data->snvs) {
> + pr_err("Can't snvs syscon\n");
> + return -ENODEV;
> + }
>
> How about change error message to " Can't snvs syscon, probably use
> old dts file"?
How about simply: "Cannot find snvs syscon node in devicetree."
--
~Joshua Clayton
next prev parent reply other threads:[~2015-05-20 14:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 17:04 [PATCH v2 0/7] Change snvs rtc and poweroff to use syscon add pwrkey driver Frank.Li at freescale.com
2015-05-19 17:04 ` [PATCH v2 1/7] arm: imx: power-off: change to syscon to access register Frank.Li at freescale.com
2015-05-19 17:04 ` [PATCH v2 2/7] rtc: arm: imx: snvs: change use " Frank.Li at freescale.com
2015-05-19 20:46 ` Alexandre Belloni
2015-05-19 17:04 ` [PATCH v2 3/7] Document: dt: fsl: snvs: change support syscon Frank.Li at freescale.com
2015-05-19 17:04 ` [PATCH v2 4/7] arm: dts: imx: update snvs to use syscon access register Frank.Li at freescale.com
2015-05-19 17:04 ` [PATCH v2 5/7] input: keyboard: imx: add snvs power key driver Frank.Li at freescale.com
2015-05-19 17:04 ` [PATCH v2 6/7] document: devicetree: input: imx: i.mx snvs power device tree bindings Frank.Li at freescale.com
2015-05-19 17:04 ` [PATCH v2 7/7] arm: dts: imx6sx: enable snvs power key Frank.Li at freescale.com
2015-05-20 1:58 ` [PATCH v2 0/7] Change snvs rtc and poweroff to use syscon add pwrkey driver Shawn Guo
2015-05-20 2:44 ` Zhi Li
2015-05-20 14:22 ` Shawn Guo
2015-05-20 14:30 ` Zhi Li
2015-05-20 14:46 ` Joshua Clayton [this message]
2015-05-20 15:03 ` Zhi Li
2015-05-20 18:25 ` Russell King - ARM Linux
2015-05-20 18:30 ` Russell King - ARM Linux
2015-05-20 18:44 ` Zhi Li
2015-05-20 21:56 ` Russell King - ARM Linux
2015-05-21 0:20 ` Dmitry Torokhov
2015-05-21 1:16 ` Zhi Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6111368.e0EOBSJsmZ@jclayton-pc \
--to=stillcompiling@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox