From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85E6EC63777 for ; Mon, 30 Nov 2020 21:31:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C95A920857 for ; Mon, 30 Nov 2020 21:31:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rAxyhbCi"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S6efCwhA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C95A920857 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Qx4+fTeCzJnOBxhPC+A6Orsv9vnpkv/MMDFTL04DXeY=; b=rAxyhbCiq5KkCL3DCuHWpGaG9 ig+ym5CLKAWx+EsnKDxklVkhVhDD3JO1SuhLS6/7B0yqcfkDbS93PQMezZ2wzuwD8pfJ3WXRL+zp2 SKRRkGFCsVDhC3KpOGg1jSh03FLg5ASDjskqZC3QXov9Kzb1nzX+Eca1MkiRXaQ7WvhaKqv7qO66/ jG5krRZbNcXn9RYJ86UvSkAVc5u3ETQrIBjC7c0Z2mlImViOXC0nsBITaBr93KTg5781Skl01pAru cJAYORrvOzQEptg9Zo68kWQ33JVcmqA7Q73UJ7uBcoc0AWczHZi+YO1ODPf0+N2p3mKlFVSS5LqJT ZHy6VyVNg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjqjx-0007YB-9r; Mon, 30 Nov 2020 21:29:45 +0000 Received: from mail-pj1-x1043.google.com ([2607:f8b0:4864:20::1043]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjqju-0007XO-VZ; Mon, 30 Nov 2020 21:29:43 +0000 Received: by mail-pj1-x1043.google.com with SMTP id r9so387973pjl.5; Mon, 30 Nov 2020 13:29:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DWjJunM0Wmbz4s0jLkRrF2o5zQCdYXKHU/3KOiaHX/M=; b=S6efCwhAKHYgtmjmpD8Hzvbp9i8StDx5Lz4NYJ+CYPPhd1Zdg6rHUdBz7jUbMNU6pc 941P4fvSONwd1o6AMsUgGYvTHbO7j4sVS79F+79/J/xzbJHw9JBfyKb4BUH7OXiwlsuT SVWeo/63fBGZs4O9zdSnhq4K4rSof2wTCioSBw1rdW87M7bJOVKhjR0aThQohLTNLxcR sMLmqwIdwPZ9azDp5kJsdiZTbQqrZeXL9d6Dd3FlLJX1OCIShw9PpGR6fBjz3406BkSU qOl+hWW4gB3cABxugXx+xI2D9dQs72JNVxS8BWQKU5ZSBboje0eKCKEFjYw4WyQEzr41 aZkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DWjJunM0Wmbz4s0jLkRrF2o5zQCdYXKHU/3KOiaHX/M=; b=YxylGooR3G0ePDk4AruJrw28JB4aF2dk8RSs13sGOCJmxwv6ix0e7uVCFySnBncYH5 yOU5F7slCEzmYo+8l+H4UnOo3h6IaWuaEjlE6inVQKuUE4uPDNf0PPkdh2UL1hf///wS N6f1e+VQ5+OBEy3Li6AMRp1qrrYBpqqoA+hVoqKWdQ2mBy54wYpKC+/uqAcDJkXrsiT6 gWoqVKFAhwl+riVeK1FWL90glEF8e6z9SwwlBsGmEGzxNGWF3dwTnVRi4fuUtnoNtA45 cOk0Hllv8vgJi/W/0g4ElzMrxoiVfnqu62w6Yu1Rypqs1njDzsZ7YVTrituGc8Tv+0Ah ux+Q== X-Gm-Message-State: AOAM531ZVr9nf8j1FMAQ5Uflh7sMLNfDunCW5fXUW9yiVo8CF0NQ62Gi OXVL/p1RFQeADQ34Br3YbSE= X-Google-Smtp-Source: ABdhPJx6xEcDW4s+3ILXmaqfiWlW4K6oWLF0llNuwsYlkl0IYU3Vc3Vujp6Hom2s3vThV73o2mcYqw== X-Received: by 2002:a17:90a:6b0d:: with SMTP id v13mr897481pjj.206.1606771781097; Mon, 30 Nov 2020 13:29:41 -0800 (PST) Received: from [10.230.28.242] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id g6sm3923074pjd.3.2020.11.30.13.29.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Nov 2020 13:29:40 -0800 (PST) Subject: Re: [PATCH v2 3/6] PCI: brcmstb: Do not turn off regulators if EP can wake up To: Jim Quinlan , linux-pci@vger.kernel.org, Nicolas Saenz Julienne , broonie@kernel.org, bcm-kernel-feedback-list@broadcom.com References: <20201130211145.3012-1-james.quinlan@broadcom.com> <20201130211145.3012-4-james.quinlan@broadcom.com> From: Florian Fainelli Message-ID: <611680c5-d889-41c6-a9ff-ac69b47cdb24@gmail.com> Date: Mon, 30 Nov 2020 13:29:37 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201130211145.3012-4-james.quinlan@broadcom.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201130_162943_058299_A95FFD94 X-CRM114-Status: GOOD ( 11.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Lorenzo Pieralisi , open list , Florian Fainelli , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , Bjorn Helgaas , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/30/2020 1:11 PM, Jim Quinlan wrote: > If any downstream device may wake up during S2/S3 suspend, we do not want > to turn off its power when suspending. > > Signed-off-by: Jim Quinlan Looks good to me, just one minor typo below: > +enum { > + TURN_OFF, /* Turn egulators off, unless an EP is wakeup-capable */ s/egulators/regulators/ > + TURN_OFF_ALWAYS, /* Turn Regulators off, no exceptions */ > + TURN_ON, /* Turn regulators on, unless pcie->ep_wakeup_capable */ -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel