From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7CA77EB64DC for ; Fri, 21 Jul 2023 12:00:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jNRs5fcvRHllAVNYyefbktN1PzfkQFFN5EvAKJzrj3M=; b=rQblt3k/eqCoxP /Fo6n4LpQG07sNm/3Zx5NrZlQehUEfZIfyeBa74E3kizknpu+GWf9CrXBqD/W4o3025mxwpbLRCc9 M4N4wXgJ91O44ZeUeB1IhK+hzTxN3ax3zQTBY2DDJP0epiy/iRMH/zTmgb+vlEBwlyKi/Lv93hT+3 u4yzRtKRx0UQjDQpoARae47jdPkK7ij6/fPJRKfvebFAYKPdCdGe7opL+SNomvBCoxn2yvvVmW7n5 KC1loOU+3EAOtxWU34Hup2PMFXNcxQnyk534OVyCAAaWZXfjkelqueFPjBjYjvodovGM5Kr3k+CHo 0CVwAI5WBYFhNw3q00UQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qMonV-00DzWI-0e; Fri, 21 Jul 2023 11:59:49 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qMonS-00DzS0-1l for linux-arm-kernel@lists.infradead.org; Fri, 21 Jul 2023 11:59:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689940784; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4Y7rbnaDJbn/YejSF4mQVA8Z4grlfMZHjKPnDFxLZ8A=; b=YHXM7KcASdfLkCmk6CoRB72/QDK4OrdLrBvJOV0dmj6dvtr5W4iyzaQ8zq5ogSIW2K8sd2 AyrJDQhEqno3eUs4XUImLLHNqJ+5X7vtpDt+XkEJiEODpN8WBJJ3vyZr7sWNMiH0QK1Cq8 BFx00o/DhAWw79gVMgpmqqsHqxndlNQ= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-569-nzx1gKzJMn6Hp14UySHauw-1; Fri, 21 Jul 2023 07:59:41 -0400 X-MC-Unique: nzx1gKzJMn6Hp14UySHauw-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-993d7ca4607so118760866b.1 for ; Fri, 21 Jul 2023 04:59:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689940780; x=1690545580; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4Y7rbnaDJbn/YejSF4mQVA8Z4grlfMZHjKPnDFxLZ8A=; b=fUvw70oEWIPGMsOto5b3bSPKTHDxvoLJ3eiJVgio32tRuJDzKxqPBLGbhD1pjWlmas zYBoXumMDpONAF6BhbYhV18MaZTUbaWPCeQmubL7mO4+ZRiXCWvmSlFuW+/EFYNbZdO5 +asGiRPH672lZNTC66fCZnT47oo5ncmZH+bxBTsuEGWzTNql/pgIyK1lBSc82SF3vw/C KUZjptPsofswij39YvkTFghFUdayALs9BKT5pzzmmsiibBpURh5QkbC1z3tZCvZDTCBe YyFj/AEQoEd3zKgPxmS3V6uPA/np3ZfD+j4kOf+Pi/5A7eEnuInS47gn9W785wRtXFvv FEWw== X-Gm-Message-State: ABy/qLZRJv6AYsGITCeiVeS8HWl6UC9s8CgZom3z0isJ+W5f2h7pV0iU GGujEUyHujkPsFo/0ZXrCSPGy9qtC3TxJPEf9mPFXmt/PgVeVynInfFyFmjm/ZDHzVfEYLYV5tj h5j3lgjy7CX2ABCWwWG/YX6VU6lTHbbsyxjc= X-Received: by 2002:a17:906:2da:b0:994:54af:e282 with SMTP id 26-20020a17090602da00b0099454afe282mr1360617ejk.10.1689940779999; Fri, 21 Jul 2023 04:59:39 -0700 (PDT) X-Google-Smtp-Source: APBJJlEk/l1rT7vVGyK6B+M0/vN6OF6CipTv2G0AE0UWGqg9sgFPNWcoUSGmc+Sw2v1G9OPem3PIcQ== X-Received: by 2002:a17:906:2da:b0:994:54af:e282 with SMTP id 26-20020a17090602da00b0099454afe282mr1360600ejk.10.1689940779630; Fri, 21 Jul 2023 04:59:39 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:9af8:e5f5:7516:fa89? ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.googlemail.com with ESMTPSA id um15-20020a170906cf8f00b00992b3ea1ee3sm2078970ejb.159.2023.07.21.04.59.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Jul 2023 04:59:38 -0700 (PDT) Message-ID: <6118063e-5c91-acc4-129f-3bacc19f25ce@redhat.com> Date: Fri, 21 Jul 2023 13:59:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [RFC PATCH v11 09/29] KVM: x86: Disallow hugepages when memory attributes are mixed To: Sean Christopherson , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Fuad Tabba , Jarkko Sakkinen , Yu Zhang , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , Vlastimil Babka , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-10-seanjc@google.com> From: Paolo Bonzini In-Reply-To: <20230718234512.1690985-10-seanjc@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230721_045946_657448_4494836F X-CRM114-Status: GOOD ( 12.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/19/23 01:44, Sean Christopherson wrote: > +static bool range_has_attrs(struct kvm *kvm, gfn_t start, gfn_t end, > + unsigned long attrs) > +{ > + XA_STATE(xas, &kvm->mem_attr_array, start); > + unsigned long index; > + bool has_attrs; > + void *entry; > + > + rcu_read_lock(); > + > + if (!attrs) { > + has_attrs = !xas_find(&xas, end); > + goto out; > + } > + > + has_attrs = true; > + for (index = start; index < end; index++) { > + do { > + entry = xas_next(&xas); > + } while (xas_retry(&xas, entry)); > + > + if (xas.xa_index != index || xa_to_value(entry) != attrs) { > + has_attrs = false; > + break; > + } > + } > + > +out: > + rcu_read_unlock(); > + return has_attrs; > +} > + Can you move this function to virt/kvm/kvm_main.c? Thanks, Paolo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel