From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11F3DC25B75 for ; Wed, 29 May 2024 08:15:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qmf+IPMhXNg5y7NJ1f4v3m7T8icF6vs2fpVr+poFEkU=; b=OQNch7NAvqaOlc nnN4zclb4fKcC5ADkOL6zceIScVzfPzlGtyolNrD2vkurGBBYBX6Ay20BmmvjYVA214B3otI+7FG/ h2hJlfpYLc2/wdrfCl7Gz3Ur9xg3nN3f11mqEIuKcz8hDdo/5jMsIWR//XyYvKjFQOIWB5ASqzWUY Ew+Wo6/bTtjg798s3WeOvE97L/5ULyezFYsRw9riN/t26qNcag/7kvt5pG/W1Emy4QQkz3URk9bDD CS/bLIt4AJjf894cdsp65xOO5/232FEqPk6g767mkWe1ceqZLBBBtVOFF7xjmpAFZOrtv5UAhFKh8 mNTr1Z1927fNjOy/fXOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCET8-00000003KGp-1bLe; Wed, 29 May 2024 08:15:34 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCET3-00000003KFQ-45f0 for linux-arm-kernel@lists.infradead.org; Wed, 29 May 2024 08:15:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1716970530; x=1748506530; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=qPzqmbhWrWgXeytPFFr8ZnaAVt6ESUekqElZje8ecik=; b=Jk7z6c5M+mAGvnZbQgem19LF92ipkxHhC/iUUkPSZ/82GWFq6jTXlelK 7PHGZuwt5R2jRDEdIF+vW1zN2QcVpVH+T/suvPQilhFzk07XJAUxC2GNg L9Mrs8Xr5yPY8dLsKkv2Ktwss2hKH8Dwk8FPJ8UU2VjITbet6qAZC4YzP JGcyAAj1tFGkou42aphuPtHSIJvDA49xjcBWROvM8pnOcU2awm+FosfHq YPvCQnDakzybY7gOWfpRFvDDShc1QFYYqq3Gauckc9G0rkFCOCFOlH4su RnnZp961HNDWABb5asQ0QWFwEez8UrV335EEN+7e5Ku3Pu0c63aUYen0T A==; X-CSE-ConnectionGUID: peETRQxgQGeJmBnaAiv4Qw== X-CSE-MsgGUID: BGCkLORMQzqJRAr6qC55Sg== X-IronPort-AV: E=Sophos;i="6.08,197,1712613600"; d="scan'208";a="37120964" Received: from vmailcow01.tq-net.de ([10.150.86.48]) by mx1.tq-group.com with ESMTP; 29 May 2024 10:15:26 +0200 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 428F516564F; Wed, 29 May 2024 10:15:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ew.tq-group.com; s=dkim; t=1716970522; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=qPzqmbhWrWgXeytPFFr8ZnaAVt6ESUekqElZje8ecik=; b=X0yjbkySyuGTbdlhNBO93Jh68pO3BA/mg1Zd40iUSbpOU95OxQ52P5PGEqzn1uViTP7tbV iI62wxWbD0xc/OKGyawp1b6dojDbnY8akxQlxY9e9l8JkWzE3k8w9yJmXsbEuVLi3mJy1Z JWLzPP+GEyTf1xbuixIphwW1jshgmDGJbhsM26wmH70SZ73nvIg5vrj5VBP1ZF6LGgAhaq k1Z+w27V+CgqhxshxYlgoiDkKrmpmW0XUdSUFjJhKyEs0PHT1Ko4d+UnBTvf5+kOrl05eD LiJ5XSthmZoI6noWYj4kLdu/pdMTUiWfawdrHwOFq4NddGxNyi62if1v7I6qCA== From: Alexander Stein To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Liu Ying Cc: dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/1] drm/bridge: imx93-mipi-dsi: Use dev_err_probe Date: Wed, 29 May 2024 10:15:18 +0200 Message-ID: <6130653.lOV4Wx5bFT@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <091f1d5c-0bff-4dcb-b823-b82989eac628@nxp.com> References: <20240529065400.461633-1-alexander.stein@ew.tq-group.com> <091f1d5c-0bff-4dcb-b823-b82989eac628@nxp.com> MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240529_011530_551550_FC8A7444 X-CRM114-Status: GOOD ( 21.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Am Mittwoch, 29. Mai 2024, 09:50:24 CEST schrieb Liu Ying: > On 05/29/2024, Alexander Stein wrote: > > Although very unlike to occur (media_blk_ctrl needs 'syscon' compatible > > removed), it lines up with the other error paths in probe function. > = > Why media_blk_ctrl needs 'syscon' compatible removed? No, it does not. As media_blk_ctrl is also used as power-domain the device will not even be probed if media_blk_ctrl is not available. I just mentioned it under which conditions this error path could happen. Best regards, Alexander > device_node_get_regmap may return error pointer other than > ERR_PTR(-EPROBE_DEFER), like ERR_PTR(-ENOMEM). > = > struct regmap *syscon_node_to_regmap(struct device_node *np) = = > { = = > if (!of_device_is_compatible(np, "syscon")) = = > return ERR_PTR(-EINVAL); = = > = = > return device_node_get_regmap(np, true); = = > } = = > EXPORT_SYMBOL_GPL(syscon_node_to_regmap); > = > Regard, > Liu Ying > = > > = > > Signed-off-by: Alexander Stein > > --- > > Changes in v2: > > * Removed unused variable > > * Added missing \n at end of string > > = > > drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c | 9 +++------ > > 1 file changed, 3 insertions(+), 6 deletions(-) > > = > > diff --git a/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c b/drivers/gpu/= drm/bridge/imx/imx93-mipi-dsi.c > > index 2347f8dd632f9..13025f47f3902 100644 > > --- a/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c > > +++ b/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c > > @@ -834,18 +834,15 @@ static int imx93_dsi_probe(struct platform_device= *pdev) > > struct device *dev =3D &pdev->dev; > > struct device_node *np =3D dev->of_node; > > struct imx93_dsi *dsi; > > - int ret; > > = > > dsi =3D devm_kzalloc(dev, sizeof(*dsi), GFP_KERNEL); > > if (!dsi) > > return -ENOMEM; > > = > > dsi->regmap =3D syscon_regmap_lookup_by_phandle(np, "fsl,media-blk-ct= rl"); > > - if (IS_ERR(dsi->regmap)) { > > - ret =3D PTR_ERR(dsi->regmap); > > - dev_err(dev, "failed to get block ctrl regmap: %d\n", ret); > > - return ret; > > - } > > + if (IS_ERR(dsi->regmap)) > > + return dev_err_probe(dev, PTR_ERR(dsi->regmap), > > + "failed to get block ctrl regmap\n"); > > = > > dsi->clk_pixel =3D devm_clk_get(dev, "pix"); > > if (IS_ERR(dsi->clk_pixel)) > = > = -- = TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel