* [PATCH 2/5] arm: dts: imx7-mba7: change sound card model name
2025-01-20 13:24 [PATCH 1/5] arm: dts: imx6qdl-mba6: change sound card model name Alexander Stein
@ 2025-01-20 13:24 ` Alexander Stein
2025-01-20 13:25 ` [PATCH 3/5] arm: dts: mba6ul: " Alexander Stein
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Alexander Stein @ 2025-01-20 13:24 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: Markus Niebel, linux, devicetree, imx, linux-arm-kernel,
linux-kernel, Alexander Stein
From: Markus Niebel <Markus.Niebel@ew.tq-group.com>
The card name for ALSA is generated from the model name string and
is limited to 16 characters. Use a shorter name to prevent cutting the
name.
Since nearly all starter kit mainboards for i.MX based SoM by TQ-Systems
use the same codec with the same routing on board it is a good idea to
use the same mode name for the sound card. This allows sharing a default
asound.conf in BSP over all the kits.
Signed-off-by: Markus Niebel <Markus.Niebel@ew.tq-group.com>
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
arch/arm/boot/dts/nxp/imx/imx7-mba7.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/nxp/imx/imx7-mba7.dtsi b/arch/arm/boot/dts/nxp/imx/imx7-mba7.dtsi
index 98956d78c9a18..954739f82d86b 100644
--- a/arch/arm/boot/dts/nxp/imx/imx7-mba7.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx7-mba7.dtsi
@@ -238,7 +238,7 @@ reg_audio_3v3: regulator-audio-3v3 {
sound {
compatible = "fsl,imx-audio-tlv320aic32x4";
- model = "imx-audio-tlv320aic32x4";
+ model = "tqm-tlv320aic32";
ssi-controller = <&sai1>;
audio-codec = <&tlv320aic32x4>;
audio-routing =
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 3/5] arm: dts: mba6ul: change sound card model name
2025-01-20 13:24 [PATCH 1/5] arm: dts: imx6qdl-mba6: change sound card model name Alexander Stein
2025-01-20 13:24 ` [PATCH 2/5] arm: dts: imx7-mba7: " Alexander Stein
@ 2025-01-20 13:25 ` Alexander Stein
2025-02-22 9:06 ` Shawn Guo
2025-01-20 13:25 ` [PATCH 4/5] arm64: dts: imx8mp-tqma8mpql-mba8mpxl: " Alexander Stein
2025-01-20 13:25 ` [PATCH 5/5] arm64: dts: mba8mx: " Alexander Stein
3 siblings, 1 reply; 8+ messages in thread
From: Alexander Stein @ 2025-01-20 13:25 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: Markus Niebel, linux, devicetree, imx, linux-arm-kernel,
linux-kernel, Alexander Stein
From: Markus Niebel <Markus.Niebel@ew.tq-group.com>
The card name for ALSA is generated from the model name string and
is limited to 16 characters. Use a shorter name to prevent cutting the
name.
Since nearly all starter kit mainboards for i.MX based SoM by TQ-Systems
use the same codec with the same routing on board it is a good idea to
use the same mode name for the sound card. This allows sharing a default
asound.conf in BSP over all the kits.
Signed-off-by: Markus Niebel <Markus.Niebel@ew.tq-group.com>
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi b/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi
index 941d9860218e9..67a3d484bc9f1 100644
--- a/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi
@@ -142,7 +142,7 @@ linux,cma {
sound {
compatible = "fsl,imx-audio-tlv320aic32x4";
- model = "imx-audio-tlv320aic32x4";
+ model = "tqm-tlv320aic32";
ssi-controller = <&sai1>;
audio-codec = <&tlv320aic32x4>;
audio-asrc = <&asrc>;
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 3/5] arm: dts: mba6ul: change sound card model name
2025-01-20 13:25 ` [PATCH 3/5] arm: dts: mba6ul: " Alexander Stein
@ 2025-02-22 9:06 ` Shawn Guo
0 siblings, 0 replies; 8+ messages in thread
From: Shawn Guo @ 2025-02-22 9:06 UTC (permalink / raw)
To: Alexander Stein
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Markus Niebel, linux, devicetree, imx, linux-arm-kernel,
linux-kernel
On Mon, Jan 20, 2025 at 02:25:00PM +0100, Alexander Stein wrote:
> From: Markus Niebel <Markus.Niebel@ew.tq-group.com>
>
> The card name for ALSA is generated from the model name string and
> is limited to 16 characters. Use a shorter name to prevent cutting the
> name.
>
> Since nearly all starter kit mainboards for i.MX based SoM by TQ-Systems
> use the same codec with the same routing on board it is a good idea to
> use the same mode name for the sound card. This allows sharing a default
> asound.conf in BSP over all the kits.
>
> Signed-off-by: Markus Niebel <Markus.Niebel@ew.tq-group.com>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Applied 1 ~ 3 with changing subjects "ARM: dts: ...".
Shawn
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 4/5] arm64: dts: imx8mp-tqma8mpql-mba8mpxl: change sound card model name
2025-01-20 13:24 [PATCH 1/5] arm: dts: imx6qdl-mba6: change sound card model name Alexander Stein
2025-01-20 13:24 ` [PATCH 2/5] arm: dts: imx7-mba7: " Alexander Stein
2025-01-20 13:25 ` [PATCH 3/5] arm: dts: mba6ul: " Alexander Stein
@ 2025-01-20 13:25 ` Alexander Stein
2025-01-20 13:25 ` [PATCH 5/5] arm64: dts: mba8mx: " Alexander Stein
3 siblings, 0 replies; 8+ messages in thread
From: Alexander Stein @ 2025-01-20 13:25 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: Markus Niebel, linux, devicetree, imx, linux-arm-kernel,
linux-kernel, Alexander Stein
From: Markus Niebel <Markus.Niebel@ew.tq-group.com>
The card name for ALSA is generated from the model name string and
is limited to 16 characters. Use a shorter name to prevent cutting the
name.
Since nearly all starter kit mainboards for i.MX based SoM by TQ-Systems
use the same codec with the same routing on board it is a good idea to
use the same mode name for the sound card. This allows sharing a default
asound.conf in BSP over all the kits.
Signed-off-by: Markus Niebel <Markus.Niebel@ew.tq-group.com>
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts
index 730fdd85d731f..f20e022937567 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts
@@ -241,7 +241,7 @@ linux,cma {
sound {
compatible = "fsl,imx-audio-tlv320aic32x4";
- model = "tq-tlv320aic32x";
+ model = "tqm-tlv320aic32";
audio-asrc = <&easrc>;
audio-cpu = <&sai3>;
audio-codec = <&tlv320aic3x04>;
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 5/5] arm64: dts: mba8mx: change sound card model name
2025-01-20 13:24 [PATCH 1/5] arm: dts: imx6qdl-mba6: change sound card model name Alexander Stein
` (2 preceding siblings ...)
2025-01-20 13:25 ` [PATCH 4/5] arm64: dts: imx8mp-tqma8mpql-mba8mpxl: " Alexander Stein
@ 2025-01-20 13:25 ` Alexander Stein
2025-02-22 9:09 ` Shawn Guo
3 siblings, 1 reply; 8+ messages in thread
From: Alexander Stein @ 2025-01-20 13:25 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: Markus Niebel, linux, devicetree, imx, linux-arm-kernel,
linux-kernel, Alexander Stein
From: Markus Niebel <Markus.Niebel@ew.tq-group.com>
The card name for ALSA is generated from the model name string and
is limited to 16 characters. Use a shorter name to prevent cutting the
name.
Since nearly all starter kit mainboards for i.MX based SoM by TQ-Systems
use the same codec with the same routing on board it is a good idea to
use the same mode name for the sound card. This allows sharing a default
asound.conf in BSP over all the kits.
Signed-off-by: Markus Niebel <Markus.Niebel@ew.tq-group.com>
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
arch/arm64/boot/dts/freescale/mba8mx.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/mba8mx.dtsi b/arch/arm64/boot/dts/freescale/mba8mx.dtsi
index 124a2544826c9..0931f680e6875 100644
--- a/arch/arm64/boot/dts/freescale/mba8mx.dtsi
+++ b/arch/arm64/boot/dts/freescale/mba8mx.dtsi
@@ -158,7 +158,7 @@ reg_vcc_5v0: regulator-5v0 {
sound: sound {
compatible = "fsl,imx-audio-tlv320aic32x4";
- model = "imx-audio-tlv320aic32x4";
+ model = "tqm-tlv320aic32";
ssi-controller = <&sai3>;
audio-codec = <&tlv320aic3x04>;
};
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 5/5] arm64: dts: mba8mx: change sound card model name
2025-01-20 13:25 ` [PATCH 5/5] arm64: dts: mba8mx: " Alexander Stein
@ 2025-02-22 9:09 ` Shawn Guo
2025-02-24 15:01 ` Alexander Stein
0 siblings, 1 reply; 8+ messages in thread
From: Shawn Guo @ 2025-02-22 9:09 UTC (permalink / raw)
To: Alexander Stein
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Markus Niebel, linux, devicetree, imx, linux-arm-kernel,
linux-kernel
On Mon, Jan 20, 2025 at 02:25:02PM +0100, Alexander Stein wrote:
> From: Markus Niebel <Markus.Niebel@ew.tq-group.com>
>
> The card name for ALSA is generated from the model name string and
> is limited to 16 characters. Use a shorter name to prevent cutting the
> name.
>
> Since nearly all starter kit mainboards for i.MX based SoM by TQ-Systems
> use the same codec with the same routing on board it is a good idea to
> use the same mode name for the sound card. This allows sharing a default
> asound.conf in BSP over all the kits.
>
> Signed-off-by: Markus Niebel <Markus.Niebel@ew.tq-group.com>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
I may have missed some prerequisite ones, but #4 and #5 do not apply for
me.
Shawn
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 5/5] arm64: dts: mba8mx: change sound card model name
2025-02-22 9:09 ` Shawn Guo
@ 2025-02-24 15:01 ` Alexander Stein
0 siblings, 0 replies; 8+ messages in thread
From: Alexander Stein @ 2025-02-24 15:01 UTC (permalink / raw)
To: Shawn Guo
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Markus Niebel, linux, devicetree, imx, linux-arm-kernel,
linux-kernel
Hi Shawn,
Am Samstag, 22. Februar 2025, 10:09:39 CET schrieb Shawn Guo:
> On Mon, Jan 20, 2025 at 02:25:02PM +0100, Alexander Stein wrote:
> > From: Markus Niebel <Markus.Niebel@ew.tq-group.com>
> >
> > The card name for ALSA is generated from the model name string and
> > is limited to 16 characters. Use a shorter name to prevent cutting the
> > name.
> >
> > Since nearly all starter kit mainboards for i.MX based SoM by TQ-Systems
> > use the same codec with the same routing on board it is a good idea to
> > use the same mode name for the sound card. This allows sharing a default
> > asound.conf in BSP over all the kits.
> >
> > Signed-off-by: Markus Niebel <Markus.Niebel@ew.tq-group.com>
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
>
> I may have missed some prerequisite ones, but #4 and #5 do not apply for
> me.
Thanks for pointing out. A local commit was silently introduced as dependency.
I removed it and pushed a v2 while also fixing a typo in the commit message
'mode' -> 'model'
Thanks
Alexander
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
^ permalink raw reply [flat|nested] 8+ messages in thread