From: Krzysztof Kozlowski <krzk@kernel.org>
To: Gregor Herburger <gregor.herburger@linutronix.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Eric Anholt <eric@anholt.net>, Stefan Wahren <wahrenst@gmx.net>,
Srinivas Kandagatla <srini@kernel.org>,
Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2 4/4] arm64: dts: broadcom: bcm2712: add bcm2712-firmware compatible
Date: Tue, 5 May 2026 11:21:21 +0200 [thread overview]
Message-ID: <6155d6aa-5e66-4043-a7b2-da447548056d@kernel.org> (raw)
In-Reply-To: <20260505-rpi-otp-driver-v2-4-e9176ec72837@linutronix.de>
On 05/05/2026 09:25, Gregor Herburger wrote:
> The Raspberry Pi 5 firmware exposes additional features. Update the
> compatible to reflect these differences.
>
> Signed-off-by: Gregor Herburger <gregor.herburger@linutronix.de>
> ---
> arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-base.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-base.dtsi b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-base.dtsi
> index b7a6bc34ae1a..7283078fd441 100644
> --- a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-base.dtsi
> +++ b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-base.dtsi
> @@ -46,7 +46,7 @@ power_button: power-button {
>
> firmware {
> firmware: rpi-firmware {
> - compatible = "raspberrypi,bcm2835-firmware", "simple-mfd";
> + compatible = "raspberrypi,bcm2712-firmware", "simple-mfd";
This breaks users without mentioning and without proper reason.
"Additional features" is not a reason to break users. At least not
without explaining the actual impact, but even with the impact IMO this
is just wrong.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-05-05 9:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 7:25 [PATCH v2 0/4] nvmem: Add Raspberry Pi OTP nvmem driver Gregor Herburger
2026-05-05 7:25 ` [PATCH v2 1/4] dt-bindings: raspberrypi,bcm2835-firmware: Add bcm2712-firmware compatible Gregor Herburger
2026-05-05 9:00 ` Rob Herring (Arm)
2026-05-05 7:25 ` [PATCH v2 2/4] nvmem: Add the Raspberry Pi OTP driver Gregor Herburger
2026-05-05 7:25 ` [PATCH v2 3/4] firmware: raspberrypi: register nvmem driver Gregor Herburger
2026-05-05 7:25 ` [PATCH v2 4/4] arm64: dts: broadcom: bcm2712: add bcm2712-firmware compatible Gregor Herburger
2026-05-05 9:21 ` Krzysztof Kozlowski [this message]
2026-05-05 9:22 ` Krzysztof Kozlowski
2026-05-05 15:07 ` Gregor Herburger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6155d6aa-5e66-4043-a7b2-da447548056d@kernel.org \
--to=krzk@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=florian.fainelli@broadcom.com \
--cc=gregor.herburger@linutronix.de \
--cc=gustavoars@kernel.org \
--cc=kees@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=sbranden@broadcom.com \
--cc=srini@kernel.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox