From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 200CFC43603 for ; Tue, 10 Dec 2019 01:18:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E823D2077B for ; Tue, 10 Dec 2019 01:18:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VS4mDaK3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E823D2077B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PNazzbZKH8J35JLDrO6tw8xzOlxbFIEHVKRNyMFmrPM=; b=VS4mDaK3k/k29c EdKOmYklhlAhnAkmE17KEMgay6l2+pl0YWe4tSOxltEdYNc1AZCCINr1a4/aVJ3MRoUYYh96hBZAD xf+E70AzgNTRSJ2KM0/Z6/U8jVHXTXDkE6CM8LhcuOQAxiRQBUBZDN6ODPZQpgp6dt/BfgsD2pVX6 JZz1L7d85SzeLt7wF7+BEnblnTw7JokjMDx3NBLmwnTr2l7Zujig+R6VCrGqkStR+0WtIcl3oXDJc +plOGP2qboIoyY0SNVBdaQjUOA3pLh0L5UC/zr1W6Z7zeE6RXfEkLOvFug1MEMeai+JMHM4xqHXAQ 5sqILkxbblzYDgaarvDQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ieUAe-0007D8-By; Tue, 10 Dec 2019 01:18:36 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ieUAb-0007CL-7B; Tue, 10 Dec 2019 01:18:35 +0000 Received: from ip5f5a6266.dynamic.kabel-deutschland.de ([95.90.98.102] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ieUAT-00042d-A7; Tue, 10 Dec 2019 02:18:25 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Soeren Moch Subject: Re: [PATCH 8/8] arm64: dts: rockchip: RockPro64: enable wifi module at sdio0 Date: Tue, 10 Dec 2019 02:18:24 +0100 Message-ID: <6162240.GiEx4hqPFh@diego> In-Reply-To: <2cf70216-8d98-4122-4f4e-b8254089a017@web.de> References: <20191209223822.27236-1-smoch@web.de> <2668270.pdtvSLGib8@diego> <2cf70216-8d98-4122-4f4e-b8254089a017@web.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191209_171833_408835_37C99191 X-CRM114-Status: GOOD ( 25.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: brcm80211-dev-list.pdl@broadcom.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Kalle Valo , brcm80211-dev-list@cypress.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Soeren, Am Dienstag, 10. Dezember 2019, 00:29:21 CET schrieb Soeren Moch: > On 10.12.19 00:08, Heiko St=FCbner wrote: > > Am Montag, 9. Dezember 2019, 23:38:22 CET schrieb Soeren Moch: > >> RockPro64 supports an Ampak AP6359SA based wifi/bt combo module. > >> The BCM4359/9 wifi controller in this module is connected to sdio0, > >> enable this interface. > >> > >> Signed-off-by: Soeren Moch > >> --- > >> Not sure where to place exactly the sdio0 node in the dts because > >> existing sd nodes are not sorted alphabetically. > >> > >> This last patch in this brcmfmac patch series probably should be picked > >> up by Heiko independently of the rest of this series. It was sent toge= ther > >> to show how this brcmfmac extension for 4359-sdio support with RSDB is > >> used and tested. > > node placement looks good so I can apply it, just a general questions > > I only got patch 8/8 are patches 1-7 relevant for this one and what are= they? > Patches 1-7 are the patches to support the BCM4359 chipset with SDIO > interface in the linux brcmfmac net-wireless driver, see [1]. > = > So this patch series has 2 parts: > patches 1-7: add support for the wifi chipset in the wireless driver, > this has to go through net-wireless > patch 8: enable the wifi module with this chipset on RockPro64, this patch Thanks for the clarification :-) . As patch 8 "only" does the core sdio node, it doesn't really depend on the earlier ones and you can submit any uart-hooks for bluetooth once the other patches land I guess. > If this was confusing, what would be the ideal way to post such series? I think every maintainer has some slightly different perspective on this, but personally I like getting the whole series to follow the discussion but also to just see when the driver-side changes get merged, as the dts-parts need to wait for that in a lot of cases. Heiko > [1] https://patchwork.kernel.org/project/linux-wireless/list/?series=3D21= 3951 > > > > Thanks > > Heiko > > > > > >> Cc: Heiko Stuebner > >> Cc: Kalle Valo > >> Cc: linux-wireless@vger.kernel.org > >> Cc: brcm80211-dev-list.pdl@broadcom.com > >> Cc: brcm80211-dev-list@cypress.com > >> Cc: netdev@vger.kernel.org > >> Cc: linux-arm-kernel@lists.infradead.org > >> Cc: linux-rockchip@lists.infradead.org > >> Cc: linux-kernel@vger.kernel.org > >> --- > >> .../boot/dts/rockchip/rk3399-rockpro64.dts | 21 ++++++++++++------- > >> 1 file changed, 14 insertions(+), 7 deletions(-) > >> > >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts b/arch/= arm64/boot/dts/rockchip/rk3399-rockpro64.dts > >> index 7f4b2eba31d4..9fa92790d6e0 100644 > >> --- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts > >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts > >> @@ -71,13 +71,6 @@ > >> clock-names =3D "ext_clock"; > >> pinctrl-names =3D "default"; > >> pinctrl-0 =3D <&wifi_enable_h>; > >> - > >> - /* > >> - * On the module itself this is one of these (depending > >> - * on the actual card populated): > >> - * - SDIO_RESET_L_WL_REG_ON > >> - * - PDN (power down when low) > >> - */ > >> reset-gpios =3D <&gpio0 RK_PB2 GPIO_ACTIVE_LOW>; > >> }; > >> > >> @@ -650,6 +643,20 @@ > >> status =3D "okay"; > >> }; > >> > >> +&sdio0 { > >> + bus-width =3D <4>; > >> + cap-sd-highspeed; > >> + cap-sdio-irq; > >> + disable-wp; > >> + keep-power-in-suspend; > >> + mmc-pwrseq =3D <&sdio_pwrseq>; > >> + non-removable; > >> + pinctrl-names =3D "default"; > >> + pinctrl-0 =3D <&sdio0_bus4 &sdio0_cmd &sdio0_clk>; > >> + sd-uhs-sdr104; > >> + status =3D "okay"; > >> +}; > >> + > >> &sdmmc { > >> bus-width =3D <4>; > >> cap-sd-highspeed; > >> -- > >> 2.17.1 > >> > > > > > > > = > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel