From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28C79C3DA61 for ; Tue, 30 Jul 2024 07:52:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4EFhy66mb2EN5Xg6Nodx0UoD7jYf664PaudI15ViaSI=; b=y/85nseD0Qn9OhoW0d6+TAQbf1 HoyKaFn9l6qxCW6lLQxv78M/FN7JR9sXhmpt7ZiTzYzPIUJpZMCOMyamzFdDJoomP1ZeUiUMDRh1U +Rwa1uYDNj5FoVuDpsOZVYg6m4gmkAz7fr1AY7YywUVGdV5Mk9W+enfh7YHsEfTbGrjhUHzrgEg7K Us8WoMqmYziuWp8G737K8s/wKdpGRaKEckfUymTNLe8+hdZsbiylLj5XPRLNMEHg7u5usfeJ248lq kiF1JP2HJabNJagfKI5d7EiFeKP3cZPY3wZTQC3bfseoYg0TfsyLHgOKe7CX2abe9Tsp2zez9jbEY nj4ipy9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYhec-0000000E6s8-1UZ7; Tue, 30 Jul 2024 07:52:18 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYhds-0000000E6OU-2ykG for linux-arm-kernel@lists.infradead.org; Tue, 30 Jul 2024 07:51:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1722325892; x=1753861892; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=4EFhy66mb2EN5Xg6Nodx0UoD7jYf664PaudI15ViaSI=; b=Zfjr/kpqCDku63Z90NMZRhDzqQJ8mhPQ3PJ7CQSQpdiFy+St3wwmPgDl /E5Q6fSqB9vDG6ve4NI4uj99BejhbfYAWefhBIXMQGoOPjFzmngn2U8kn arkGOhvYVPTXx3UaCLKC/5+nQS2ISyPB3E3Fvh9zOBIREZS9/fxnkvLVB 5OV7A0Hh57Klni/hvb3N3wq8Rqgk8Thw/niW7xrjp9rrZR/hKYfp5Glkp j/vwSvV1XqooiMiPJeZVnA0CAaL3ZV5FTxO1GpiwVyf9A77Y51T7EFw+o m8YtfJbFGf577RcOLuy3q4VUSz5TXImLcnqbtfa1L9ZYFBrV3Q2bbc5mI Q==; X-CSE-ConnectionGUID: fGX8/Tf4RF6A9OI8eUv2xQ== X-CSE-MsgGUID: DbIpd4ZkRgiQdzWtPw3XNw== X-IronPort-AV: E=Sophos;i="6.09,248,1716242400"; d="scan'208";a="38140493" Received: from vmailcow01.tq-net.de ([10.150.86.48]) by mx1.tq-group.com with ESMTP; 30 Jul 2024 09:51:30 +0200 X-CheckPoint: {66A89B82-11-2D4D5AC2-F2EAEA09} X-MAIL-CPID: 8507E70011AE48B9C1D51CE44F20DD35_3 X-Control-Analysis: str=0001.0A782F1E.66A89B82.0148,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 51443167BE9; Tue, 30 Jul 2024 09:51:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ew.tq-group.com; s=dkim; t=1722325886; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=4EFhy66mb2EN5Xg6Nodx0UoD7jYf664PaudI15ViaSI=; b=o/W7PHNZz/wnnj+4OjAeR7xhptF0tks0684Pr4Qvvl1a3fPcJ4GnKPj8rvDboL1MnZcXqO XieU6y/F6DsGmxHRNwqBW7400W/mQkpbW81I+3kh3Ks7qNDiTPgL/Ea1znoJ551vBk4UFb JMjFfD6axGZTohCgJQHRk3cOS+BhZkzz8v73ZDL3h/vVaPWVJm0+2thWI6EfrSUGkVCaHe ynFdugcIq/0Ct0HP5E56enI8+DPBqqGAheJHLRvM6Ap8mw8T3bG2vlGLEK1k020pTFiHTB fnzXneARZMf8Jvg1+bj5d7FULrAaTHlWWdC+d2XpZp2CJgRXP9cd5LMfRaRkVQ== From: Alexander Stein To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Krzysztof Kozlowski Cc: Clark Wang , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] arm64: dts: imx8-ss-dma: enable dma support for lpspi Date: Tue, 30 Jul 2024 09:51:25 +0200 Message-ID: <6166407.lOV4Wx5bFT@steina-w> Organization: TQ-Systems GmbH In-Reply-To: References: <20240729094511.159467-1-alexander.stein@ew.tq-group.com> <2840074.mvXUDI8C0e@steina-w> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240730_005133_329188_55E9DA56 X-CRM114-Status: GOOD ( 16.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Dienstag, 30. Juli 2024, 09:37:53 CEST schrieb Krzysztof Kozlowski: > On 30/07/2024 09:30, Alexander Stein wrote: > > Hi Krzysztof, > >=20 > > Am Montag, 29. Juli 2024, 17:10:48 CEST schrieb Krzysztof Kozlowski: > >> On 29/07/2024 11:45, Alexander Stein wrote: > >>> From: Clark Wang > >>> > >>> Add DMA configurations for LPSPI nodes on i.MX8QX/QM/DXL. > >>> > >>> Signed-off-by: Clark Wang > >>> Signed-off-by: Alexander Stein > >>> --- > >>> Using the DMA configuration bits from downstream kernel. > >>> Tested on TQMa8XxS. > >>> > >>> arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 8 ++++++++ > >>> 1 file changed, 8 insertions(+) > >>> > >>> diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi b/arch/ar= m64/boot/dts/freescale/imx8-ss-dma.dtsi > >>> index 1ee9496c988c5..8ae5f065b4180 100644 > >>> --- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi > >>> +++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi > >>> @@ -34,6 +34,8 @@ lpspi0: spi@5a000000 { > >>> assigned-clocks =3D <&clk IMX_SC_R_SPI_0 IMX_SC_PM_CLK_PER>; > >>> assigned-clock-rates =3D <60000000>; > >>> power-domains =3D <&pd IMX_SC_R_SPI_0>; > >>> + dma-names =3D "tx","rx"; > >> > >> Missing spaces. Unexpected order, unless that's the coding style for i= mx. > >=20 > > Ack for the space, will correct. But the order is defined that way in > > Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml >=20 > Bindings do not define the order of properties. The coding style does > and usually we expect property-x followed by property-x-names. Ah, you were talking about order of properties, not order of property values, my bad. Unfortunately imx (and also layerscape) is inconsistent, having both ways :( I'll go for you suggestion, this seems also to be the order used mostly. Best regards, Alexander =2D-=20 TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/