linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Pascal Roeleven <dev@pascalroeleven.nl>
To: "Thierry Reding" <thierry.reding@gmail.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Chen-Yu Tsai" <wens@csie.org>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: linux-sunxi@googlegroups.com
Subject: pwm: sun4i: pwm-backlight not working since 5.6-rc1
Date: Thu, 12 Mar 2020 13:22:13 +0100	[thread overview]
Message-ID: <6185b5540ca082d887d7d13330c9d938@pascalroeleven.nl> (raw)

Hi all,

I am working on adding an old A10 device to mainline and noticed an 
issue when testing on 5.5.8 vs master.

Since 5.6-rc1, I can't control the brightness of my LCD backlight 
anymore. The backlight stays on full brightness instead. I am 
controlling the brightness value via sysfs for testing.

I am not sure if this is a general pwm-sun4i issue or if it is related 
to the backlight. However I narrowed it down to one commit for 
pwm-sun4i:

fa4d81784681a26bcf7d2a43c6ac5cf991ef28f5

If I use pwm-sun4i.c from 5b090b430d750961305030232314b6acdb0102aa on 
master, the backlight works fine. Unfortunately, due to my lack of 
kernel experience, I can't see how the commit above broke it.

Not sure if it helps, but the binding for the backlight is as follows:

backlight: backlight {
     compatible = "pwm-backlight";
     pwms = <&pwm 0 100000 PWM_POLARITY_INVERTED>;
     power-supply = <&reg_vbat>;
     enable-gpios = <&pio 7 7 GPIO_ACTIVE_HIGH>; /* PH7 */
     brightness-levels = <0 30 40 50 60 70 80 90 100>;
     default-brightness-level = <8>;
};

Please let me know if there is anything else which might be helpful to 
know or anything I can test.

Regards,
Pascal

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2020-03-12 12:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-12 12:22 Pascal Roeleven [this message]
2020-03-12 13:29 ` pwm: sun4i: pwm-backlight not working since 5.6-rc1 Uwe Kleine-König
2020-03-12 15:06   ` Pascal Roeleven
2020-03-16  7:26     ` Uwe Kleine-König
2020-03-17 17:32       ` Uwe Kleine-König
2020-03-17 17:52         ` Pascal Roeleven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6185b5540ca082d887d7d13330c9d938@pascalroeleven.nl \
    --to=dev@pascalroeleven.nl \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=mripard@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=thierry.reding@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).