* [PATCH] arm(64): dts: meson: adjust order of some compatibles
@ 2023-02-01 17:30 Heiner Kallweit
2023-02-01 17:32 ` Neil Armstrong
0 siblings, 1 reply; 3+ messages in thread
From: Heiner Kallweit @ 2023-02-01 17:30 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Neil Armstrong, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl
Cc: linux-arm-kernel@lists.infradead.org,
open list:ARM/Amlogic Meson..., devicetree@vger.kernel.org
During review of a new yaml binding, affecting these dts, it turned out
that some compatibles aren't ordered as they should be. Order should be
most specific to least specific.
Suggested-by: Rob Herring <robh+dt@kernel.org>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
arch/arm/boot/dts/meson8b.dtsi | 4 ++--
arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 4 ++--
arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
index d5a3fe21e..5979209fe 100644
--- a/arch/arm/boot/dts/meson8b.dtsi
+++ b/arch/arm/boot/dts/meson8b.dtsi
@@ -580,8 +580,8 @@ ðmac {
};
&gpio_intc {
- compatible = "amlogic,meson-gpio-intc",
- "amlogic,meson8b-gpio-intc";
+ compatible = "amlogic,meson8b-gpio-intc",
+ "amlogic,meson-gpio-intc";
status = "okay";
};
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
index 923d2d8bb..12ef6e81c 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
@@ -300,8 +300,8 @@ ðmac {
};
&gpio_intc {
- compatible = "amlogic,meson-gpio-intc",
- "amlogic,meson-gxbb-gpio-intc";
+ compatible = "amlogic,meson-gxbb-gpio-intc",
+ "amlogic,meson-gpio-intc";
status = "okay";
};
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
index 04e9d0f1b..af912f698 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
@@ -312,8 +312,8 @@ &clkc_AO {
};
&gpio_intc {
- compatible = "amlogic,meson-gpio-intc",
- "amlogic,meson-gxl-gpio-intc";
+ compatible = "amlogic,meson-gxl-gpio-intc",
+ "amlogic,meson-gpio-intc";
status = "okay";
};
--
2.39.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm(64): dts: meson: adjust order of some compatibles
2023-02-01 17:30 [PATCH] arm(64): dts: meson: adjust order of some compatibles Heiner Kallweit
@ 2023-02-01 17:32 ` Neil Armstrong
2023-02-01 17:57 ` Heiner Kallweit
0 siblings, 1 reply; 3+ messages in thread
From: Neil Armstrong @ 2023-02-01 17:32 UTC (permalink / raw)
To: Heiner Kallweit, Rob Herring, Krzysztof Kozlowski, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl
Cc: linux-arm-kernel@lists.infradead.org,
open list:ARM/Amlogic Meson..., devicetree@vger.kernel.org
Hi Heiner,
On 01/02/2023 18:30, Heiner Kallweit wrote:
> During review of a new yaml binding, affecting these dts, it turned out
> that some compatibles aren't ordered as they should be. Order should be
> most specific to least specific.
>
> Suggested-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> arch/arm/boot/dts/meson8b.dtsi | 4 ++--
> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 4 ++--
> arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 4 ++--
> 3 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
> index d5a3fe21e..5979209fe 100644
> --- a/arch/arm/boot/dts/meson8b.dtsi
> +++ b/arch/arm/boot/dts/meson8b.dtsi
> @@ -580,8 +580,8 @@ ðmac {
> };
>
> &gpio_intc {
> - compatible = "amlogic,meson-gpio-intc",
> - "amlogic,meson8b-gpio-intc";
> + compatible = "amlogic,meson8b-gpio-intc",
> + "amlogic,meson-gpio-intc";
> status = "okay";
> };
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> index 923d2d8bb..12ef6e81c 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> @@ -300,8 +300,8 @@ ðmac {
> };
>
> &gpio_intc {
> - compatible = "amlogic,meson-gpio-intc",
> - "amlogic,meson-gxbb-gpio-intc";
> + compatible = "amlogic,meson-gxbb-gpio-intc",
> + "amlogic,meson-gpio-intc";
> status = "okay";
> };
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> index 04e9d0f1b..af912f698 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> @@ -312,8 +312,8 @@ &clkc_AO {
> };
>
> &gpio_intc {
> - compatible = "amlogic,meson-gpio-intc",
> - "amlogic,meson-gxl-gpio-intc";
> + compatible = "amlogic,meson-gxl-gpio-intc",
> + "amlogic,meson-gpio-intc";
> status = "okay";
> };
>
Please send a new clean patchset with the associated bindings changes then this patch,
and split ARM and arm64 in 2 patches.
Neil
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm(64): dts: meson: adjust order of some compatibles
2023-02-01 17:32 ` Neil Armstrong
@ 2023-02-01 17:57 ` Heiner Kallweit
0 siblings, 0 replies; 3+ messages in thread
From: Heiner Kallweit @ 2023-02-01 17:57 UTC (permalink / raw)
To: neil.armstrong, Rob Herring, Krzysztof Kozlowski, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl
Cc: linux-arm-kernel@lists.infradead.org,
open list:ARM/Amlogic Meson..., devicetree@vger.kernel.org
On 01.02.2023 18:32, Neil Armstrong wrote:
> Hi Heiner,
>
> On 01/02/2023 18:30, Heiner Kallweit wrote:
>> During review of a new yaml binding, affecting these dts, it turned out
>> that some compatibles aren't ordered as they should be. Order should be
>> most specific to least specific.
>>
>> Suggested-by: Rob Herring <robh+dt@kernel.org>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>> ---
>> arch/arm/boot/dts/meson8b.dtsi | 4 ++--
>> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 4 ++--
>> arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 4 ++--
>> 3 files changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
>> index d5a3fe21e..5979209fe 100644
>> --- a/arch/arm/boot/dts/meson8b.dtsi
>> +++ b/arch/arm/boot/dts/meson8b.dtsi
>> @@ -580,8 +580,8 @@ ðmac {
>> };
>> &gpio_intc {
>> - compatible = "amlogic,meson-gpio-intc",
>> - "amlogic,meson8b-gpio-intc";
>> + compatible = "amlogic,meson8b-gpio-intc",
>> + "amlogic,meson-gpio-intc";
>> status = "okay";
>> };
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>> index 923d2d8bb..12ef6e81c 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>> @@ -300,8 +300,8 @@ ðmac {
>> };
>> &gpio_intc {
>> - compatible = "amlogic,meson-gpio-intc",
>> - "amlogic,meson-gxbb-gpio-intc";
>> + compatible = "amlogic,meson-gxbb-gpio-intc",
>> + "amlogic,meson-gpio-intc";
>> status = "okay";
>> };
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
>> index 04e9d0f1b..af912f698 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
>> @@ -312,8 +312,8 @@ &clkc_AO {
>> };
>> &gpio_intc {
>> - compatible = "amlogic,meson-gpio-intc",
>> - "amlogic,meson-gxl-gpio-intc";
>> + compatible = "amlogic,meson-gxl-gpio-intc",
>> + "amlogic,meson-gpio-intc";
>> status = "okay";
>> };
>>
>
> Please send a new clean patchset with the associated bindings changes then this patch,
> and split ARM and arm64 in 2 patches.
>
Shouldn't this patch be first? Else make dtbs_check will complain.
> Neil
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-01 17:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-01 17:30 [PATCH] arm(64): dts: meson: adjust order of some compatibles Heiner Kallweit
2023-02-01 17:32 ` Neil Armstrong
2023-02-01 17:57 ` Heiner Kallweit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox