From: svenkatr@ti.com (Venkatraman S)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/03] omap hsmmc: prevent race between dma and hsmmc callback
Date: Mon, 1 Mar 2010 16:55:35 +0530 [thread overview]
Message-ID: <618f0c911003010325q201fbcedr776da21c709ac421@mail.gmail.com> (raw)
It is observed that sometimes the MMC Transfer Complete (TC) is not
received when DMA completion callback is processed (or takes too long
to process)
This patch moves the releasing of DMA channel from dma callback to the
mmc transfer complete handler.
This is observed consistently when descriptor loading is used (see the
rest of the series)
Signed-off-by: Venkatraman S <svenkatr@ti.com>
---
drivers/mmc/host/omap_hsmmc.c | 19 +++++++++++--------
1 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 83f0aff..06337f6 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -1046,8 +1046,18 @@ static irqreturn_t omap_hsmmc_irq(int irq, void *dev_id)
if (end_cmd || ((status & CC) && host->cmd))
omap_hsmmc_cmd_done(host, host->cmd);
- if ((end_trans || (status & TC)) && host->mrq)
+ if ((end_trans || (status & TC)) && host->mrq) {
omap_hsmmc_xfer_done(host, data);
+ if (host->dma_ch != -1) {
+ omap_free_dma(host->dma_ch);
+ host->dma_ch = -1;
+ /*
+ * Callback: run in interrupt context.
+ * mutex_unlock will throw a kernel warning if used.
+ */
+ up(&host->sem);
+ }
+ }
spin_unlock(&host->irq_lock);
@@ -1267,13 +1277,6 @@ static void omap_hsmmc_dma_cb(int lch, u16
ch_status, void *data)
return;
}
- omap_free_dma(host->dma_ch);
- host->dma_ch = -1;
- /*
- * DMA Callback: run in interrupt context.
- * mutex_unlock will throw a kernel warning if used.
- */
- up(&host->sem);
}
/*
--
1.6.3.3
next reply other threads:[~2010-03-01 11:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-01 11:25 Venkatraman S [this message]
2010-03-01 12:44 ` [PATCH 01/03] omap hsmmc: prevent race between dma and hsmmc callback Sergei Shtylyov
2010-03-10 16:47 ` Madhusudhan
-- strict thread matches above, loose matches on Subject: below --
2010-03-10 14:11 Venkatraman S
2010-03-10 14:27 ` Shilimkar, Santosh
2010-03-10 15:20 ` Venkatraman S
2010-03-10 17:07 ` Kevin Hilman
2010-08-27 19:37 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=618f0c911003010325q201fbcedr776da21c709ac421@mail.gmail.com \
--to=svenkatr@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).