Re: [PATCH RFC 2/5] dt-bindings: power: Add Marvell PXA1908 domains

Krzysztof Kozlowski
2025-08-11T06:41:10Z

On 08/08/2025 21:46, Duje Mihanović wrote:
> On Friday, 8 August 2025 09:34:54 Central European Summer Time Krzysztof Kozlowski wrote:
>> On Wed, Aug 06, 2025 at 07:33:21PM +0200, Duje Mihanović wrote:
>>> + A number of phandles to clocks that need to be enabled during
>>> domain + power up.
>>
>> This does not exist in your example, so it is just confusing.
>
> This is because I have not implemented any of the clocks used by the
> domains at this moment.
>
> Actually, I am not sure anymore whether it is necessary to assign
> clocks to the domains as I have just yesterday successfully brought up
> the GPU with some out-of-tree code and that did not require giving the
> domains any clocks even though the vendor kernel does this. Should I
> just go with that and drop all clock handling from the power domain
> driver, at which point there would be no need for the individual domain
> nodes? If not, how should I in the future assign clocks to the domains?

I am asking to see complete binding with complete DTS in example and
submitted to SoC maintainer.

I did not comment on drivers. This is not a driver patch.

>
>>> +examples:
>>> + - |
>>> + #include <dt-bindings/power/marvell,pxa1908-power.h>
>>> +
>>> + clock-controller@d4282800 {
>>> + compatible = "marvell,pxa1908-apmu", "simple-mfd", "syscon";
>>> + reg = <0xd4282800 0x400>;
>>> + #clock-cells = <1>;
>>> +
>>> + power-controller {
>>> + compatible = "marvell,pxa1908-power-controller";
>>
>> No address space, so this should be folded into the parent.
>
> By this, do you mean that the clock driver registers the power domain
> controller through devm_mfd_add_devices()?

There are multiple ways this is being solved but NONE of them are
binding ways. You again bring driver into bindings discussion.

Best regards,
Krzysztof