From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D666C3A5A3 for ; Tue, 27 Aug 2019 22:15:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40D9F20679 for ; Tue, 27 Aug 2019 22:15:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iEZ6Do+c"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="XLiVMvIb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40D9F20679 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VUlumeW8WMTZb+x6Nnmn4F3PwG2ippzjw/4wpR+rR+0=; b=iEZ6Do+cOuGDUu uqe8Rjh1QjmwOucct/HrDl6xmOKHF1OryDP1fIajmgd4P70Al7HVVeqFG1qPWcKkqxEqOtsqbBiuU yF5iCtb+AowQMH/HcHzwei3bZRS1lqwmPJWrgn/tT+JzBt7pstbzoKUQHZDhTgCQUa9/b8j8KR40t CVHl2+mfPJ94YlBLyNl9eoRn+hkLJYd2QlZm+qZmKYbIG8qp91rqValoiJ6kHD4d4MNv5ucm4521A yYNAQ7l6FXz38suM++0XXlZ9SWLoTag+8TSsWN4Hv8pvuaE2RhgqSVN2c4pn9HP4m2NLu6NORaDoG pctV00AMdugD1pBMpIbg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i2jkg-0004wR-FX; Tue, 27 Aug 2019 22:15:46 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i2jkc-0004w3-IW for linux-arm-kernel@lists.infradead.org; Tue, 27 Aug 2019 22:15:44 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id x7RMFd06100214; Tue, 27 Aug 2019 17:15:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1566944139; bh=clXFNBgwSck9rTxOo247PkRKSEoFPXqKlO574sWJ6g8=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=XLiVMvIbFuncOMbTT3YqzwHC9y7m9HjI5Rn/Hjxm0jv2eqE4fuo31vq8cgKx/Csyk jrdp5xsA6NaAPe3v8rn4JJdWGMpsdoXQjvX9c3yaYoW12ci2DhLXaS1X99ekDZyp9z igOJ8Jl7X8TeYHkv8Cb3D0guRTiFTDhDDlbUA/y4= Received: from DLEE108.ent.ti.com (dlee108.ent.ti.com [157.170.170.38]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x7RMFdHM063545 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 27 Aug 2019 17:15:39 -0500 Received: from DLEE104.ent.ti.com (157.170.170.34) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Tue, 27 Aug 2019 17:15:39 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Tue, 27 Aug 2019 17:15:39 -0500 Received: from [128.247.58.153] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id x7RMFdwq130567; Tue, 27 Aug 2019 17:15:39 -0500 Subject: Re: [PATCH] rpmsg: virtio_rpmsg_bus: replace "%p" with "%pK" To: Bjorn Andersson References: <20181024011909.21674-1-s-anna@ti.com> <40831f80-1e36-66ca-b8e5-684d46ba167e@ti.com> <20190827051007.GK1263@builder> <8d36d695-dd66-c21f-f49e-f6dc3dbdfc5a@ti.com> <20190827220711.GK6167@minitux> From: Suman Anna Message-ID: <619b06b0-c3cc-e36f-c3e5-d13e98520c9c@ti.com> Date: Tue, 27 Aug 2019 17:15:39 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190827220711.GK6167@minitux> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190827_151542_718664_12041C62 X-CRM114-Status: GOOD ( 19.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Loic Pallardy Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/27/19 5:07 PM, Bjorn Andersson wrote: > On Tue 27 Aug 13:25 PDT 2019, Suman Anna wrote: > >> Hi Bjorn, >> >> On 8/27/19 12:10 AM, Bjorn Andersson wrote: >>> On Fri 09 Aug 13:25 PDT 2019, Suman Anna wrote: >>> >>>> Hi Bjorn, >>>> >>> >>> Hi Suman >>> >>>> On 10/23/18 8:19 PM, Suman Anna wrote: >>>>> The virtio_rpmsg_bus driver uses the "%p" format-specifier for >>>>> printing the vring buffer address. This prints only a hashed >>>>> pointer even for previliged users. Use "%pK" instead so that >>>>> the address can be printed during debug using kptr_restrict >>>>> sysctl. >>>> >>>> Seems to have been lost among the patches, can you pick up this trivial >>>> patch for 5.4? Should apply cleanly on the latest HEAD as well. >>>> >>> >>> I share Andrew's question regarding what benefit you have from knowing >>> this value. Should we not just remove the va from the print? Or do you >>> actually have a use case for it?. >> >> I mainly use it during debug when comparing against kernel_page_tables >> and vmallocinfo. The pools that we use are not always guaranteed to be >> from linear memory, and behavior changes when using with CMA or DMA pools. >> > > Thanks Suman. It seems to me that there's room for improvement to aid > this kind of debugging. But your usecase seems reasonable, so I'm > merging the patch. Thanks Bjorn. > >> Note that usage of %pK does not leak the addresses automatically, but >> atleast enables me to get the values when needed. The changes also bring >> the usage in rpmsg core in sync with the remoteproc core. >> > > Sounds like shouldn't have merged them in remoteproc then ;P Slightly different reasoning looking at the commit, it was probably when %p was leaking the addresses. regards Suman > > Thanks, > Bjorn > >> regards >> Suman >> >>> >>> Regards, >>> Bjorn >>> >>>> regards >>>> Suman >>>> >>>>> >>>>> Signed-off-by: Suman Anna >>>>> --- >>>>> drivers/rpmsg/virtio_rpmsg_bus.c | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c >>>>> index f29dee731026..1345f373a1a0 100644 >>>>> --- a/drivers/rpmsg/virtio_rpmsg_bus.c >>>>> +++ b/drivers/rpmsg/virtio_rpmsg_bus.c >>>>> @@ -950,7 +950,7 @@ static int rpmsg_probe(struct virtio_device *vdev) >>>>> goto vqs_del; >>>>> } >>>>> >>>>> - dev_dbg(&vdev->dev, "buffers: va %p, dma %pad\n", >>>>> + dev_dbg(&vdev->dev, "buffers: va %pK, dma %pad\n", >>>>> bufs_va, &vrp->bufs_dma); >>>>> >>>>> /* half of the buffers is dedicated for RX */ >>>>> >>>> >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel