From: Marc Zyngier <maz@kernel.org>
To: Andrew Scull <ascull@google.com>
Cc: kvm@vger.kernel.org, Suzuki K Poulose <suzuki.poulose@arm.com>,
James Morse <james.morse@arm.com>,
Julien Thierry <julien.thierry.kdev@gmail.com>,
kernel-team@android.com, kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] KVM: arm64: Stop sparse from moaning at __hyp_this_cpu_ptr
Date: Mon, 08 Jun 2020 17:31:24 +0100 [thread overview]
Message-ID: <61b7e8e75b2d60b21b20d9919fc8bafc@kernel.org> (raw)
In-Reply-To: <20200608150035.GB96714@google.com>
On 2020-06-08 16:00, Andrew Scull wrote:
> On Mon, Jun 08, 2020 at 09:57:31AM +0100, Marc Zyngier wrote:
>> Sparse complains that __hyp_this_cpu_ptr() returns something
>> that is flagged noderef and not in the correct address space
>> (both being the result of the __percpu annotation).
>>
>> Pretend that __hyp_this_cpu_ptr() knows what it is doing by
>> forcefully casting the pointer with __kernel __force.
>>
>> Signed-off-by: Marc Zyngier <maz@kernel.org>
>> ---
>> arch/arm64/include/asm/kvm_asm.h | 9 +++++++--
>> 1 file changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/include/asm/kvm_asm.h
>> b/arch/arm64/include/asm/kvm_asm.h
>> index 0c9b5fc4ba0a..82691406d493 100644
>> --- a/arch/arm64/include/asm/kvm_asm.h
>> +++ b/arch/arm64/include/asm/kvm_asm.h
>> @@ -81,12 +81,17 @@ extern u32 __kvm_get_mdcr_el2(void);
>>
>> extern char __smccc_workaround_1_smc[__SMCCC_WORKAROUND_1_SMC_SZ];
>>
>> -/* Home-grown __this_cpu_{ptr,read} variants that always work at HYP
>> */
>> +/*
>> + * Home-grown __this_cpu_{ptr,read} variants that always work at HYP,
>> + * provided that sym is really a *symbol* and not a pointer obtained
>> from
>
> Look at `this_cpu_ptr` one thing that stood out was `__verify_pcpu_ptr`
> that is documented to be suitable for used in custom per CPU macros. I
> didn't get how it worked (a type check?) but maybe it would work here
> to validate the argment was indeed a per CPU symbol?
It only works for sparse, but that is definitely a good addition while
we're fixing the sparse compliance.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-06-08 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 8:57 [PATCH] KVM: arm64: Stop sparse from moaning at __hyp_this_cpu_ptr Marc Zyngier
2020-06-08 15:00 ` Andrew Scull
2020-06-08 16:31 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61b7e8e75b2d60b21b20d9919fc8bafc@kernel.org \
--to=maz@kernel.org \
--cc=ascull@google.com \
--cc=james.morse@arm.com \
--cc=julien.thierry.kdev@gmail.com \
--cc=kernel-team@android.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).