From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4666DCD98D2 for ; Thu, 11 Jun 2026 12:23:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XWWde8oTiwpIrCzHwuGTBaaddX/30yZJJn3ORVLoQD4=; b=1AhsfwcDQeQnZwV7j7D+YF4VCP d7o0sPzIXHjeWq24xJovj8/gPBoZe8nq5VYRj037yYbh3d6Nq+3fUTsfNGVr1UX0IGDh4GlKUqTRy McGgOQFlCLKBTcsUlUJ9Env2opnCOy81lQhFccmR9LwhQOiHrxT8a7gwZjj7ja0/mFWk1h9wqIdZX 4iEvJOfzcbm/u3yDBe1w4YeLfg3nC/3QmtrOtfg6ANKmhsC+HWtpeX/+72C9rTti7VinKpssxZDxT cudLXZkYXrH/nSzk3tK4RxpqnrXvfPsBhWlVtHjjcrlXJUI0DkDeH+MXZbst3os+CYdBGA6kZ+9ea ccQqehoA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wXeRZ-00000009Now-1ld4; Thu, 11 Jun 2026 12:23:33 +0000 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wXeRW-00000009NoD-3aj7 for linux-arm-kernel@lists.infradead.org; Thu, 11 Jun 2026 12:23:32 +0000 Received: by mail-pj1-x102b.google.com with SMTP id 98e67ed59e1d1-36ba285e98bso7784549a91.2 for ; Thu, 11 Jun 2026 05:23:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781180610; x=1781785410; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XWWde8oTiwpIrCzHwuGTBaaddX/30yZJJn3ORVLoQD4=; b=IHp/g95ILkuBdrYr/DlPEsmy7WHCKgH+xjOupBpr4OkBUgQJbDUcJngZthVM5cICSE bkMCoZ4kO8oGHry/zl8X/gMS4Yyffz7j12ykJhLeyNM/CjqEl1QnRNLKylAwGyExKNaH KhxJXX2IpcvvbnVNb4QqX2w5u9qhMS3uwiLDHW9LKfx9lC6PXb4SXju2DtaKari146R4 5ENvXuOlJLT5pe79YBrT0qQJ9mA8q69MNleX+RpD+L5FyuapUp3S4FnRv2W1FhhDov2F fHe+G6t9ZNWOxWnFiMIMdzv2/rJ+Z0ZYOQEtuC2f/SUJC+QhV4KF0CdVgH91Pncwf+uA 31PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781180610; x=1781785410; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XWWde8oTiwpIrCzHwuGTBaaddX/30yZJJn3ORVLoQD4=; b=tY8uZza1jUwutiZqRJKlwJcBulxi9u86TxMwFJq4jw2/2wUwraMVyE7sHm3apLewyy LjclRBKAQUWx7DbhfYVBx4fvsihhLXHKLyu9JqxmUPC33qkWjnGU1BbL9AHyRfaYSDpe mKy4PK69KMxfNWXFtTiyjEhyTwdD7OcpO4hIqhlrwmBisD9A/ohw+s8i5FT+NNvwoUlY 9unRBMpVdDDUboh7608BSEkOyyOaluZUJ2bZYQkQNvaR+CMGyYn5guJpJsXuE8I+oQEq vw51mYScHSWDnVoESxaV49rMXZiP4QbKf3Mj5b+4QXOwss+rxOmethHPq8Gq6R7EGUHs SjxA== X-Forwarded-Encrypted: i=1; AFNElJ+2MZsBTZ8S7BGaEeMNbjWQtrtZFdTx1FpjPSraSi3khpC+esX+qSpc0XFLWiZvGBQtaXAozUTz87QFJpTOF0ci@lists.infradead.org X-Gm-Message-State: AOJu0YwopqyzOXyK/LzOhEJdjFTXbsuxLnMzAvlvCnxnY7G4zLbnv8ZY mM07HZ1AH1Gzyr0s8z1aF/wipv0T5ydMAWrm+dpaNh2mVX85HkVYqRs8 X-Gm-Gg: Acq92OGBa92pCS9AcV2LXlx5E1iXAkXqyOXyge69fQBkLZMYqNWNSblgpAoa2eUk7ws 8s1TARH0lexPYiiUH/UcsX80b1QgWD2iyN/tyOUUlXDgH/n1+BYkwSBv8wUBt6ulGy6iYY2JVcf q6AM5LyjTg8iyf83HOHB9FKAAqRSKYtABl9Djl+K322cYZXKFQpfYDe+lIi6/lSKBtrWVPc4S2N Q9M/RS5JJGAGAzorKJntgsAOH+5+WRd+vHEzwE9t/U+dg0moUCZYl34RA4ANC4HdpzFp41rR3Hq fx5L3WwlrCxTr0cRJnFQR4TIo/P1DUVZe7jLwXcVdGoQRH1nzX+JmBoIxDIX5XAAzo9CTApc7s0 1+8z3Ob0314SacK/Y6qYXOms8DQC7ck1eg3vek8hy8fO97cPwkOmR3NwpvtSRt9XOERpMKUuw8F qTogrQIYQVFIcs5Zkodwe1YsPP8qeiD+8jK/gg1eLz6A== X-Received: by 2002:a17:90b:3a05:b0:36d:b12f:613c with SMTP id 98e67ed59e1d1-3779f186dcfmr2904451a91.10.1781180609829; Thu, 11 Jun 2026 05:23:29 -0700 (PDT) Received: from [192.168.89.2] ([27.232.220.71]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3774f4c2e5asm2564395a91.0.2026.06.11.05.23.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jun 2026 05:23:29 -0700 (PDT) Message-ID: <61bf60fd-2ccb-4d23-be5e-041c7c312510@gmail.com> Date: Thu, 11 Jun 2026 21:23:25 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] xfrm: extend ESP offload infrastructure for packet engines To: Leon Romanovsky Cc: Christian Marangi , Antoine Tenart , Herbert Xu , "David S . Miller" , Lorenzo Bianconi , Andrew Lunn , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Steffen Klassert , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org References: <20260523121522.3023992-1-hurryman2212@gmail.com> <20260523121522.3023992-2-hurryman2212@gmail.com> <20260611115646.GN327369@unreal> Content-Language: en-US From: Jihong Min In-Reply-To: <20260611115646.GN327369@unreal> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260611_052330_899055_76A13885 X-CRM114-Status: GOOD ( 18.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/11/26 20:56, Leon Romanovsky wrote: > On Sat, May 23, 2026 at 09:15:20PM +0900, Jihong Min wrote: >> Some ESP offload engines operate on whole ESP packets rather than the >> generic software trailer layout. They can generate outbound ESP padding, >> next-header and ICV bytes in hardware, and inbound decapsulation can >> return an already-trimmed packet with the recovered next-header value. > > How does this differ from the existing IPsec packet‑offload support in the > Linux kernel? > > Thanks Hi Leon, The short answer is that the series did not explain the relationship with the existing XFRM packet-offload model clearly enough. Existing XFRM_DEV_OFFLOAD_PACKET already represents the high-level model where hardware handles ESP packet processing instead of only crypto transforms. What I was trying to handle in this series was a narrower case: EIP93 is a look-aside crypto/IPsec engine, not the netdev itself, so the Airoha netdev had to attach that engine into its TX/RX path and let it generate or consume the ESP packet framing. The extra hooks in this series were meant for that look-aside integration, but looking back, the split between the existing packet-offload model and the new plumbing was not clean enough. At this point, though, I think the right thing is to withdraw this EIP93/Airoha series. The reason is related to the SOE work I mentioned in the other patch thread. Many Airoha SoCs also have a higher-performance IP block called SOE (Secure Offload Engine). I recently wrote and tested a driver for that block, and I am currently carrying it here: [kernel: add bonding LAG XFRM offload infrastructure and Airoha support](https://github.com/hurryman2212/OpenW1700k-test/commit/fbfe8f919f836bb62b3849f803865a4d9b8dc76f). With the EIP93 path I could get around 1 Gbps, while the SOE path can reach about 5 Gbps in my current setup. Because of that, integrating this EIP93 ESP packet path directly into `airoha_eth` is no longer the most useful direction for Airoha Ethernet. That said, SOE exists only on some Airoha SoCs. EIP93 can still be useful on other platforms as a look-aside ESP packet offloader, but I think that needs a cleaner infrastructure than this series had. The look-aside offloader should be able to live as a separate module, not be tied directly to one specific netdev driver, while still allowing compatible netdevs to attach it into the XFRM path. I think that needs a more general infrastructure extension, so I would rather revisit the EIP93 work later on top of that kind of model. Sincerely, Jihong Min