From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A932C433B4 for ; Mon, 12 Apr 2021 09:28:24 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 09873611F0 for ; Mon, 12 Apr 2021 09:28:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 09873611F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:References: CC:To:Subject:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=D8wd3EAZnqHzQnAbJ57hvNK4cIaZjtButFZWir8ia30=; b=KG0rnSMum9DjiD/kJCHQW5R5s kenPYcLVwMAALjk6WznyQAaHZ7KawYVHpfGT4WmosLFbp1e/DWr4InDIBa1aeZkemWkxGjyeAUZW1 rZKLjp20h0nMIaXQF1r6r55mNK/NMEzmoUoiZD2xtjoXT6d/3vwRKGH67K6x8e7NGZyKbuqJG34ol 8uvh72xiOGdZTe+0Qr1kuUF6meq9QDY1TNDLgidxgjISZJg7tBH8jw3+05bHxwNJe/qdze39zxCiW 7qT2kvP4bl7yaWlwVUWCJVlOZMYyVMrT1jXLJzO/cXHf3cFkhyTNR0HBbPb0UdPgnK2ArtAPZ09p8 JrtE/5/Mw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lVsq7-006Gsw-8X; Mon, 12 Apr 2021 09:26:39 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVsq4-006Gsb-9J for linux-arm-kernel@desiato.infradead.org; Mon, 12 Apr 2021 09:26:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:References:CC:To: Subject:From:Sender:Reply-To:Content-ID:Content-Description; bh=7X5hJ0swIgdwTrO9RnjbXMZ+r1QGTKr3SWpWoc5weRA=; b=a11fEOQY4O4/oVwlqu2vpNzaXC CzaShVezZmQCuVqATdozUNEPoNv5u/Y6UIlyiLPnPc5K0c5ou0wffH9HOiIxRkEQ/6/IyoLIyjbpo 33jJ7DzsajU7/ck8pjtFQS9Si6I9f3YO77PbOXVTZn0CU+bsLwaKp9giLiOJekG4sEmZ660fPLd3X 32ttJOCu4e6Pe4+HsK3hXqiu/Y6AbPxTXKMr8ohumJ+AeWaTtX2icvfJzY4GTKz1l41MLgn0L9ePa 8osAumPTmW1KuJGo5bRch4nFn3BEmtLxVs7lvBateCOGP3B1RIK0atoBnyqq1FutMWaQoVwo4+b05 zxQN0pDA==; Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVsq1-0063QV-Cc for linux-arm-kernel@lists.infradead.org; Mon, 12 Apr 2021 09:26:34 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 13C9QPwu098727; Mon, 12 Apr 2021 04:26:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1618219585; bh=7X5hJ0swIgdwTrO9RnjbXMZ+r1QGTKr3SWpWoc5weRA=; h=From:Subject:To:CC:References:Date:In-Reply-To; b=G5sjyoRny2Ya7nvLiRL4e+y2I9NplGItxcuVejNM+V+MFsL51bH76r14PhSTjygjc k0PsufqcTHkxSpbuzh4CkMo2bT97JeO5hgv0HsemdVROd5NW839AxX2aLLETnfSsvx GbCbggA6D9eZUE0z1TDPnaI5V3WMf7qBqT3QML4w= Received: from DLEE104.ent.ti.com (dlee104.ent.ti.com [157.170.170.34]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 13C9QPfE053667 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 12 Apr 2021 04:26:25 -0500 Received: from DLEE102.ent.ti.com (157.170.170.32) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 12 Apr 2021 04:26:25 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Mon, 12 Apr 2021 04:26:25 -0500 Received: from [172.24.145.136] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 13C9QLZL130088; Mon, 12 Apr 2021 04:26:22 -0500 From: Vignesh Raghavendra Subject: Re: [PATCH 2/2] arm64: dts: ti: k3-am654-base-board: remove ov5640 To: "Yadav, Pratyush" , Laurent Pinchart CC: Tomi Valkeinen , "Menon, Nishanth" , "Parrot, Benoit" , "devicetree@vger.kernel.org" , Rob Herring , "linux-arm-kernel@lists.infradead.org" , Tony Lindgren References: <20210412075306.102884-1-tomi.valkeinen@ideasonboard.com> <20210412075306.102884-2-tomi.valkeinen@ideasonboard.com> <20210412083605.qnpf2mxy3rcaj7dv@ti.com> Message-ID: <61ca0a2b-900e-daca-3d51-e8fd2c2b8073@ti.com> Date: Mon, 12 Apr 2021 14:56:21 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210412083605.qnpf2mxy3rcaj7dv@ti.com> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210412_022633_551139_DFC88CA9 X-CRM114-Status: GOOD ( 19.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/04/21 2:06 pm, Pratyush Yadav wrote: > + Vignesh > = > On 12/04/21 11:00AM, Laurent Pinchart wrote: >> Hi Tomi, >> >> Thank you for the patch. >> >> On Mon, Apr 12, 2021 at 10:53:06AM +0300, Tomi Valkeinen wrote: >>> AM654 EVM boards are not shipped with OV5640 sensor module, it is a >>> separate purchase. OV5640 module is also just one of the possible >>> sensors or capture boards you can connect. >>> >>> However, for some reason, OV5640 has been added to the board dts file, >>> making it cumbersome to use other sensors. >>> >>> Remove the OV5640 from the dts file so that it is easy to use other >>> sensors via DT overlays. >>> >>> Signed-off-by: Tomi Valkeinen >>> --- >>>=A0 .../arm64/boot/dts/ti/k3-am654-base-board.dts | 27 -----------------= -- >>>=A0 1 file changed, 27 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm6= 4/boot/dts/ti/k3-am654-base-board.dts >>> index fe3043943906..76358b4944e1 100644 >>> --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts >>> +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts >>> @@ -85,12 +85,6 @@ sw6 { >>>=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 gpios = =3D <&wkup_gpio0 27 GPIO_ACTIVE_LOW>; >>>=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 }; >>>=A0=A0=A0=A0=A0 }; >>> - >>> -=A0=A0 clk_ov5640_fixed: clock { >>> -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 compatible =3D "fixed-clock"; >>> -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 #clock-cells =3D <0>; >>> -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 clock-frequency =3D <24000000>; >>> -=A0=A0 }; >>>=A0 }; >>>=A0 = >>>=A0 &wkup_pmx0 { >>> @@ -288,22 +282,6 @@ &main_i2c1 { >>>=A0=A0=A0=A0=A0 pinctrl-0 =3D <&main_i2c1_pins_default>; >>>=A0=A0=A0=A0=A0 clock-frequency =3D <400000>; >>>=A0 = >>> -=A0=A0 ov5640: camera@3c { >>> -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 compatible =3D "ovti,ov5640"; >>> -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 reg =3D <0x3c>; >>> - >>> -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 clocks =3D <&clk_ov5640_fixed>; >>> -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 clock-names =3D "xclk"; >>> - >>> -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 port { >>> -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 csi2_cam0: endp= oint { >>> -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0 remote-endpoint =3D <&csi2_phy0>; >>> -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0 clock-lanes =3D <0>; >>> -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0 data-lanes =3D <1 2>; >>> -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 }; >>> -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 }; >>> -=A0=A0 }; >>> - >>>=A0 }; >> >> As for patch 1/2, you could drop the two nodes completely. Same question >> about overlay availability. > = > The &main_i2c1 node was added much before the OV5640 node in = > 19a1768fc34a (arm64: dts: ti: k3-am654-base-board: Add I2C nodes, = > 2018-11-13). I wonder if there is any reason for having it present even = > if there are no subnodes. One reason that I can think of is that this = > node defines the pinmux configuration and clock frequency which makes = > more sense here than in an overlay. > = No, please don't drop main_i2c1 node. As long as pinmux is setup, its possible to communicate with I2C devices from user space too even when there are no subnodes. -- = Regards Vignesh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel