From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27B23C004C9 for ; Fri, 3 May 2019 17:13:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF5B520651 for ; Fri, 3 May 2019 17:13:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lLdara8S" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF5B520651 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hInonINQvzDDhYcooW97F2LsxN4F7hKJ+ykzeF9G/5U=; b=lLdara8SNrPtwuZOAF4XIhUZy a1H83b3diSuomuqI6E5svauT6VQcluAkhcAmmsnqX/q/VD8B87p3mqCNlOovzb/8siYxOtn09ddYu KIQjNM+0TRMXcjBPMOYue0JrUnbCCl6idV0BowU8veSfNOO2dfCnsmkA1Yj8QkmzE+pNuz6Ox99vO 0gPLRDl9dEGMiswCMO3cdxMCCG3p1Tn0vsv5JaYxRjFiKG/1Mk33M9L71ZUyfiY5FzjirisBUyh5i HBY+NhBzhfeUBDUEV2Q1612EnOD/IKL2L4/Ije+UJNS2pEixoojo81KnUyj0XppSWOA//7+/wcuWH IEmEo6eVQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hMbkk-0002D3-JB; Fri, 03 May 2019 17:13:42 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hMbkh-0002Cb-V1 for linux-arm-kernel@lists.infradead.org; Fri, 03 May 2019 17:13:41 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 93F5215A2; Fri, 3 May 2019 10:13:39 -0700 (PDT) Received: from [10.1.196.93] (en101.cambridge.arm.com [10.1.196.93]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 53B5F3F557; Fri, 3 May 2019 10:13:38 -0700 (PDT) Subject: Re: [PATCH v2 08/36] coresight: tmc: Clean up device specific data To: mathieu.poirier@linaro.org References: <1555344260-12375-1-git-send-email-suzuki.poulose@arm.com> <1555344260-12375-9-git-send-email-suzuki.poulose@arm.com> <20190417212325.GC14163@xps15> From: Suzuki K Poulose Message-ID: <61ccfc44-c062-fa3e-6de9-825def4e9891@arm.com> Date: Fri, 3 May 2019 18:13:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190417212325.GC14163@xps15> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190503_101340_005857_08479FB5 X-CRM114-Status: GOOD ( 21.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: coresight@lists.linaro.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, robert.walker@arm.com, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mathieu On 17/04/2019 22:23, Mathieu Poirier wrote: > On Mon, Apr 15, 2019 at 05:03:51PM +0100, Suzuki K Poulose wrote: >> In preparation to use a consistent device naming scheme, >> clean up the device link tracking in replicator driver. >> Use the "coresight" device instead of the "real" parent device >> for all internal purposes. All other requests (e.g, power management, >> DMA operations) must use the "real" device which is the parent device. >> >> Since the CATU driver also uses the TMC-SG infrastructure, update >> the callers to ensure they pass the appropriate device argument >> for the tables. >> >> Cc: Mathieu Poirier >> Signed-off-by: Suzuki K Poulose >> diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c >> index f684283..0911f9c 100644 >> --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c >> +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c >> @@ -153,10 +153,11 @@ static void tmc_pages_free(struct tmc_pages *tmc_pages, >> struct device *dev, enum dma_data_direction dir) >> { >> int i; >> + struct device *real_dev = dev->parent; > > I would have kept the 'dev' as it is quite obvious from the dev->parent that we > are getting a reference on the parent. That is just my opinion and it is > entirely up to you. "dev" is already an argument to the function. Hence the "real_dev" choice. >> diff --git a/drivers/hwtracing/coresight/coresight-tmc.h b/drivers/hwtracing/coresight/coresight-tmc.h >> index 487c537..3eeadcf 100644 >> --- a/drivers/hwtracing/coresight/coresight-tmc.h >> +++ b/drivers/hwtracing/coresight/coresight-tmc.h >> @@ -175,7 +175,6 @@ struct etr_buf { >> */ >> struct tmc_drvdata { >> void __iomem *base; >> - struct device *dev; > > Please clean up the structure documentation. > > With that and regardless of what you decide to do about the 'real_dev': Done. > > Reviewed-by: Mathieu Poirier Cheers Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel