From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46CCBC3DA59 for ; Tue, 16 Jul 2024 12:14:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vyxnnE0zepFaZUKd9AE+84DlPyZhFF7Z4N8eydCCjbU=; b=ZphnYFbyRRB7CAkj0t64lSK9Ot uDxGqxFK2atjdFSv1S3xdpZig9lMh7s/TLSrXtT6A9lFZI31ip4cbZpecbXPVozUCMAH/njz8mgOt PSH/3q6wobiMIJydcnwBhn5+WH0YMbTVXLrl0MkcIVxRNYwJPN64AZ+WFsMcvGPd9EEE84FYnaIMG HlxgPHZtf1dIDrEoEipnlQ4DD5lqSYwnCpONwYwbMtS5lWT+RfaTXhcI5kiwn6Z06WLfvGDIC2WGc lqkQQkYBbxkB5/EYPQs3g/pdMQsO1shFsg55VgnmEY7JJ4CKPxEH0OKI2MaDApcwCTHHiuJS1WsRj NTli4f1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTh4n-0000000ANPc-34m1; Tue, 16 Jul 2024 12:14:37 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTh4T-0000000ANKO-2eN3 for linux-arm-kernel@lists.infradead.org; Tue, 16 Jul 2024 12:14:19 +0000 Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-a77e392f59fso645852366b.1 for ; Tue, 16 Jul 2024 05:14:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721132055; x=1721736855; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=vyxnnE0zepFaZUKd9AE+84DlPyZhFF7Z4N8eydCCjbU=; b=fZtredZfe6djrESWZ7AFB6QeMVtsqKVeVguxhq7M2QnNPavp3EVvUB+HwWcwnsZZHy B+hH+BMSrQjB1ja+mTAZe0KyCad+VYRruo5N3QWPmRYk5qX/MyVAKvOo8yR01O8oBGhq K6YWGvECzRpfKZ/TqjhbpZ6Ne12ZqTGHvPJ/G6PVxD7F0aUz0MMvTtZrrDS/TlqJ7XhO GTgWEHpnsTfQZEJErwOTYVYLfy4u8IzvlD1+GVexDJ3dahfukjZCR8baejqGpZeWccyA yyUyywXe5inrsLkHoQGkB40LMKNaNPnQo/Fqv7DghY4Oe9LGOzYgHwFkjdWLVsRh6rmd XUpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721132055; x=1721736855; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vyxnnE0zepFaZUKd9AE+84DlPyZhFF7Z4N8eydCCjbU=; b=nt3xNfF9Ad61/4Hm/QCuUVmdfNKlsEISPqW6tn18ruDQbV8WOMXCrTkeq2SXtb6t+M /p1KR49zpaeJoMGh6eziVeNo455nW7vvtKbyI1Z3hnPpllJnty5/bCv9YodlvkM9OE5Q pLlx/s4lceM4Pr89ZKIQheE6RmjoqEgHWtH8bhok1htUSW00qor1luG/7E579N15gSz/ 7WT+6EiyJcWDo4TQZW9uyrrCQ89cwOWk0Hi4fP00fS1bVbbexvZRu1OtL2BK076t4g3x PptpdefXWIouVWamb+x+S6yS7ZOaR2CTScFPetOMkw9KIeZ9J3vf5MNdcWRLUGrrK5xO J+1A== X-Forwarded-Encrypted: i=1; AJvYcCUZF3Pq2aj1UG9R0+hq+xQLgp64CYAo4+kqiRaCZ5Z0ifTREhmAWTXDWItwhRCYxIgI83rwemQjgnh27rBOE1XplHu4ZdgXs/HuVcfB75CyTNhgSrk= X-Gm-Message-State: AOJu0YwMhqaASi+qyU4f1l4ioHjwPZQanFzLvzjQQKiXi7lGYB+cT0Kx +2QJB7PutJh89zX85CjXaFGpUiuacwSAGCgoKxWcqJSIAyeT9VhOwShGXXQrzbI= X-Google-Smtp-Source: AGHT+IH0R+a9GVWEl6OcxuSggOE7JIjknEw6ljqIh13dNXnwXp9AsE5YkhDQQ1zeR2LFCNPLR6Gw0A== X-Received: by 2002:a17:906:2a44:b0:a6e:f997:7d91 with SMTP id a640c23a62f3a-a79ea491f74mr131815266b.38.1721132055204; Tue, 16 Jul 2024 05:14:15 -0700 (PDT) Received: from [192.168.105.194] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a79bc5a39dasm305565766b.43.2024.07.16.05.14.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jul 2024 05:14:13 -0700 (PDT) Message-ID: <61e04616-32f8-4574-9721-ea032d227bf2@linaro.org> Date: Tue, 16 Jul 2024 14:14:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v13 6/6] iommu/arm-smmu: add support for PRR bit setup To: Rob Clark , Bibek Kumar Patro Cc: will@kernel.org, robin.murphy@arm.com, joro@8bytes.org, jgg@ziepe.ca, jsnitsel@redhat.com, robh@kernel.org, krzysztof.kozlowski@linaro.org, quic_c_gdjako@quicinc.com, dmitry.baryshkov@linaro.org, iommu@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Clark References: <20240628140435.1652374-1-quic_bibekkum@quicinc.com> <20240628140435.1652374-7-quic_bibekkum@quicinc.com> <0650ba0a-4453-4e2d-8a76-0f396ac1999c@quicinc.com> <4a5f54c7-120e-427d-8a0a-9fb83e13a72e@quicinc.com> <3b7c05b1-8f36-4c81-a55c-dbb467314099@quicinc.com> <9509f256-04a4-4907-98fc-148c5087d74d@quicinc.com> <3382aaca-4ca1-46e5-a445-dcb115ff206f@quicinc.com> Content-Language: en-US From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240716_051417_704144_6184F88F X-CRM114-Status: GOOD ( 19.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 15.07.2024 10:07 PM, Rob Clark wrote: > On Mon, Jul 15, 2024 at 4:00 AM Bibek Kumar Patro > wrote: [...] >>>> As I checked gpu_prr_mem reserved mem section is not used for mobile >>>> targets hence not present for other DT only compute targets like >>>> x1e80100.dtsi has the same. PRR looks to be smmu version specific >>>> property. >>> >>> I only see it in gpu_prr_mem in x1e80100.dtsi, but not documented >>> anywhere. I'm only assuming based on the name that it is intended to >>> be for PRR (but not sure why it is larger than 0x1000). Are the >>> PRR_CFG_*ADDR regs programmed by the fw (and access blocked in EL1) on >>> this device? >>> >> >> As I checked, if the drm/gfx driver allocates the page for drm, then >> this reserved-memory region is not required. >> >> PRR_CFG_*ADDR regs have read and write access in EL1 only for this >> device, behavior is same as other devices as well. These are not >> programmed by fw. > > If there is any device which _doesn't_ have EL1 access to these regs, > I think going the reserved memory route seems more future proof? > Otherwise we later on have to deal with two different ways to do > things. But I'm not sure if there is any such device or risk. We can have our cake and eat it too, if we keep the check for a reserved memory node handle, but make it a dynamic allocation (see [1] for example), this way there's a way to opt into using this from the DT and there's no need for adding more properties Konrad [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/msm8916.dtsi?h=v6.10#n109