From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 354F4ECAAA1 for ; Fri, 28 Oct 2022 12:56:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Oyotzr9oDj1A0FLbAtJ8X+Cmj+9n8Ke9dqFJDtcuGGo=; b=zRitL6XscjSWno ZAV99jlBAFQCK/U9uSnumvQmJoBGqH56gBJG2EnZGP6c7VL8F6Cexp9CKVeCfedvrrQw4hOQJkxQ2 L2xf534gSRNZzLvUKtznLwBqXZXF1piSLmS1KYVMDfbG+LuV7WRhhrzwdRW1QevgItpbdwotxljWk WUxunoKPmxvXB/E69bpOzcw5iiq+yJudZ949svlbCWWa7wy40dfCFTboWaXVurIJOiTkyuYTXvCQy 4fuJIw6+gZt4WEP1NbopGcEz4di/QA4pBDyV+25srdz3bhkM5CZLY3dvJLs0JqbY+yQTVNNmzICBC yPtvg1SqFqO+AkkFbeyQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ooOtr-00HAvl-Aw; Fri, 28 Oct 2022 12:55:51 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ooOto-00HAst-BD for linux-arm-kernel@lists.infradead.org; Fri, 28 Oct 2022 12:55:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1666961748; x=1698497748; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=j6mmci6yqeE9vsqUFPTb1XAq/fXqTEJvQ3kd2FzN0qw=; b=QOv6XbAdrDvUt/m01v6rlQWT9zp7fWGG2MxfMuOmFUgViSMGfb6md9gE 3mDOFLOU9pAiTXgZG+Myl+AdzlLY7IDzoS0MQjRd159GBK9OYb/sVSLx6 urZPolb7/NSsKqJlU82anr3oWXcYKRhAdVzSCo62/ypgB6QbhuGmEeUjU T12RstBBgX/QeLtE54jjS7pcuN+RGoL2P+JCtOoJ7siMO56081mLXbrpY 0+P0W9aL1SWLVPof1Xn522hKa2PxNPJGhF+KBKEV7eMhtcfOmnEiE7Vs2 gRTCigpO+cD9db96Se6Vlqrdma0oVjsJ5msJeQfaP/ZkKXp2UIe5o3XFO g==; X-IronPort-AV: E=Sophos;i="5.95,221,1661842800"; d="scan'208";a="186775063" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 28 Oct 2022 05:55:40 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Fri, 28 Oct 2022 05:55:40 -0700 Received: from [10.159.245.112] (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Fri, 28 Oct 2022 05:55:38 -0700 Message-ID: <61e54c48-6347-f0ab-e843-ae48d5374903@microchip.com> Date: Fri, 28 Oct 2022 14:55:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2 32/32] dmaengine: at_hdmac: Convert driver to use virt-dma Content-Language: en-US To: Tudor Ambarus , , , CC: , , , , , References: <20221025090306.297886-1-tudor.ambarus@microchip.com> <20221025090306.297886-33-tudor.ambarus@microchip.com> From: Nicolas Ferre Organization: microchip In-Reply-To: <20221025090306.297886-33-tudor.ambarus@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221028_055548_441372_DDECE7D9 X-CRM114-Status: GOOD ( 15.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 25/10/2022 at 11:03, Tudor Ambarus wrote: > Convert the driver to use the core virt-dma. The driver will be easier to > maintain as it uses the list handling and the tasklet from virt-dma. > > With the conversion replace the election of a new transfer in the tasklet > with the election of the new transfer in the interrupt handler. With this > we have a shorter idle window as we remove the scheduling latency of the > tasklet. I chose to do this while doing the conversion to virt-dma, > because if I made a prerequisite patch with the new transfer election in > the irq handler, I would have to duplicate some virt-dma code in the > at_hdmac driver that would end up being removed at the virt-dma conversion > anyway. So do this in a single step. > > Signed-off-by: Tudor Ambarus Even if it's difficult to review, I support the transition: Acked-by: Nicolas Ferre Thanks Tudor, regards, Nicolas [..] -- Nicolas Ferre _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel