From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47067C43381 for ; Mon, 1 Apr 2019 08:00:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1251B20643 for ; Mon, 1 Apr 2019 08:00:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FPChXYwU"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="XSo5YjDq"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="KLOIxtdc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1251B20643 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=diAxcU0Iy26nwvK83LxanmZ3ogoc8nrYG/2QtYMnB74=; b=FPChXYwUZW57dLlubBIcwcTAo tEVrh1c3h7yjjrZCzkppIenk/smPCpsaeUyh5Qp+xBT3aIs6/MSin3F3GV7h0TvSeQ8dC6fQqAhEe HJjdQln/HWTnNBez6313X+x0WuqKGdEZJr0puJ9+pDtVFJjfhRM3VNl8wHzCDcoYlTamEl697BB2m OKl3Q5trVXPX+RvoKaaSDWfHuJTttLeZJhYfmqe6JlIBLK2sbRu1Nu3HAr4HsM29oDbxAv9nyle3H xr1lHxC5WzHifFh7LmEGNBIx+C2x4NeqzgqrIGZ3CBE4QiQi0Mzvm7OKtSLT2OnOdhvkElBnOSzid oc4tm3cVQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hArrG-0002uy-UI; Mon, 01 Apr 2019 07:59:54 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hArr2-0002gE-9o for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2019 07:59:42 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 8B8D4608CC; Mon, 1 Apr 2019 07:59:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1554105579; bh=vsJ4WdJT2ZQrZlnOCKodM05l57aN0m13tWxStHhCL0o=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=XSo5YjDqoq+WMX3ToDFUcuC7GgMnahWGx5y9rtDdqGKBE7YcUhBL+d3RpzJMTbj41 QBZ4eI9AdKOj9UzfZr3IXz/6RdM92LC3Xo0gR/nG1Egy2vxZNPRSuahHJwUxJ22arp HhpFriivQwIlbaoC6GzAghHGcIpE7J8VnoO54OyY= Received: from [10.204.79.83] (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mojha@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1C05460735; Mon, 1 Apr 2019 07:59:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1554105578; bh=vsJ4WdJT2ZQrZlnOCKodM05l57aN0m13tWxStHhCL0o=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=KLOIxtdcvWBTxy5W5C+2X4GNyiVlaKNOJiSyuCllAASmmnNjK4GNb6DN3DgCHJaoz cKXnCiKtTYLXgAb3cq+zu9HhhsSvF3cAnzdW26azolbVzKyRW70Ej1lYmZg14OLgkF TBX4U1Ygy4IG3O78w5L7o2ba/YEgXadt3j25+hfc= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1C05460735 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=mojha@codeaurora.org Subject: Re: [PATCH] input: keyboard: imx: use devm_platform_ioremap_resource() to simplify code To: Anson Huang , "dmitry.torokhov@gmail.com" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , "linux-input@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" References: <1554096209-17870-1-git-send-email-Anson.Huang@nxp.com> From: Mukesh Ojha Message-ID: <6214bf1b-6d5f-5c55-6f5d-9f1342722e20@codeaurora.org> Date: Mon, 1 Apr 2019 13:29:29 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1554096209-17870-1-git-send-email-Anson.Huang@nxp.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190401_005940_373838_59B12F22 X-CRM114-Status: GOOD ( 16.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dl-linux-imx Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/1/2019 10:58 AM, Anson Huang wrote: > Use the new helper devm_platform_ioremap_resource() which wraps the > platform_get_resource() and devm_ioremap_resource() together, to > simplify the code. > > Signed-off-by: Anson Huang Reviewed-by: Mukesh Ojha Cheers, -Mukesh > --- > drivers/input/keyboard/imx_keypad.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/input/keyboard/imx_keypad.c b/drivers/input/keyboard/imx_keypad.c > index 539cb67..cf08f4a 100644 > --- a/drivers/input/keyboard/imx_keypad.c > +++ b/drivers/input/keyboard/imx_keypad.c > @@ -422,7 +422,6 @@ static int imx_keypad_probe(struct platform_device *pdev) > dev_get_platdata(&pdev->dev); > struct imx_keypad *keypad; > struct input_dev *input_dev; > - struct resource *res; > int irq, error, i, row, col; > > if (!keymap_data && !pdev->dev.of_node) { > @@ -455,8 +454,7 @@ static int imx_keypad_probe(struct platform_device *pdev) > timer_setup(&keypad->check_matrix_timer, > imx_keypad_check_for_events, 0); > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - keypad->mmio_base = devm_ioremap_resource(&pdev->dev, res); > + keypad->mmio_base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(keypad->mmio_base)) > return PTR_ERR(keypad->mmio_base); > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel