From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 934FFC10F0E for ; Fri, 12 Apr 2019 16:04:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 60D7021872 for ; Fri, 12 Apr 2019 16:04:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CoKvSZlI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60D7021872 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OsW2FheB6C7/UiqbiQX1sq/4oM2reywMVEoludk0XSE=; b=CoKvSZlIm4cm79 NRFJzTU/8rEEkOfFt2bXT3wL3k62T94GrlOJ5/E/JQ2atIEshpTZqW6WjVXuZ8UxQl/lHjsG8hIrf 6wuf45KrEqF8bHk/GSBtJv7e7XkO92BC9pA0g/l5kT58iMEpFJik4ESDc2IhYIChyNSjrt/N/o8SE 027aw2ELwLHaT5jOJaHbLsNUaK7YjmhUfyX9AXNlPXx3yveSFYtt1p/xO07Gshu7AvF8Z2H6DxJah TRceEe+6E+e7pcyOdSIGf+VERKmB56fkiRYEBq5zxGR+sl6KHQzlj7usIE6cgnCQdsjPE2s0kLiqV z2jljr0ca+I8OyKe9lsw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEyfL-0008NQ-4Y; Fri, 12 Apr 2019 16:04:35 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEyfG-0008LO-Jl; Fri, 12 Apr 2019 16:04:32 +0000 Received: from ip5f5a6320.dynamic.kabel-deutschland.de ([95.90.99.32] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hEyfF-0006bL-Al; Fri, 12 Apr 2019 18:04:29 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: linux-rockchip@lists.infradead.org Subject: Re: [PATCH] ARM: dts: rockchip: use non-secure timer as broadcast on rk3288 Date: Fri, 12 Apr 2019 18:04:28 +0200 Message-ID: <6218040.Bsc25Bnu9O@diego> In-Reply-To: <20190412160012.13066-1-heiko@sntech.de> References: <20190412160012.13066-1-heiko@sntech.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190412_090430_801842_1B228287 X-CRM114-Status: GOOD ( 15.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: daniel.lezcano@linaro.org, mka@chromium.org, dianders@chromium.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Freitag, 12. April 2019, 18:00:12 CEST schrieb Heiko Stuebner: > The rk3288 soc has 2 separate timer blocks one with 6 channels and > another one with 2 channels that can be set as secure. > > Firmware variants using psci might want to make use of that feature > making both channels of the secure timer inaccessible for a kernel > running in non-secure mode, which affects the timer currently used > as broadcast. > > Therefore move over to using the other (still unused) timer block > for that. The timer clock in the original node was also wrong, > as it was pointing to the 6-channel block already, while the clock > of the 2ch block gets controlled from the secure-grf. > > Signed-off-by: Heiko Stuebner And I just realized, that this is probably dumb, as the timers0-5 are in cpu powerdomain, while 6+7 are in the alive pd, so probably only the secure timers are always on, while 0-5 are likely shutdown during suspend. > --- > arch/arm/boot/dts/rk3288.dtsi | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi > index a024d1e7e74c..54c408694eac 100644 > --- a/arch/arm/boot/dts/rk3288.dtsi > +++ b/arch/arm/boot/dts/rk3288.dtsi > @@ -229,14 +229,6 @@ > clock-frequency = <24000000>; > }; > > - timer: timer@ff810000 { > - compatible = "rockchip,rk3288-timer"; > - reg = <0x0 0xff810000 0x0 0x20>; > - interrupts = ; > - clocks = <&xin24m>, <&cru PCLK_TIMER>; > - clock-names = "timer", "pclk"; > - }; > - > display-subsystem { > compatible = "rockchip,display-subsystem"; > ports = <&vopl_out>, <&vopb_out>; > @@ -714,6 +706,14 @@ > status = "disabled"; > }; > > + timer: timer@ff6b0000 { > + compatible = "rockchip,rk3288-timer"; > + reg = <0x0 0xff6b0000 0x0 0x20>; > + interrupts = ; > + clocks = <&xin24m>, <&cru PCLK_TIMER>; > + clock-names = "timer", "pclk"; > + }; > + > bus_intmem@ff700000 { > compatible = "mmio-sram"; > reg = <0x0 0xff700000 0x0 0x18000>; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel