From mboxrd@z Thu Jan 1 00:00:00 1970 From: ray.jui@broadcom.com (Ray Jui) Date: Thu, 24 May 2018 09:42:20 -0700 Subject: [PATCH v3 2/6] Documentation: DT: Add optional 'timeout-sec' property for sp805 In-Reply-To: <20180524161628.GA28425@roeck-us.net> References: <1527120924-12131-1-git-send-email-ray.jui@broadcom.com> <1527120924-12131-3-git-send-email-ray.jui@broadcom.com> <20180524161628.GA28425@roeck-us.net> Message-ID: <621dc488-2d8d-003b-9bd1-4de59e8d178b@broadcom.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 5/24/2018 9:16 AM, Guenter Roeck wrote: > On Wed, May 23, 2018 at 05:15:20PM -0700, Ray Jui wrote: >> Update the SP805 binding document to add optional 'timeout-sec' >> devicetree property >> >> Signed-off-by: Ray Jui >> --- >> Documentation/devicetree/bindings/watchdog/arm,sp805.txt | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/watchdog/arm,sp805.txt b/Documentation/devicetree/bindings/watchdog/arm,sp805.txt >> index 0fa3629..1debea3 100644 >> --- a/Documentation/devicetree/bindings/watchdog/arm,sp805.txt >> +++ b/Documentation/devicetree/bindings/watchdog/arm,sp805.txt >> @@ -19,6 +19,8 @@ Required properties: >> >> Optional properties: >> - interrupts: Should specify WDT interrupt number >> +- timeout-sec: Should specify default WDT timeout in seconds. If unset, the >> + default timeout in the driver is 30 seconds > > "... the default timeout is determined by the driver" might be better. > If you want to mandate a default here (not sure if that is a good idea), > I would suggest to use something like "should be 30 seconds". > Okay. This can be changed to: - timeout-sec: Should specify default WDT timeout in seconds. If unset, the default timeout is determined by the driver. Please advise how to proceed with this patch series. Should I make the above modification and send out v4? Thanks, Ray > Guenter > >> >> Example: >> watchdog at 66090000 { >> -- >> 2.1.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in >> the body of a message to majordomo at vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html