From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0845FC4708E for ; Tue, 3 Jan 2023 23:46:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lLT0aY4mwDVQX6rzmvHGg2Wm//1KAgCx/1isi5Yx588=; b=RocQ4yxpXYPfPd Fpu1jmcpHMEVMS8YIR8nVO/7eyIp4I5BQoHhkxrXG7CJGELH3xFzPyqpm+wI6DOGQ8CAdqee84WOg b71sN+vy1TWXFStwLFLd+PIzOuqvOZy+7OuNRcqF3msyD87pes7mO5UYWeTKLceCFjLb84RoW28dv yHgQuw7vS04hj1hEKqFRpigv7KLhjOZnGvRszFM01H5QVQNKjKbx8AfwVdg49767WmeJWBFBnm2NF 8ybiGs3mJB3gx0sP2zWgD4erPzpJ148dZVxgHvwTMbojUt/ZgdGQTjKkzJ4Z2GgWhYXKNV6W00Y2f DoaZLUvaVkbNbd8HqdZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCqxj-005hOO-Lp; Tue, 03 Jan 2023 23:44:55 +0000 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCqxK-005hHO-3J; Tue, 03 Jan 2023 23:44:31 +0000 Received: by mail-pl1-x62b.google.com with SMTP id d3so34271964plr.10; Tue, 03 Jan 2023 15:44:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LaFAJPBxUs0E/Exgk6u6HlWrifjA97P1gQt2bFLEyIY=; b=UOgMbhsfwVqIP1zllGJ5xDuwBuOs9aE6hGfpWVf0tIqKcVrCfFR3cAHFdqkwGaYotM 7pkPo+DmljBwMxEUlJLMKiFGhZahdVRlqEJM5R4Ik/NljdkozhTWo4hW60q8iUojTQHI PhsVflM4ZkJlOD7oKrLORcRSnJkKGpykaSjxn+29fN/UddPvnUfUSSfYwRN5F2LtoDBy cw7D95pxemMNcvUdCDMekRF9+2TX752otnGbLbnCd9vcWAwKPGthklMQ0mBEe+BMvy6T EnDrRze3azTBETfEN2HIHCq3NjlDIfDhkKoO4/xoR/OpdEF9a6br4qEAf/W32bam+1Cb oWOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LaFAJPBxUs0E/Exgk6u6HlWrifjA97P1gQt2bFLEyIY=; b=URHi7eSiaU4FKowDnBRLTeehV7j3w4ec/DFU/Od2a66Era29BUn9dFiILJtkBgo27w O44gy8A0n29WzsczHKnboeJNySfrq8iTJ7SpnbjSqyg+j0Pd/+NfsnQ4WdsGwY5HOUmS x/8M6rCPm1kAaxsZgXF8tLIazgjMdZ8Mm+PpQV1j9eTvb0OF45cELz5K6zCBqVO3j9CA FtKkrrYpupb8OsivMCequ6qA0eJceIqq81LDQ5wl9l1ZEaLnNCHS8a/+dkzLGtU6yapM qigpVKnJMtNb9GgyYAQxJL78QLZ3wQRar2nsdhEuypVH5H1PfKmH4Ayiy9o2Swjx0yW+ ARKw== X-Gm-Message-State: AFqh2ko3lDpwxjfbdp/W/27eEV0r1FNlQYUCIgHCHNFMT04LgTg+BI/k ZIZ78+dSmtuJUqqd/g4EXDg= X-Google-Smtp-Source: AMrXdXsVOvYV0YOSEhvEH4adlUXLbY7X0A4ueQ+zZnd9HQyXZdWMolWMQ3m4j+EO3vj+QmbYD6gnRA== X-Received: by 2002:a17:90b:198f:b0:226:28aa:eb17 with SMTP id mv15-20020a17090b198f00b0022628aaeb17mr21795861pjb.11.1672789466740; Tue, 03 Jan 2023 15:44:26 -0800 (PST) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id d31-20020a17090a6f2200b00223f0592e81sm16301325pjk.4.2023.01.03.15.44.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Jan 2023 15:44:26 -0800 (PST) Message-ID: <622412ca-aee7-2e57-f9f6-3ff9871c5190@gmail.com> Date: Tue, 3 Jan 2023 15:44:24 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH RESEND] firmware: raspberrypi: Fix type assignment Content-Language: en-US To: Maxime Ripard , Florian Fainelli , Ray Jui , Scott Branden Cc: bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, kernel test robot References: <20230102115255.17802-1-maxime@cerno.tech> From: Florian Fainelli In-Reply-To: <20230102115255.17802-1-maxime@cerno.tech> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230103_154430_261214_7A4DCFC6 X-CRM114-Status: GOOD ( 14.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/2/23 03:52, Maxime Ripard wrote: > We silently cast an unsigned int into a __le32 which makes sparse > complain. Moreover, we never actually convert endianness between the > CPU's and the expected little-endian value. Fix both at once by calling > cpu_to_le32(). > > Fixes: 40c31955e4e9 ("firmware: raspberrypi: Provide a helper to query a clock max rate") > Reported-by: kernel test robot > Link: https://lore.kernel.org/r/20221116091712.1309651-3-maxime@cerno.tech > Signed-off-by: Maxime Ripard As soon as v6.2-rc1 is cut, I will pick this up, thanks Maxime. > --- > include/soc/bcm2835/raspberrypi-firmware.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/soc/bcm2835/raspberrypi-firmware.h b/include/soc/bcm2835/raspberrypi-firmware.h > index ab955591cb72..73cac8d0287e 100644 > --- a/include/soc/bcm2835/raspberrypi-firmware.h > +++ b/include/soc/bcm2835/raspberrypi-firmware.h > @@ -170,7 +170,7 @@ struct rpi_firmware_clk_rate_request { > > #define RPI_FIRMWARE_CLK_RATE_REQUEST(_id) \ > { \ > - .id = _id, \ > + .id = cpu_to_le32(_id), \ > } > > #if IS_ENABLED(CONFIG_RASPBERRYPI_FIRMWARE) -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel