From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C782FCE7A81 for ; Mon, 25 Sep 2023 12:19:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oJ1B+ktsTQskIDM8aKR0iiHR62BWcmYXGUjViSFrWIw=; b=gco2mRwHZAMNqx CXOkwt8ozcGCxVC4BaM+VvF9c/AamQhEEr4pHH4lRMgKmDYuqiLmzbxptrLk9/s5X2x82tGQdP7c5 yfL51XT6nlzuJocg3r7oGw7sjCHVzMvqY0+3vFvpXM1Nx2GmSYUO6hkc/n9s16E4eqK3H3jRfsUXZ dfYroWix8AeMfpG1pBoU0+w26rTLsOYD7hWRiJMCpVBP+7ed9GmIajbBNbGDT4Jd7nL1G/Ip46lfW Vfh1+Eh04Cbt1aWl/6WYNplADOhAZyW0m4lBJW/z3SJc597MTJUu7E3lIsms4X+SVd8cgpQPOnaHu PATy22SZeh+UQXa5Q5uw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qkkYK-00EF1s-06; Mon, 25 Sep 2023 12:19:04 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qkkYG-00EEzk-0y for linux-arm-kernel@lists.infradead.org; Mon, 25 Sep 2023 12:19:02 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-405505b07dfso24068035e9.0 for ; Mon, 25 Sep 2023 05:18:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695644333; x=1696249133; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QpHP0gjZZ+jc1OAptTHEyzuPC8yYPxjo1qi8MGdPaIY=; b=KS2PDaId0rNmOvSuJkdaDvDDTD/9oZDd2oqGnSIsTY5iMGAoAxBRx2pYFexbxeNnMU 7wDS8Z+ZmQT9njtklBYxODxVFepwWSIjE9dBOYfOSw7gxKItHMPllRO7QllhcFDPcuH6 yS4VV91E7LHEjMToeM2MdftMf+0s4Xeuc48M2TDSYyu/c26I46StR4eTpx60wrQdgkoI Tt2GEv5UZ7sptivs/HeV0Gkrxym/Dm2b/0RZ5nBs9pg0vpDabxERB00F5FsiSjF+l25S BPr+e/lESGUITkTEMexxBnY/mWaTsRvOM3d/4TDrGQugxqpUXuzOT7fHLaqQndGTcXT7 eR+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695644333; x=1696249133; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QpHP0gjZZ+jc1OAptTHEyzuPC8yYPxjo1qi8MGdPaIY=; b=tr9VIyhpOjpgNsc/DpOWBQT1uJRvl1bLhBem1Iu3heKjO08lEa9MqgvOdJk7/oORkF eUJtwbiOuuPCOuTXnNH06bMT4Sxhj/lR685Y9QjTammRiGaMVHq+8XJEPCYtSbzeOhcT YxpAWtNG4+0PB0/RzjtOcY2kCPRcYK2GI6eMkbURnYruZCyiWakVeTBVOMgl7zXwydtA 9+yZFsBU+SdTTKAjBVUBVdWDDaC0fBd7Fy32jLhfMw8m6hWBzrGJxNMCY3KLRUdtJTK9 IZsF+5IY0R/O4/2COTKhLfRrBlfkXLjRgK3/LHg6GVrvfrQH0RLJQrZYAjv5UaZE6R9S Fjeg== X-Gm-Message-State: AOJu0Yzy1+bO5liMEXS+ljfTPoWTHYvb849NeOL8JMcDkZuk1y1qawVv lcTshxqJRTDYgVbj1o4MMysOxCc6WdwsLNbhpgZ6Kw== X-Google-Smtp-Source: AGHT+IHrPi2LM0A+JOTQ15e6//++oAczdtZHV4J+jHAxcEA4WLivxDqwPJrKvih9F9TC8lgmR2L8pQ== X-Received: by 2002:a05:6000:1e18:b0:323:2288:40ef with SMTP id bj24-20020a0560001e1800b00323228840efmr3530120wrb.14.1695644333441; Mon, 25 Sep 2023 05:18:53 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id n3-20020a05600c3b8300b004053a6b8c41sm10408693wms.12.2023.09.25.05.18.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 05:18:53 -0700 (PDT) Date: Mon, 25 Sep 2023 15:18:50 +0300 From: Dan Carpenter To: Umang Jain Cc: linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren , Greg Kroah-Hartman , Florian Fainelli , Adrien Thierry , Dan Carpenter , Dave Stevenson , Kieran Bingham , Laurent Pinchart Subject: Re: [PATCH v11 1/5] staging: vc04_services: vchiq_arm: Add new bus type and device type Message-ID: <62363da5-39c4-40f2-bfca-fed182845eb8@kadam.mountain> References: <20230913195354.835884-1-umang.jain@ideasonboard.com> <20230913195354.835884-2-umang.jain@ideasonboard.com> <700e11e4-057d-78ed-8b52-dd2df97198bf@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <700e11e4-057d-78ed-8b52-dd2df97198bf@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230925_051900_365297_D72B5C92 X-CRM114-Status: GOOD ( 18.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Sep 23, 2023 at 07:57:51PM +0530, Umang Jain wrote: > Hi Dan, > > On 9/14/23 12:25 PM, Dan Carpenter wrote: > > On Thu, Sep 14, 2023 at 01:23:50AM +0530, Umang Jain wrote: > > > +static int vchiq_bus_type_match(struct device *dev, struct device_driver *drv) > > > +{ > > > + if (dev->bus == &vchiq_bus_type && > > > + strcmp(dev_name(dev), drv->name) == 0) > > > + return 1; > > > + > > > + return 0; > > > +} > > I was not going to comment on this, because it's unfair to nitpick a > > v11 patch... But since you're going to have to redo it anyway, could > > you make this function bool and change it to return true/false. > > > > static bool vchiq_bus_type_match(struct device *dev, struct device_driver *drv) > > Perhaps the return value can be true/false, but return type should always be > 'int' > Oh. Sorry, I didn't look carefully. Btw, you don't need to tip toe around telling me I'm wrong. Just say "That won't compile, dummy." I'm a big boy, and I can admit when I make mistakes. ;) regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel