From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org From: =?utf-8?B?SmFzb24tY2ggQ2hlbiAo6Zmz5bu66LGqKQ==?= Subject: Re: [PATCH v2 3/4] dt-bindings: soc: mediatek: pwrap: Add compatible for MT8188 Date: Mon, 17 Jul 2023 12:00:14 +0000 Message-ID: <62399eb4be7e0f5933e991e017e9df4ded9c5eed.camel@mediatek.com> References: <20230711023929.14381-1-jason-ch.chen@mediatek.com> <20230711023929.14381-4-jason-ch.chen@mediatek.com> <84847777-bad0-0aff-5279-9b80fd95c2d5@linaro.org> In-Reply-To: <84847777-bad0-0aff-5279-9b80fd95c2d5@linaro.org> Content-Language: en-US Content-ID: MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+lwn-linux-arm-kernel=archive.lwn.net@lists.infradead.org List-Archive: To: "matthias.bgg@gmail.com" , "krzysztof.kozlowski@linaro.org" , "conor+dt@kernel.org" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "angelogioacchino.delregno@collabora.com" Cc: "linux-arm-kernel@lists.infradead.org" , "wenst@chromium.org" , "linux-kernel@vger.kernel.org" , "nfraprado@collabora.com" , "linux-mediatek@lists.infradead.org" , Project_Global_Chrome_Upstream_Group , "devicetree@vger.kernel.org" Hi Krzysztof, On Tue, 2023-07-11 at 08:07 +0200, Krzysztof Kozlowski wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On 11/07/2023 04:39, Jason-ch Chen wrote: > > From: jason-ch chen > > > > Add MT8188 PMIC Wrapper compatible to binding document. > > > > Signed-off-by: jason-ch chen > > --- > > .../devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml | 5 > +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git > a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml > b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml > > index a06ac2177444..c2f22e7dbcfb 100644 > > --- > a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml > > +++ > b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml > > @@ -50,6 +50,11 @@ properties: > > - mediatek,mt8186-pwrap > > - mediatek,mt8195-pwrap > > - const: syscon > > + - items: > > + - enum: > > + - mediatek,mt8188-pwrap > > Why do you add duplicated entries? Test your DTS before sending > patches. In the next patch, I will remove the duplicated part. Thank you. > > > Best regards, > Krzysztof > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel