From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] NVMe: add explicit BLK_DEV_INTEGRITY dependency
Date: Mon, 23 Feb 2015 11:08:50 +0100 [thread overview]
Message-ID: <6241161.LKiT8yUlIj@wuerfel> (raw)
A patch that was added to 4.0-rc1 in the last minute caused a
build break in the NVMe driver unless integrity support is
also enabled:
drivers/block/nvme-core.c: In function 'nvme_dif_remap':
drivers/block/nvme-core.c:523:24: error: dereferencing pointer to incomplete type
pmap = kmap_atomic(bip->bip_vec->bv_page) + bip->bip_vec->bv_offset;
^
drivers/block/nvme-core.c:523:49: error: dereferencing pointer to incomplete type
pmap = kmap_atomic(bip->bip_vec->bv_page) + bip->bip_vec->bv_offset;
^
This changes the Kconfig entry for NVMe to depend on that
support, to avoid the build error. Using 'select' would work
as well, but might have unintended side-effects when users
do not actually want the integerity support.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: e1e5e5641e6f ("NVMe: Metadata format support")
---
Found on ARM randconfig builds
diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
index 1b8094d4d7af..e386dd5b94e9 100644
--- a/drivers/block/Kconfig
+++ b/drivers/block/Kconfig
@@ -312,7 +312,7 @@ config BLK_DEV_NBD
config BLK_DEV_NVME
tristate "NVM Express block device"
- depends on PCI
+ depends on PCI && BLK_DEV_INTEGRITY
---help---
The NVM Express driver is for solid state drives directly
connected to the PCI or PCI Express bus. If you know you
next reply other threads:[~2015-02-23 10:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 10:08 Arnd Bergmann [this message]
2015-02-23 16:01 ` [PATCH] NVMe: add explicit BLK_DEV_INTEGRITY dependency Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6241161.LKiT8yUlIj@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox