From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35742C07CB1 for ; Mon, 27 Nov 2023 12:34:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m5Q5Ib9Al/gItYI7R5jnYLwjG2zN0DKtCvd5yLfSpM4=; b=aO3Ou8CGrc/sjF t9C3IDcTrK/5jg7bMWaNf+BD1Qu4+vrocWA/mD4jZN3BNBndojbRl9xp13TfoeggKGzn/wVaeIo65 UyQ0Ds5EJqKfX39EPcH4HgymL3jTTEjEZ9Q2A2edyQzpPy/bfR5odE5zzDFndOZxpvSNaTcGRDrRs 8kJbdtC4lJ999gRVVJpOKjWZvrPoCXeytd9F6gryCxQnECRx2+WsiwkIWOve6RUXMvE8jyAeiaUvK snwr1l7GuuwgMa7SAdmRYu14RWhkhzQ/yFxYb28+jnL/sEFdsKQVufDOnKV+RrSnavDD/dbEywKOy mJyYfb7G2XBXYMIMgAYA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r7ao0-002Sh3-2h; Mon, 27 Nov 2023 12:33:40 +0000 Received: from mout.gmx.net ([212.227.17.21]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r7anx-002Sfh-1R for linux-arm-kernel@lists.infradead.org; Mon, 27 Nov 2023 12:33:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1701088400; x=1701693200; i=wahrenst@gmx.net; bh=nxlyVf/kBLvAr9KUBeBeC3yNs6JtXqImub1VWLvYG8o=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From: In-Reply-To; b=ZNHpEhlJAW94QYR/sVO82BhbvcZNdewE6Ed+Qmmo5cg74JyDm9SnHeSPyijBoXEE CBpLSqNmtROmN99zvfDvxUiCIcuSw++tf0eYEA5Ip+tefx2tdYUISj/CfQR65ACo2 OcBX39UIoMIsNKsKOU3FyNPfYLU/I2HvGgJ5yizKAcAmqPMSPq7jpeEUMe4S77K94 OS8r1oc91R/UUIln7GoyIuU7/l/q386Ys5wcJ1HJVt4NGK99OqaMtFg71SqO0/NOB 7ugaGoDRbYUSSew8UJgzFlkDXFSLEmYlm1PugoMTRJFymawva6AGBUjrDoklmlhaJ gOyflmI15ItNA94u2A== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.129] ([37.4.248.43]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MG9kC-1r4KcO1zga-00GdMp; Mon, 27 Nov 2023 13:33:20 +0100 Message-ID: <624b79b1-f2dc-4f2e-a225-d1623d905b19@gmx.net> Date: Mon, 27 Nov 2023 13:33:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] ARM: dts: bcm2711-rpi-cm4-io: Enable xHCI host Content-Language: en-US To: Phil Elwell Cc: Justin Chen , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Mathias Nyman , bcm-kernel-feedback-list@broadcom.com, Cyril Brulebois , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20231126025612.12522-1-wahrenst@gmx.net> <53e1f6e6-a28e-45af-991e-75b283a21b34@broadcom.com> <46320840-09ab-4c86-90c9-bee7b75f248a@gmx.net> From: Stefan Wahren In-Reply-To: X-Provags-ID: V03:K1:tQO5FM+1X6vOvoNaL1rMeBrgfEEmIOTmByWDEVozrxnx4+A9LVV WNJJMXGBE4xZqEr5k3hOCkXc+GC5EWltyOtQMI5sbnoxkJwexGj4nfsIg4yjP5Wx1P2ur5x tb9NnqrSNBkJQ+LbwYSEUnoC16wZ9PY9D4vY/zgKZg9RRkFqKjfqvBgNllP3+pbk61Jq8v5 TSC6km3BaxjkVkIRIkkCg== UI-OutboundReport: notjunk:1;M01:P0:7pgJlwopdF4=;PJ9V0QnSTifn5hmUIi7nBBsNC0R adL1nkFKsi+H39m6mg7U+XtVuwzCh2sgB+qXrFWX/izMBAtTZgwtsPg4FmWd8DTXHIFTMxQPn TEQTHMMGUu8gz5lNokhZ89GhBRrmeV6Uswk7e8SPA3MfqrRwHZP8EWY1jo7pCKB+77oTMmMbX Gb1YG9uVGEjTaLGvwrLuNoIElG5f6qbpfFiwOfwyZS4KiXs41oGgqQLtAnlz9PYippsO0Nz/D h8ngijKjKHywjP1b1Ud+Pt/NtjZ+mX9F4SsnsZY8K2/1ZJe8O2aaml+bluuadUHnApyqQmwey IMZZn8ADv6XA2HRPlYETWRpeGZjapmT6g2FR5+UZNu4lhyoTiINvvvq8P0I/Os3bNYCeH2D7X 5RvgsyEsTrDDlJuEUZnAMeXFggSmaSYWCUI3DJEP3seGcl7OEtez1RofraBAlG3kr9m3sHyN4 OPSmb9E0D//T9XFYwdj03pjDwhuc1ATWM8Vz4M6moAz3sWgNjdhxl7IGlM7BNNcBe7iB49M+D KvuAUsDpkzaVoi10CpVOYwWy7hV60LLUjOwjuIE9Pq7DQ6p0wFEmiqTNMBKLcG6J636GJ7qvj 0Hkfs5L7soeMYQO1tzdALTPV/y5UpIPvP8VRPT0Xtdw90rfNK0a9rKhL7wPWI6KEl2P7/Ny/Q 1MV1iG4oeoIOj7dcKAQP0dGNogjzP3aX75eICUK5FkvUuMi7O2ELOqyL2fSrbsryRkhT6Y2+p mi2qYV/FKP2q6GqzJKtcaJiUYMbHr/l6SdP3O1h4TNMJcHJb+ClBAtISlvt2eA+Cj3mdeBriK vIRXeQUe4pljg4sVWekpguHypkkZw8v3/6/Uq3/sbKQ8Fhz8KHdgvl8O1hu1pXdEwg8Sl526E WE3L/OAjhIiRiN9LW6zGQxiZqzxwjpI7oIJXuqCZgYx0Zk0Xn/24C/FEUFGy4akkPctyilgcO 6UAORFkc3Hne4jaVXLNasKkkb9E= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231127_043337_793587_F0D6519F X-CRM114-Status: GOOD ( 15.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Phil, >>>> Hi Justin, >>>> >>>> [add Phil] >>>> >>>> Am 27.11.23 um 07:02 schrieb Justin Chen: >>>>> On 11/25/23 6:56 PM, Stefan Wahren wrote: >>>>>> In contrast to the Raspberry Pi 4, the Compute Module 4 or the IO board >>>>>> does not have a VL805 USB 3.0 host controller, which is connected via >>>>>> PCIe. Instead, the BCM2711 on the Compute Module provides the built-in >>>>>> xHCI. >>>>>> >>>>> Does this work? I maintain this built-in xHCI controller internally. I >>>>> wasn't aware the Compute Module uses this block. >>>> i successful tested this with a CM4 (arm 32 bit, >>>> multi_v7_lpae_defconfig) with eMMC. Before this series the USB devices >>>> (mouse, keyboard) connected to the host interface didn't work. After >>>> comparing vendor DTS with mainline i noticed the missing xHCI block [1]. >>>> Unfortunately i wasn't able to get further information from the public >>>> datasheets. I don't know if the VideoCore does some magic tricks on the >>>> xHCI or i missed some downstream xHCI changes. >>>> >>>>> This block is held in reset and needs a bit toggled to get things >>>>> going. Florian, just to confirm, this is our "brcm,xhci-brcm-v2" block >>>>> correct? >>>>> >>>>> Justin >>>> [1] - >>>> https://github.com/raspberrypi/linux/blob/rpi-6.1.y/arch/arm/boot/dts/bcm2711-rpi-ds.dtsi#L119 >>> What's the question here? Does the XHCI block present in the >>> raspberrypi/linux dtsi file really exist? Yes it does. >> since i don't have any documentation about the xHCI block, i assumed the >> compatible generic-xhci is correct. But Justin seems to suggest that the >> xHCI block needs some special treatment and we need a specific compatible. >> >> Did i missed some xHCI driver changes? >> Does the VC firmware something to the xHCI especially on CM4? > The firmware switches the on-board USB pins from DWC-OTG to XHCI if > otg_mode=1 is set in config.txt, or if booting over USB MSD. is this pinctrl/pinmux available from ARM via 0x7e200000 or a different IO address? Thanks > This also > triggers the enabling of the node with the label or alias "xhci". > > CM4 is not handled any differently to the other 2711-based devices in > this regard. > > Phil _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel