Re: [PATCH] ARM: hisi: Fix refcount leak in hi3xxx_smp_prepare_cpus

From: Wei Xu <xuwei5@hisilicon.com>
To: Miaoqian Lin <linmq006@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	Kevin Hilman <khilman@linaro.org>,
	Haojian Zhuang <haojian.zhuang@linaro.org>,
	Zhangfei Gao <zhangfei.gao@linaro.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <xuwei5@hisilicon.com>
Subject: Re: [PATCH] ARM: hisi: Fix refcount leak in hi3xxx_smp_prepare_cpus
Date: Thu, 12 May 2022 11:09:27 +0800	[thread overview]
Message-ID: <627C7A67.5020804@hisilicon.com> (raw)
In-Reply-To: <20220512025839.50333-1-linmq006@gmail.com>

Hi Miaoqian,

On 2022/5/12 10:58, Miaoqian Lin wrote:
> of_find_compatible_node() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when done.
> Add missing of_node_put() to avoid refcount leak.
> 
> Fixes: a9434e96d9f0 ("ARM: hi3xxx: add smp support")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
>  arch/arm/mach-hisi/platsmp.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/mach-hisi/platsmp.c b/arch/arm/mach-hisi/platsmp.c
> index a56cc64deeb8..15e63b72df3a 100644
> --- a/arch/arm/mach-hisi/platsmp.c
> +++ b/arch/arm/mach-hisi/platsmp.c
> @@ -68,13 +68,16 @@ static void __init hi3xxx_smp_prepare_cpus(unsigned int max_cpus)
>  		ctrl_base = of_iomap(np, 0);
>  		if (!ctrl_base) {
>  			pr_err("failed to map address\n");
> +			of_node_put(np);
>  			return;
>  		}
>  		if (of_property_read_u32(np, "smp-offset", &offset) < 0) {
>  			pr_err("failed to find smp-offset property\n");
> +			of_node_put(np);
>  			return;
>  		}
>  		ctrl_base += offset;
> +		of_node_put(np);
>  	}
>  }
>  
> 

Thanks!
But a similar patch[1] has been applied.

[1]: https://www.spinics.net/lists/arm-kernel/msg975425.html

Best Regards,
Wei 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel