From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3402BC4321E for ; Sat, 3 Dec 2022 00:24:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GnRRLACskxPfVNDtH4cIAvDO+33jpg+C4tUKiq7PCxU=; b=LW8bEVIeQ3us5k fXf7Q07Z01NYOLVYXzX16bf5CWCWRePTZZu2mF2k6SL8vDgAwH8pXIyfDCTaeYdOb3ADMzW1I1j2c HaZ5FL6iSWeDh7t4WDteqTPKXg3umH8++yMrFEPfDBa/je7cZXaGYm96rR1aDNDxKmbBxROMXIQv6 Gq4FzR++3q+Oi53s8v5UpTSiRApyWXXkpvNfTNgljl1VGBHL8AR2Pm1H2SHszp49X36/nGvdgV95w wPPEfq97tOV6ylnxQoGglxO5Qn3uP1tRHS+JTdkA2RSfW4XjHFuq3kn9RO4KGWot1aq8K/JGAYNy8 Bi6AdFCq3Z3dSXyhKUSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p1GJe-001nNu-Oi; Sat, 03 Dec 2022 00:23:38 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p1GJY-001nLm-MB; Sat, 03 Dec 2022 00:23:36 +0000 X-UUID: 3bcd317a5d244fd19636ca8258e850d5-20221202 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=XznkicVyGkT9bzO3F0ruKdOeVg4M411Zp+706t9sI98=; b=nxSVqP/luhPPQsDTaV1i48unSb8ImkeSjj27Z6HzkVn5lu378ljP6KgtFOTeR82JhOWAiaAWe+x80hIHIzo5mKRE+1vRyYwc++LYM/az/sig+RVgl4KfC3lQp7lPn4rgqv9fKPIhzN5i1S0elNokrs0RUCIUCTuH1uL0nVrPlx4=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.14,REQID:e8649889-6ada-4b35-b1ee-9e6f9bb1ca23,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:dcaaed0,CLOUDID:1d616c6c-41fe-47b6-8eb4-ec192dedaf7d,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:1,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0 X-UUID: 3bcd317a5d244fd19636ca8258e850d5-20221202 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 2138358147; Fri, 02 Dec 2022 17:23:16 -0700 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Sat, 3 Dec 2022 07:42:39 +0800 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (172.21.101.239) by mtkmbs10n1.mediatek.com (172.21.101.34) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Sat, 3 Dec 2022 07:42:39 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZcTeH4CT0gfU8NZGnzHSyVhBnBO/fW5gf9/0WucREvQ5xbDGnm9aUUtIzyKqCKNKZP8Jpo+l2MlPMTCDSR9lS6LNjRkQm74SlgzT9EmGPw5H1eukQ8BYQy9uaF8q0yd7Jx4KLlh5ejOMqV8/dnp/zj8SN5k8vbpcb5z91vDBHEbwZL7IUWE1PVl8x1Tz5kgmAQLluSGwkPfSN3PzYPQOl8uHr9VWYaS1zLVt/Xfd5eez6C/GprKQxwN/BFMLNVxtH+MMV2vlkkQpOPMbOce/LR5ZZZhWl32Jrpo8hXk3Y4qqZUqaixRVNH9fIqVEn4iQ8AdCo0B+H3W4qcC2sWwI+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XznkicVyGkT9bzO3F0ruKdOeVg4M411Zp+706t9sI98=; b=GIBBh53u1X2zWj3nxq7VcXEH61mgDKUmaqwjVGUgV4UcVY9R+qQPxKNJ8BSkDqr2xHFrEfhGGrEgOftlAIRd8jE9Lnd3bfIes8d/ksxEUUxYcSkYPKmyKTeZ6MYkyi6MV02t3tMRO8YiyOaMHXD2q+fDnXFgz70e1n7nvLIeZTixkF2fWwddz1ZjnlW1ycZsLbRjjmfg+0W5hcBE+HuD2c/jZZVSYxl4Wo6GKOrLXBXCsM0+VzdG0GnkaIFGDZRRby604dDOoUsR4A4IExEHc9t/LsEhNK37u8HwWVnEtqJdF8E7fKbGpxqlybuzA9UF9GTh5CHKT3nG25x+2KbPcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XznkicVyGkT9bzO3F0ruKdOeVg4M411Zp+706t9sI98=; b=OpETVxftf9Nbv7rPxXaHWj/mzcFEy+7mUrEqwj5JEQUM+hzL817XVrqGIsTK7TO0lnW+lZED5SeNvKKuzrZyygdhnbIlMv+ZQA3tJoUY4uvg5214auwV+j8bkp9Xjz4NXCSBceCZ94ZIEBDL1mzwMzxW9QF46Hl6wKDMcDiLDIs= Received: from TY0PR03MB6354.apcprd03.prod.outlook.com (2603:1096:400:14a::9) by TYZPR03MB7027.apcprd03.prod.outlook.com (2603:1096:400:331::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Fri, 2 Dec 2022 23:42:37 +0000 Received: from TY0PR03MB6354.apcprd03.prod.outlook.com ([fe80::320d:30ac:41ac:b1a3]) by TY0PR03MB6354.apcprd03.prod.outlook.com ([fe80::320d:30ac:41ac:b1a3%5]) with mapi id 15.20.5880.010; Fri, 2 Dec 2022 23:42:37 +0000 From: Ryder Lee To: "keescook@chromium.org" CC: =?utf-8?B?TWVpQ2hpYSBDaGl1ICjpgrHnvo7lmIkp?= , "linux-kernel@vger.kernel.org" , "gustavo@embeddedor.com" , "linux-mediatek@lists.infradead.org" , "linux-hardening@vger.kernel.org" , =?utf-8?B?U2hheW5lIENoZW4gKOmZs+i7kuS4nik=?= , "nbd@nbd.name" , "lorenzo@kernel.org" , "kuba@kernel.org" , Sean Wang , "kvalo@kernel.org" , "edumazet@google.com" , =?utf-8?B?U3VqdWFuIENoZW4gKOmZiOe0oOWonyk=?= , "pabeni@redhat.com" , "linux-arm-kernel@lists.infradead.org" , "netdev@vger.kernel.org" , "linux-next@vger.kernel.org" , "matthias.bgg@gmail.com" , "davem@davemloft.net" , =?utf-8?B?Qm8gSmlhbyAo54Sm5rOiKQ==?= , "linux-wireless@vger.kernel.org" Subject: Re: Coverity: mt7915_mcu_get_chan_mib_info(): Memory - illegal accesses Thread-Topic: Coverity: mt7915_mcu_get_chan_mib_info(): Memory - illegal accesses Thread-Index: AQHZBp97nbgv/Go0Rk6e4OypxWDzN65bNVOAgAACYoCAAAqLgA== Date: Fri, 2 Dec 2022 23:42:36 +0000 Message-ID: <6285b967a37d7f641b13ba73c10033450ee8ea7f.camel@mediatek.com> References: <202212021424.34C0F695E4@keescook> <1a16599dd5e4eed86bae112a232a3599af43a5f2.camel@mediatek.com> <202212021504.A1942911@keescook> In-Reply-To: <202212021504.A1942911@keescook> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mediatek.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TY0PR03MB6354:EE_|TYZPR03MB7027:EE_ x-ms-office365-filtering-correlation-id: f1f4595b-9961-4beb-093d-08dad4bee42b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4hTywygS7DNdRaDL4l83RdEpNocwne2nswxnfovMzZwmEtouiYykrG81khbGiX+aR63SQZ1e7wOlgfRR9Ns15n8eEAnGJPxHHssOnQw9NQ6yOb9IyKgkPnMyV4pkcMlJZI9uZfLrDnrbH9iBnYe9Ppg8LBIEMFrkLF/UOd8GXjxNPqYO3AOK22gdmBdF8fq15yivz0MZd4MN2f0siBgnrsyiHKwjeLy1icLhPuKwJIP03hOxX8R53Y7CwTVU3W0YSSl291+7vIckixPr9LzYEpsJiM4xgo2mxDdnOqUQpEA3DhPHer8F3cc996ShpVouvQ0tIxwQgpQCIrKxdmP1V7JHFF7wU9UuyUbMFLtmjkYTg8YG8UkwP+zNCHyHgLFpZ0XA2DHK/nJu3DLvOoOcAYE0zAua5O0ab9yaSb1rSas7GtELw5FwiJpBnFtG+wh+Q+QGlDrIlgisDMXF0eHPJX9DTZSckV/Jqux7cEiYGQXw1hdaaRLUc5RP/YxxwKxWK9LmbCeEkzOnVjPjEi1EJaTIjOvU/YJSkaWMd+q/l6VENgDzXY6rgf2sZPTKBQGM8p0ceHvSTigGhfgrEpIwpDxYB8iTCmksM9zEVjI6mgFEXn4pHWjp3c/zaaQ7dm9yzKbOtvzesqN7FAL16r1n6O4kKA8tGeYdCtBLCj3+B8cKMs51uHcJi3WSbLr+v0wm3G/NY1/82jz9cgDEm+trMqxNMteS2y52pOLk2/hhZfk= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY0PR03MB6354.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(376002)(366004)(136003)(346002)(451199015)(36756003)(83380400001)(8676002)(2616005)(76116006)(316002)(6486002)(86362001)(38070700005)(38100700002)(66556008)(7416002)(64756008)(2906002)(41300700001)(54906003)(4326008)(6506007)(8936002)(186003)(966005)(6512007)(26005)(5660300002)(478600001)(91956017)(71200400001)(6916009)(66446008)(122000001)(66946007)(66476007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UXZkTTRnOHhqSGw3YmVHblBSQndCOHdjcWQ0RW51Rms0cTlnL0tBS1MxNncw?= =?utf-8?B?ZzVIOEVRYnlkZ0lMN0twb2J2azVLRjU4eGluV1hDck5KVDZ4cGZzN3p6QjNi?= =?utf-8?B?bk10ZUdrdlNnWWNqQTByNkl5aENhNFR6MGY1VHlLMTAyaWxscko4T1A1ZTlH?= =?utf-8?B?VHFCZ0R2cmNpdk9wNS9uVEFJSEZuUEVBV3hla0M5VFhVRTZyUWZYcW9oS2pW?= =?utf-8?B?YVFHRVhCTCszODYzUnZCbGluMmhYVVVuKzdFOHdQdU1uUjVlS01Oc2txdUFn?= =?utf-8?B?RHdUZmg5ZXZXZG16OENjc1JaOHUwSDM1RktDTzhwZ1BCeHdrbDFUTm1nRFVp?= =?utf-8?B?U1lPS3lVM2dmcUlGRXhxanV4M0pmMVdYNE5scDRwTHlzMnBvUy9uZzFhcFFF?= =?utf-8?B?N0F4OEIxK3hlNkppZFRtRldsQUtNTTJiTCtxVzFUYzhaU3p4c082Wm93SVRp?= =?utf-8?B?UjRXVW5zbDlNb1dZOWYyYTdwQ3k5RHNvY2lDbkphZU1US0Q2d29wcEVaL1lH?= =?utf-8?B?ZjVUQWdwaW5JRnhGUk1MZkhjMU93NHFhbDlJeDNEbFIyOGd4b052emlvVVcy?= =?utf-8?B?Y3lkZE5NUE1MRjJwMWdLaDNLcE5UZ0FJTkFLUlBscFpOREdzRVlGK3FXbHBa?= =?utf-8?B?U0tVbkdWUGt3NXFXQnorK0JDcGxJRjZwRlJSYlFpdWtmb2VhYzA2dXZIZzZO?= =?utf-8?B?MU1wSGU1TU81VlA4UEJSdjBtQlBLYkltUlJ5V0ZWQldYZXVVVk5CNXlKbmhs?= =?utf-8?B?d2syN0VGWEdWSmVkSUttOHNPTkJlT0dBamlTMTN5T2J5d0VuRGVoSXFmZGJC?= =?utf-8?B?NDEwc05ZZzdKcUFOclhlTGZHaWphb29JUllBcGt3Vkp1a0xTK0dTM2lRNkd5?= =?utf-8?B?SE1rWXp4NTYrbklycmFJRXNLeXUxQjBwbzFZaXZvdXZ5Z2lmcThwZ202OVk0?= =?utf-8?B?RnlYYXUrbk5IQkxCazRBMjlFL25kQytjb3lpaVVZRHppb0lYNVYvUko4UkRy?= =?utf-8?B?RWk0bU9FREZIWURKMWlEVkFvaGJ4cmgwMHl6OGVsSFZFMWgxc3orRDRqcjg4?= =?utf-8?B?d0tSdFBBV3JFeTl1dGlCdzVTaDVTZnZxZjFuU0VLcTVybmdvODFEOW9JbnZr?= =?utf-8?B?eGRJU1VwQTFWNGRlUzdEb21PaTdldWdBYmJlRFAxSkhBMFUyeTVyZVhmczdP?= =?utf-8?B?d2xYYTg3MFhhd1poRm8xaVZzNWZJNlc3WVdKQXVHMmsxRytGeDQ5QzByTWs1?= =?utf-8?B?ZHRQSlFhVHdKNDNFNFdRUzZmd21LVy8vZ0tlZHUrbXJZV2g5dHZGK1FLQkNE?= =?utf-8?B?QUlCbnI3em1vWFZYeXoyZmFOR2lXVk54WTNKVVIrb3lDY2t4WEVOM0xGWjFj?= =?utf-8?B?VWMwRFcwdmZYcUhxYzRqM2hXT0o3dGg4QTRsTkpMZnV1WHYwN2xybS9Oamty?= =?utf-8?B?ZmwyaVBPb1RXYm93QnIxK0FBZlRVTlRpZjJnYUhET0NyeVZVbFJCYnUxRlJG?= =?utf-8?B?Z0JGQndDbmRLQStWUVdMMEVsc3VMWVg4U1hIaWZxOWk4emVpVEh5VWlERkhs?= =?utf-8?B?YWN4bU04UlRtTGRaVm9XY3A5K1BWcFQvRlJpVFVvV2wxdm5qTlhBRm80bDBV?= =?utf-8?B?R3AvcGxXek8wRjlIbFZiaHhoUDlUUG85Sk9yTzBadGpyeWVPR3JkYzVMQlhS?= =?utf-8?B?UkJMTnZGNTRvdW9RN1lQOXdrYit0SUlKYy91UzNrNEtPQmphanRXRTFoWUZh?= =?utf-8?B?bG5JcTVlSjJhNUs3UHVWSURZZExuLytRb3R0ckZUTTdSNWlneFJveTBNZ0NF?= =?utf-8?B?a2pTVVA1VUp6eU5uS1k5VnBxOEpSaE5GZGVCR00vZkNuWjZxRnZoclEyOXda?= =?utf-8?B?ZTFDUkxHTW1DalIvcTNjTnorS3p1NUh5T0RsTGVMN1JUMHpRVE5JRU9OVTlx?= =?utf-8?B?RXlpN25Bajk1U3NzNS9TaXc1Nk93U28rM3dHdFdzcUpyUmVtS3lFRTlWckVj?= =?utf-8?B?cllOa0FHaTdLNUhZNzhjMERTMGVSa0NhNkliUkwveUxFbndTamx2M0Rod2Rr?= =?utf-8?B?WGtpRnd4Y3VtUW9vVkZiTU5LdmVjQVlnNnVYbE1SNktRUVd4WEdPb3JsOEhY?= =?utf-8?B?ZnZCUzB3cEhkUWhEL2hyVk9VYnBBUEJSOXRHdUtUR2o5VVVHMzcyVFVIMTdh?= =?utf-8?B?cUE9PQ==?= Content-ID: <52B8E1FF4ECC014690D8C015368B0DFE@apcprd03.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TY0PR03MB6354.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f1f4595b-9961-4beb-093d-08dad4bee42b X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Dec 2022 23:42:36.2934 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zSnVODo6bcYtWOhaMk9RUUwoXs37XvHbJzuarD2tMcxRRlli4kVuvz1FcpJ6eu2aPL8XEcKbuV0FK+BbVIr0TA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR03MB7027 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221202_162332_960943_DEC25B1D X-CRM114-Status: GOOD ( 24.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2022-12-02 at 15:04 -0800, Kees Cook wrote: > > > On Fri, Dec 02, 2022 at 10:56:19PM +0000, Ryder Lee wrote: > > On Fri, 2022-12-02 at 14:24 -0800, coverity-bot wrote: > > > Hello! > > > > > > This is an experimental semi-automated report about issues > > > detected > > > by > > > Coverity from a scan of next-20221202 as part of the linux-next > > > scan > > > project: > > > > > > > https://urldefense.com/v3/__https://scan.coverity.com/projects/linux-next-weekly-scan__;!!CTRNKA9wMg0ARbw!j7j_C0KpO4VD2yMOodvpeIexTGq4fhy2yq6nokNua9u4LToiUOLk4ou8JFFNrXkrh80d5BK2k44faRQstHE9$ > > > > > > > > > > > You're getting this email because you were associated with the > > > identified > > > lines of code (noted below) that were touched by commits: > > > > > > Thu Feb 3 13:57:56 2022 +0100 > > > 417a4534d223 ("mt76: mt7915: update mt7915_chan_mib_offs for > > > mt7916") > > > > > > Coverity reported the following: > > > > > > *** CID 1527801: Memory - illegal accesses (OVERRUN) > > > drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:3005 in > > > mt7915_mcu_get_chan_mib_info() > > > 2999 start = 5; > > > 3000 ofs = 0; > > > 3001 } > > > 3002 > > > 3003 for (i = 0; i < 5; i++) { > > > 3004 req[i].band = cpu_to_le32(phy->mt76->band_idx); > > > vvv CID 1527801: Memory - illegal accesses (OVERRUN) > > > vvv Overrunning array "offs" of 9 4-byte elements at element > > > index 9 (byte offset 39) using index "i + start" (which evaluates > > > to > > > 9). > > > 3005 req[i].offs = cpu_to_le32(offs[i + start]); > > > 3006 > > > 3007 if (!is_mt7915(&dev->mt76) && i == 3) > > > 3008 break; > > > 3009 } > > > 3010 > > > > > > If this is a false positive, please let us know so we can mark it > > > as > > > such, or teach the Coverity rules to be smarter. If not, please > > > make > > > sure fixes get into linux-next. :) For patches fixing this, > > > please > > > include these lines (but double-check the "Fixes" first): > > > > > > > I think this is a false postive as the subsequent check 'if > > (!is_mt7915(&dev->mt76) && i == 3)' should break array "offs" of 8. > > Ah, okay. What if is_mt7915(&dev->mt76) is always true? > > -Kees int start = 0; if (!is_mt7915(&dev->mt76)) { start = 5; ofs = 0; } for (i = 0; i < 5; i++) { req[i].band = cpu_to_le32(phy->band_idx); req[i].offs = cpu_to_le32(offs[i + start]); if (!is_mt7915(&dev->mt76) && i == 3) // break; } For 'is_mt7915' case, start:0 and i: 0 1 2 3 4, whereas !is_mt7915' case, start:5 and i: 0 1 2 3 (then break). I know it's a bit tricky. This is used to differentiate chipset revision. Ryder _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel