From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5106DC636C8 for ; Thu, 15 Jul 2021 22:48:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DFCBC611C0 for ; Thu, 15 Jul 2021 22:48:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DFCBC611C0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5hbDSM9M9C3nkaJpP/JnfAjXq3UpmyB0fMu9KNiQCHA=; b=qiW8Bbv6VOOIPb EBROjtAYsOgBSq5zdmnwjRbFlsqGJxv+px6HIc4+isdUIJpjCgfhbTYZRdoGhghu8YxEZnpUp3BNC YZnHTr0QPnk8fX7X4YgeHnw0DSriDMf+CUWGncCwe8bjIOlRFU56tZEv4mFhKp7xuCOFqEeRO44CF XxAqc0bYWgOBFAkah98+lxAB9u/3DZoIbXXSl2DlLQmix3rq5Cj1t+/VPr4QDhzRVbE94zSUN18Hi KuowDbdMlYHoLyFnN0FauU8X8NLu3M/1wdMPX9LfcHJ/ZKKd5XnZs+Kts3Cfxqv/lqCjfQqWWw9cP FdE0fMtUXnzg14DzIufw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4A7R-002WN4-Vi; Thu, 15 Jul 2021 22:46:14 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4A6S-002Vif-5d; Thu, 15 Jul 2021 22:45:13 +0000 Received: from ip5f5aa64a.dynamic.kabel-deutschland.de ([95.90.166.74] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m4A6Q-0005wd-VX; Fri, 16 Jul 2021 00:45:11 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Douglas Anderson , Geert Uytterhoeven Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: Re: [PATCH resend] soc: rockchip: ROCKCHIP_GRF should not default to y, unconditionally Date: Fri, 16 Jul 2021 00:45:10 +0200 Message-ID: <6289896.mzcYPaeBD7@diego> In-Reply-To: <596ed544412bb45581e9fe42cc519ec5a29ce13b.1626256348.git.geert+renesas@glider.be> References: <596ed544412bb45581e9fe42cc519ec5a29ce13b.1626256348.git.geert+renesas@glider.be> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210715_154512_287329_F786BC67 X-CRM114-Status: GOOD ( 18.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Geert, Am Mittwoch, 14. Juli 2021, 11:53:15 CEST schrieb Geert Uytterhoeven: > Merely enabling CONFIG_COMPILE_TEST should not enable additional code. > To fix this, restrict the automatic enabling of ROCKCHIP_GRF to > ARCH_ROCKCHIP, and ask the user in case of compile-testing. > > Fixes: 4c58063d4258f6be ("soc: rockchip: add driver handling grf setup") > Signed-off-by: Geert Uytterhoeven I had the original patch picked already, just not pushed yet. So hopefully nothing changed between the sends. Heiko > --- > drivers/soc/rockchip/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/soc/rockchip/Kconfig b/drivers/soc/rockchip/Kconfig > index 2c13bf4dd5dbee76..25eb2c1e31bb2a08 100644 > --- a/drivers/soc/rockchip/Kconfig > +++ b/drivers/soc/rockchip/Kconfig > @@ -6,8 +6,8 @@ if ARCH_ROCKCHIP || COMPILE_TEST > # > > config ROCKCHIP_GRF > - bool > - default y > + bool "Rockchip General Register Files support" if COMPILE_TEST > + default y if ARCH_ROCKCHIP > help > The General Register Files are a central component providing > special additional settings registers for a lot of soc-components. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel