From: Heiko Stuebner <heiko@sntech.de>
To: Rudi Heitbaum <rudi@heitbaum.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, rudi@heitbaum.com
Subject: Re: [PATCH] arm64: dts: rockchip: rk3399pro-vmarc-som: add i2c2 scl timing
Date: Thu, 27 Aug 2026 15:18:01 +0200 [thread overview]
Message-ID: <6298523.lOV4Wx5bFT@phil> (raw)
In-Reply-To: <aou1Q5-hdF7kRVpe@0d3a7a881997>
Hi Rudi,
Am Montag, 24. August 2026, 05:06:43 Mitteleuropäische Sommerzeit schrieb Rudi Heitbaum:
> The hym8563 on i2c2 does not ack:
>
> rtc-hym8563 2-0051: could not init device, -6
>
> It is also the ext_clock for sdio-pwrseq, so wifi does not come up
> either.
>
> i2c2 runs at 400 kHz with no scl edge times. The core defaults both to
> 300 ns and rk3x-i2c calculates a 900 ns high period, which is short for
> this bus - it acks at 100 kHz. Set the edges to the values i2c3 already
> uses, giving 1050 ns at 400 kHz.
>
> Tested on a Radxa ROCK Pi N10: rtc0 registers and keeps time across a
> reboot, and wifi activates.
You tested on a Radxa Rock PI N10, but are changing the vmarc-som?
I'm not really understanding this.
Heiko
>
> Signed-off-by: Rudi Heitbaum <rudi@heitbaum.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3399pro-vmarc-som.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399pro-vmarc-som.dtsi b/arch/arm64/boot/dts/rockchip/rk3399pro-vmarc-som.dtsi
> index 64e6ba345739..074f09c6d11c 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399pro-vmarc-som.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399pro-vmarc-som.dtsi
> @@ -296,6 +296,8 @@ &i2c1 {
>
> &i2c2 {
> clock-frequency = <400000>;
> + i2c-scl-falling-time-ns = <15>;
> + i2c-scl-rising-time-ns = <450>;
> status = "okay";
>
> hym8563: rtc@51 {
>
prev parent reply other threads:[~2026-08-27 13:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 3:06 [PATCH] arm64: dts: rockchip: rk3399pro-vmarc-som: add i2c2 scl timing Rudi Heitbaum
2026-08-27 13:18 ` Heiko Stuebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6298523.lOV4Wx5bFT@phil \
--to=heiko@sntech.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
--cc=rudi@heitbaum.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox