From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44B39C433EF for ; Tue, 14 Jun 2022 10:41:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=B6EKLUmUxysnkSyZrL9lg6xOU4XJ3rnzSL+z1Z0h+V4=; b=z75bD+oaGwGoSy PmH1mkE2AyLH+mWTaXbuLNzCgtftLNlfejJJ27sdwqYSexRw+mgtG7aOtEBPvpqwc/PmC5L3/iqqD iYyHFYurBZg3utrNgWozaLx6gpbXaEcqiXmlkuZfOtZnfp0jmJqrFip8mE3ok14+SdMAL8O+0qTBQ sqkq+yVyYShirUDX0gIhYzNId8iH2r1ZPXVnELQCZjsfcY8vZqQoitFzhQ0fDmq2R/0Ja8IpAHTtl Sl5+3+f76S9oWxGlG++Uu5Uemf+1VhBQuAgx/E1dDFiq4qYOO1JxF/270Fh2jYU2OiB0+cDJ82wN7 r4AIHOFvgWsFo9ikYaUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o13yU-0094pY-83; Tue, 14 Jun 2022 10:40:42 +0000 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o13yR-0094pD-VZ for linux-arm-kernel@lists.infradead.org; Tue, 14 Jun 2022 10:40:41 +0000 Received: by mail-wr1-x432.google.com with SMTP id o16so10688166wra.4 for ; Tue, 14 Jun 2022 03:40:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:from:to:cc:subject:references:mime-version :content-disposition:in-reply-to; bh=BJB3Jj+W5NRHZEZPtOT6087E76LkDf+KkklgOlWVWzg=; b=Vx9jgtkwFhdUaWrGkqkzajXjR7Jmjk7cSeF52w5i5LknZZbrFOqcOkF7qZRpf/ga3x d4GtXKlDEaZ6mXMxClErNdgkth+XYPu0uG4P+rJYx9ylxK0o7iQLa8gOlrfTHjmi98j4 Wh3H5GjFpxFsh9e16Xkmk89ceigDXefdv+XRR5mutiF6b4UrUZRWW2zO+CT9U2c24EoI Vj0q8tsyTfqWc6bBlRA8OXESzZXZR9iOzujRPJeEmNxr9w8h3N1uQh/li+mOiQ52xxAb A9rzOsVoaRmihLMnVqP4J5eu+vcoqxX9S6jVuIU8jRwG6CQ4TC1M5mJuwHKBkQHjVQzm A97g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:from:to:cc:subject:references :mime-version:content-disposition:in-reply-to; bh=BJB3Jj+W5NRHZEZPtOT6087E76LkDf+KkklgOlWVWzg=; b=4jKDMqURwJLEDwd436jPqCyYw/GVgj2FOAxBCJkXByQvviLAxbf/D/IZvgZ9IeDK8G oo04yMLJphaSeLYvGshJYKDt02Z3qvLepgP8zKBy3Y59QOpeUwljp4eWsUSHeX6z3WVN 3X+zaghpDfrx9O7N31NxKyvWK44lIOWQpnWqUsf7Jn94vVOYolITxdmpvzQQky7OT/4X xXpgtuPZzjNrqYgZh0XPC25HBvhkuPjFqgA0dvb7ZJBJ851JakBktnk22jq2KkdzFC0Q 6KHkTnEhXWp56Biwd+zB1Q3PMCaxl4PhFe42ZuLXQoHx/85WXTfjfLXeSKH/7LbANzgi 7h1g== X-Gm-Message-State: AJIora+nFRFv/SZpP3xIGFl/86CYyPYm8/C0rUmB0dTsIrOr3KaRQNPk V8HWLkF5AdPUBMJfP1hsKM4= X-Google-Smtp-Source: AGRyM1uoZWrC1W/k512tGAzARKScdtlh9G+N0yFoFFFZiLcqKJi4jpBJsGpSKHqWRKl+/5ViIFOUHg== X-Received: by 2002:a05:6000:1866:b0:218:40cc:a26e with SMTP id d6-20020a056000186600b0021840cca26emr4270476wri.678.1655203237290; Tue, 14 Jun 2022 03:40:37 -0700 (PDT) Received: from Ansuel-xps. (93-42-70-190.ip85.fastwebnet.it. [93.42.70.190]) by smtp.gmail.com with ESMTPSA id f6-20020a05600c154600b0039c5ab7167dsm18006041wmg.48.2022.06.14.03.40.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jun 2022 03:40:36 -0700 (PDT) Message-ID: <62a865a4.1c69fb81.81506.21c5@mx.google.com> X-Google-Original-Message-ID: Date: Tue, 14 Jun 2022 12:40:35 +0200 From: Ansuel Smith To: Jakub Kicinski Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Paolo Abeni , Maxime Coquelin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mark Mentovai Subject: Re: [net-next PATCH 2/2] net: ethernet: stmmac: reset force speed bit for ipq806x References: <20220609002831.24236-1-ansuelsmth@gmail.com> <20220609002831.24236-2-ansuelsmth@gmail.com> <20220613224917.325aca0a@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220613224917.325aca0a@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220614_034040_051695_F3AE0267 X-CRM114-Status: GOOD ( 12.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 13, 2022 at 10:49:17PM -0700, Jakub Kicinski wrote: > On Thu, 9 Jun 2022 02:28:31 +0200 Christian 'Ansuel' Marangi wrote: > > + dn = of_get_child_by_name(pdev->dev.of_node, "fixed-link"); > > + ret = of_property_read_u32(dn, "speed", &link_speed); > > + if (ret) { > > + dev_err(dev, "found fixed-link node with no speed"); > > + return ret; > > Doesn't this return potentially leak the reference on dn? > You move the of_node_put() right before the if (ret) { > Totally right. Will fix in v2. > > + } > > + > > + of_node_put(dn); -- Ansuel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel