From: Stefan Wahren <stefan.wahren@i2se.com>
To: Charles Mirabile <cmirabil@redhat.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
"Peter Robinson" <pbrobinson@gmail.com>,
"Serge Schneider" <serge@raspberrypi.org>,
"Nicolas Saenz Julienne" <nicolassaenzj@gmail.com>,
"Mattias Brugger" <mbrugger@suse.com>,
linux-rpi-kernel@lists.infradead.org,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
rh-kdlp@googlegroups.com, "Joel Slebodnick" <jslebodn@redhat.com>,
"Joel Savitz" <jsavitz@redhat.com>,
"Maxime Ripard" <maxime@cerno.tech>,
"Noralf Trønnes" <noralf@tronnes.org>
Subject: Re: [PATCH v10 0/6] Raspberry Pi Sense HAT driver
Date: Wed, 24 Aug 2022 20:21:34 +0200 [thread overview]
Message-ID: <62ea701c-4a4d-876e-f9b5-db9013b38f04@i2se.com> (raw)
In-Reply-To: <CABe3_aFJ0gkLDFB9k5FEn1SmupbLEKxAn8y=WTt-Rc0xUEK4Dw@mail.gmail.com>
Am 24.08.22 um 14:06 schrieb Charles Mirabile:
>> In case you want to send a new version it would be nice to enable the
>> driver in bcm2835_defconfig for better test coverage. But this is not a
>> show stopper.
> Since I am going to have to send a v11 to fix Lee's email address I
> will look into this. Is it as simple as adding another patch that puts
> CONFIG_SENSEHAT_DISPLAY=y into the next version?
> Presumably I would also want to enable CONFIG_JOYSTICK_SENSEHAT right?
> Do I have to do anything special since both of those options have
> decencies (namely CONFIG_I2C for both and CONFIG_INPUT for the latter,
> and both select MFD_SIMPLE_MFD_I2C)?
make bcm2835_defconfig
enable both driver via make menuconfig
make savedefconfig
mv defconfig arch/arm/configs/bcm2835_defconfig.2
diff -u arch/arm/configs/bcm2835_defconfig
arch/arm/configs/bcm2835_defconfig.2 > config.patch
manually add only the relevant changes from config.patch in
arch/arm/configs/bcm2835_defconfig
generate the patch as usual
goal is to have simple patch which only contains the 2 driver changes
without any clean-up changes
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-24 18:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 17:41 [PATCH v10 0/6] Raspberry Pi Sense HAT driver Charles Mirabile
2022-08-23 17:41 ` [PATCH 1/5] drivers/mfd: sensehat: Add Raspberry Pi Sense HAT to simple_mfd_i2c Charles Mirabile
2022-09-05 13:58 ` Lee Jones
2022-09-06 2:28 ` Bagas Sanjaya
2022-08-23 17:41 ` [PATCH 2/5] drivers/auxdisplay: sensehat: Raspberry Pi Sense HAT display driver Charles Mirabile
2022-08-24 11:26 ` Matthias Brugger
2022-09-06 2:31 ` Bagas Sanjaya
2022-09-08 15:26 ` Wander Lairson Costa
2022-08-23 17:41 ` [PATCH 3/5] dt-bindings: mfd: sensehat: Add Raspberry Pi Sense HAT schema Charles Mirabile
2022-08-24 12:13 ` Matthias Brugger
2022-09-06 2:47 ` Bagas Sanjaya
2022-08-23 17:41 ` [PATCH 4/5] MAINTAINERS: Add sensehat driver authors to MAINTAINERS Charles Mirabile
2022-09-06 2:48 ` Bagas Sanjaya
2022-08-23 17:41 ` [PATCH 5/5] DO NOT MERGE: full sensehat device tree overlay for raspberry pi 4 Charles Mirabile
2022-09-06 2:52 ` Bagas Sanjaya
2022-09-06 10:52 ` Matthias Brugger
2022-08-23 21:30 ` [PATCH v10 0/6] Raspberry Pi Sense HAT driver Stefan Wahren
2022-08-24 12:06 ` Charles Mirabile
2022-08-24 15:30 ` Maxime Ripard
2022-08-24 18:21 ` Stefan Wahren [this message]
2022-08-24 11:28 ` Matthias Brugger
2022-08-24 12:17 ` Charles Mirabile
2022-09-06 2:21 ` Bagas Sanjaya
2022-09-06 10:53 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62ea701c-4a4d-876e-f9b5-db9013b38f04@i2se.com \
--to=stefan.wahren@i2se.com \
--cc=cmirabil@redhat.com \
--cc=jsavitz@redhat.com \
--cc=jslebodn@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=maxime@cerno.tech \
--cc=mbrugger@suse.com \
--cc=nicolassaenzj@gmail.com \
--cc=noralf@tronnes.org \
--cc=pbrobinson@gmail.com \
--cc=rh-kdlp@googlegroups.com \
--cc=serge@raspberrypi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).