From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BBD5BC00140 for ; Wed, 24 Aug 2022 18:23:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AhoUOl6itShTomwEiDgcE8YeywugHdDLd0DVFtxklOk=; b=GW/KpZv+jsMe2h 4vnaUeP/cVWrRhfxMRSJSTWaBYn4gxR1yOq/2LyU3HFFTe9sd5Lk3pNW5wwBHpDZla/P3jIYQx054 0i0aTm38nIv3x3gg9ZywcCjYBft4VpvE05klKa/IZPzy0kqLStohKE7+Z1UQrTwPDKAHgDW1xY1gh GZVJFMFfBVV4bkzfjMFASzbvK0+hCdJglgiZ+o9QeADA3i9DE73ZxE9Feu/ZWJ97z7Xzq8w4TLjLu YXKrLGNvUKY5nO8U/hge/rpfasR4AZgqy8Ai6tXFrEcFbBLt3R1ZmSIS6EWc3WVzRvdYwh4RRkVwS BFmIZrmv0Ev5B7oLjChA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQv0m-00FEeK-RC; Wed, 24 Aug 2022 18:21:56 +0000 Received: from mout.kundenserver.de ([217.72.192.74]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQv0j-00FEbF-6A; Wed, 24 Aug 2022 18:21:54 +0000 Received: from [192.168.1.138] ([37.4.248.80]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MekGB-1ozQTa1umD-00aqN4; Wed, 24 Aug 2022 20:21:35 +0200 Message-ID: <62ea701c-4a4d-876e-f9b5-db9013b38f04@i2se.com> Date: Wed, 24 Aug 2022 20:21:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v10 0/6] Raspberry Pi Sense HAT driver Content-Language: en-US To: Charles Mirabile Cc: linux-kernel , Peter Robinson , Serge Schneider , Nicolas Saenz Julienne , Mattias Brugger , linux-rpi-kernel@lists.infradead.org, Linux ARM , rh-kdlp@googlegroups.com, Joel Slebodnick , Joel Savitz , Maxime Ripard , =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= References: <20220823174158.45579-1-cmirabil@redhat.com> From: Stefan Wahren In-Reply-To: X-Provags-ID: V03:K1:u+zYdaH+2Cf/pioCd/p03u8AnGfLTzkjpU+kpsn3f2yUWDaLfDA cGoRkoW808AE1lIKI6TqKyrH+B8gw198KapcLQgdZlMeHVtfZFPzL0gBoKCB/gtg310fSL4 XOBI1IX0ByzYaIHJApy34W6fQpgjt0ZzJ5OI5WEDivc8PwlioH1xL4koUg8F1UXThVn21K9 Z2P+icZKNzkdK6lxWQfGQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:i6ApzL93+Xo=:rmdM/oTSqpAbLAycZBsETI JghU2EQrnxrp6K0F0p6DwqudAhGPwpTEndmqDVbROfE0FspNUFqgmzGevSU0nLv3zMWHDuxuV r6K/JhgPL8VKaUNOJ3o33kwch3rbhfDdzla8O95XSrmobG1lGRMmc03nXr/viUdGMZUEAOF0X Jrwec/zjjGDyyWzMzeZZ6b+I9oDDCMg8AzmxJgcn/xOrFLX/zUGCP9ePOGE/c8hzsDvAdLqnD T+Q/5IZxwSSGU3WOsSG7dMA9y+8XId77YCdH87wPnxUL5qN1VfB7Q/etbpxvzY51+tLgxiWZc TIaoniuvEiHbh5l5fg58Afuykm27fZkoVeX1KqZa5DNEi813dBOXwPthYvsgpEo+5aeRarv9d 6ixF+A3hvM4o65mGm+5umuJVxTCbFJlK6+Ft6uEq6Dn9TeD0oKw9Ww98S4dEv4tkWrjg49VH+ BCHEo2Bf41HdMuRCXpaLEUCMUlAFDl2mhhDB+4ZORor66FxUyIiBF43TtYH391cOhij7jqOx1 o7LxkSIQCZT2HKnwd1UKK9jezYQCLbIMLXZRE+ttd59prl+glIZf3C6RWQE6a+FBr5omutklj xj1ID/RKB/ZAgwD2cHuSnXhei7iyB6SkZVo/bBjDrMfAhzQ7wbH2TvQe5DCpmSzNMaYHg20sF myT6R/70Vu1mUIGyNKdeivsfbXD18OiIY+SALXezjSQuFxB1X1JjfM4yN/7cRYzUnAZqIYjFn 4cyFi4WLvd3btghdd/fDHNHK8f+S88xXfsKYv3Ob2y0sOZBjWI5rvsIxCYQ= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220824_112153_551371_1A967805 X-CRM114-Status: GOOD ( 13.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am 24.08.22 um 14:06 schrieb Charles Mirabile: >> In case you want to send a new version it would be nice to enable the >> driver in bcm2835_defconfig for better test coverage. But this is not a >> show stopper. > Since I am going to have to send a v11 to fix Lee's email address I > will look into this. Is it as simple as adding another patch that puts > CONFIG_SENSEHAT_DISPLAY=y into the next version? > Presumably I would also want to enable CONFIG_JOYSTICK_SENSEHAT right? > Do I have to do anything special since both of those options have > decencies (namely CONFIG_I2C for both and CONFIG_INPUT for the latter, > and both select MFD_SIMPLE_MFD_I2C)? make bcm2835_defconfig enable both driver via make menuconfig make savedefconfig mv defconfig arch/arm/configs/bcm2835_defconfig.2 diff -u arch/arm/configs/bcm2835_defconfig arch/arm/configs/bcm2835_defconfig.2 > config.patch manually add only the relevant changes from config.patch in arch/arm/configs/bcm2835_defconfig generate the patch as usual goal is to have simple patch which only contains the 2 driver changes without any clean-up changes _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel