From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AC10C00A89 for ; Mon, 2 Nov 2020 12:43:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2497223EA for ; Mon, 2 Nov 2020 12:43:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UCS1awn3"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="AWHmrB5h"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=microchiptechnology.onmicrosoft.com header.i=@microchiptechnology.onmicrosoft.com header.b="EmsyvZsB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2497223EA Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uDdLjvLVeV1f7HlzpbXyDyxcfOw9u+7ZwNBFV5sfw8M=; b=UCS1awn3ETJ05Tu3vqeEv0C8w Yn8PyTmpaVm5H+Oi3Vr6zdkeAvcNPumBFQHkL9hsLvhm8chjzkEswlzzyQcFCVV65mZLznzgH6JYV LKm0hcNDawSyfmiCcO5MRDyXBkYfXZ87Vrr+WiFNKPG/5boPQzFEneXan5FBNrLh5e/jP1WuZHhFp FxPGa9omQU9JJNuXmbjSmL01TBXake+z8l/5zUpJfYzIkL/Y/hSW0PKAi6QRYhRO9tUik2R4IninD JQLykk9SZXaYSBAAKPJfBoxCREpYE3vFpDLQJMUXRMMWiW9OsL29f/ARGd1VlvB6Rt3VcUZhzZ6eg 5Uhq9WBHw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZZ9k-0001oU-4m; Mon, 02 Nov 2020 12:41:52 +0000 Received: from esa6.microchip.iphmx.com ([216.71.154.253]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZZ9g-0001nW-SH for linux-arm-kernel@lists.infradead.org; Mon, 02 Nov 2020 12:41:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1604320908; x=1635856908; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=ASHJ/7zXT1a13nWrFo8skwV0nIZh1dJrdxJ97Ps9iP8=; b=AWHmrB5hKKhTKqT24jdhzYj6V8aWnwodvxYo7MLv9N1qw7Jep7lLjwmf O5Kt39x7r6WutZN74b3zGKHX4k34mPuvz8Bz9AZSDnUSh6EOiNgkgROFX 0EB55WkDQ4x4Fis7tkObOk97tdiozYuAza92bf25p0nXVp20qaYurYJPY lpFsAYEjzPdAE+Lw/quURP581jKIX/7m57bW7tAIaWiUqqzTT3ylnhgN6 BGFPhU2qigT43ss8a1wPcyB6PSE+hKyBXGJK6FKb52lnJUH52hEZbhKb/ tmCiSzzciSlBNGvKSNPlukcW4wAYvQP+elM2W6Gq4k4wScReGrlnC9Rez w==; IronPort-SDR: c8LlSg8I4rWHPkoWRm3BRWrlhOOKJ3oDs/qmGW5Pa3O3kCXq5rOxJR5KMFVPbqqQOy13T5gCln vmQou//hM3SoaVxmOHPK3815UWfxFe3afqVTnddvVAe9FUkWMJ/Qg1Tg8w0NF58lqdOBH7R6zh jEXMCLtkXrEo089f1c/6uqHXEz3pjzGsDsVQrsIYw7qAqp3OBIgLiU8o+oe+BkJkhs/yI5cxx0 8HPUoKE7IJ2YcGdb8VUYJ+z61JwvWJ73RJN+m36x3QP1nTGbo0OFsHttVa5hiaz01Np/LLdbAm tlU= X-IronPort-AV: E=Sophos;i="5.77,444,1596524400"; d="scan'208";a="32050479" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 02 Nov 2020 05:41:47 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Mon, 2 Nov 2020 05:41:47 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3 via Frontend Transport; Mon, 2 Nov 2020 05:41:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z4QliyRfDtU/9dLX3zp7fETYKmDmrp+sJg4eDNURfeEXkDYbQz/m9LN62idsNo2LlRo5/El7vQgz8WNJm+T2xrZmBkiEnxgUynVB/kXSaI2LBoaymXmge8GrI4BbCND6jm5ge8MUEvPSCYaOuIMOJGDsFY1w6IOBc7RvU/XjddL9UJkQ8nIASP7MGNCAMlohbf1EecycTLj37OWKjCdOh8mLxOBbFN3y/S5xO02xuKAyN4cAPoxlrx6yOzx34DGAD4qU0FfJjsZqvSLbdc5MH8VAMwv3+qTgBQ5MdHxetE4oNzWoB8YYeL0hgTbIOzfz5ONl2hFaY5yAmDFY6MoLOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ASHJ/7zXT1a13nWrFo8skwV0nIZh1dJrdxJ97Ps9iP8=; b=GRC9kD2/HyJj6uPekKtWnyhmbhYnq/Ge1Cx1PV8JEmD23dVChZswOjiCk8I8x0HURtmkseEoq8QFyDYijmbwEsVEDrDXfnIIjRnDOcXescEJeDc+JSmBnkC2qGrrOfgxVc/ZdJJtunzSZJGwocAnsouLjnNJ4j6bq7AJTOhqzmPcExs1k1LZT2AV+1ucSAwoD8Poyzv/MMRIMxhC7oXlzhT/Hfoz7LERudplHIXJPnItQ5IvWQGg8WB/bCzDZy0srFy0Q1VSzbx68BVF8y3gxG9CY2SCRDklbbNvRDFMvZuqZ8nTnLd1/JvsLSlQnfXYpkhsnK4Tmn9wJ0bB89UA+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ASHJ/7zXT1a13nWrFo8skwV0nIZh1dJrdxJ97Ps9iP8=; b=EmsyvZsBzKcNsSwHCWhS1eJ2tqGHG7rS3S4OO2kqA29GPYU9FR5/OsOj3CGDo/6/HbNlAo03qXP2hPAWqLSZ81QOFr/RInUCSl51Jeta00Ydl14nYMeRLZ2o1czfPWm6GybYM0M6+NxYykWyiutvV0ImA05EwS6fXZo0yBetl6M= Received: from CY4PR1101MB2341.namprd11.prod.outlook.com (2603:10b6:903:b1::22) by CY4PR11MB2008.namprd11.prod.outlook.com (2603:10b6:903:22::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.28; Mon, 2 Nov 2020 12:41:43 +0000 Received: from CY4PR1101MB2341.namprd11.prod.outlook.com ([fe80::908:a628:69ca:d62e]) by CY4PR1101MB2341.namprd11.prod.outlook.com ([fe80::908:a628:69ca:d62e%7]) with mapi id 15.20.3499.030; Mon, 2 Nov 2020 12:41:43 +0000 From: To: Subject: Re: [PATCH] ARM: dts: at91: add serial MFD sub-node for usart Thread-Topic: [PATCH] ARM: dts: at91: add serial MFD sub-node for usart Thread-Index: AQHWrq0BNGYIfVuhjkKKUxhuAsgrHKmwJpcAgAAMyICABF5uAIAAO+AA Date: Mon, 2 Nov 2020 12:41:43 +0000 Message-ID: <6313146b-9b2c-097b-9852-d85fc1bf16b4@microchip.com> References: <20201030110702.886638-1-codrin.ciubotariu@microchip.com> <20201102090724.GG4127@dell> In-Reply-To: <20201102090724.GG4127@dell> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 authentication-results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=microchip.com; x-originating-ip: [86.121.145.173] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c4a44f06-d0ad-4fa9-5d3c-08d87f2ca748 x-ms-traffictypediagnostic: CY4PR11MB2008: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-bypassexternaltag: True x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fiip18FiMP64ZvYpbT3U5H/mIk0xVWNCY0sbDivz+ISdYrTbWhOV9MwlGRNGS3n1HO6u1rq1wjZHvVJCC8AhXQ9UzQ5M8MuNK3ewXn4/eWUjNhT0191YIiQLv9oP5liNru5c1JD5sJSjJMnfA4TPwdgkktQHGxabT5NW8sMVgRJRfAyyHjAwm8H+8jaLISmmFUu6JpblU1pn8qHWqc7K/l3cLxtHpMnd3x2iB6nnkeMnwPg8aM/w6K3bxOP2yt4bS2H3eODIoaQQ+dLMGcbvtM2dkGKYSrAbeOsBmzYwt1LeHO17zaK/U3DZZNPRh2xT2O+KLlSjqlIoAeoAe+9joxhpkKVYgFNAdRPBB7OiHx1ihW9NbInImeizDTTQf+cg x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1101MB2341.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(136003)(396003)(39860400002)(376002)(366004)(107886003)(36756003)(86362001)(6916009)(4326008)(31686004)(2616005)(8676002)(66446008)(66946007)(186003)(66556008)(8936002)(316002)(71200400001)(91956017)(2906002)(31696002)(76116006)(64756008)(66476007)(6506007)(53546011)(6512007)(54906003)(478600001)(26005)(83380400001)(5660300002)(6486002)(43740500002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: vd+fqnwe0PUGVY4fW82sKaKbo737otfr5mJcze2KmDMlSJtYYHOnKM9DtYND1W9UvoGq3kNKekTxMXwG5SEfZKDQS/FI92JKe1q19mma+gviIlfjdG+L/u/8Ss5t6IBvmGc9aJKDlhtp/iRNpv4DawAhrpsM5MBqud/+/8w3VnJltnuxfhRhDGDC77NN6prt4PPpdc0m7Se+l5RN3821dSpVtsIcIjvZKa86DvpRluE0hSfqtUETXxlQPtH1oLiFO4Kiq0bK0hTe54Qf6OnygKqXD45EWG5Sdw8MSfAUbHVuLuVCrHFonH5trJtUtQntBUh4HUF1mZp9yu/RiEKPPQ6PeWYE1b7Bc66+wTvAehVsZ9OUmYGMQhQz4Cd2xgUP+UjFhXKUUuzHHUqEDy0f8a5COoPHdwRy2oQdo68cBh3Lh3a42syRalbxvi+c3RkQ54cHAsWB8Nq5RN/7IJcem/FBAfTwhWiEs0zfHJIGQasWhdU/g7hMWOmn5XdltYNHCu/xA5R5hB1ZB2jU8BopLTLdoNegMPkY6Wr9keH8kJ4pXE+p4PHkiI22aeSYZJR2JBKeeAQIQjhynWbYIcW74VNTK/HKFJG/0HDdVic4nLjrLnJLJ++qn+b56+1LhUyW+ANKpANFiLk9oYovAEtIhw== Content-ID: <29E50F4CF71A6A46890B4DD00153A90D@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1101MB2341.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c4a44f06-d0ad-4fa9-5d3c-08d87f2ca748 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2020 12:41:43.4161 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yLBI7lsId7UkIgNJJaSyILLjHEfy/PgBcFBDfShihugaicomD1dquDqzRj6SqXyNDOAuVXhPY8VAcpPm/nbGUJnR+f5egSw1yVPqOw/kl1k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB2008 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_074149_055438_D7E42510 X-CRM114-Status: GOOD ( 23.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, richard.genoud@gmail.com, linux-kernel@vger.kernel.org, Ludovic.Desroches@microchip.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 02.11.2020 11:07, Lee Jones wrote: > On Fri, 30 Oct 2020, Codrin.Ciubotariu@microchip.com wrote: > >> On 30.10.2020 15:38, Nicolas Ferre wrote: >>> On 30/10/2020 at 12:07, Codrin Ciubotariu wrote: >>>> The "atmel,at91sam9260-usart" driver is a MFD driver, so it needs >>>> sub-nodes >>>> to match the registered platform device. For this reason, we add a serial >>>> subnode to all the "atmel,at91sam9260-usart" serial compatible nods. This >>>> will also remove the boot warning: >>>> "atmel_usart_serial: Failed to locate of_node [id: -2]" >>> >>> I don't remember this warning was raised previously even if the MFD >>> driver was added a while ago (Sept. 2018). >>> >>> I would say it's due to 466a62d7642f ("mfd: core: Make a best effort >>> attempt to match devices with the correct of_nodes") which was added on >>> mid August and corrected with 22380b65dc70 ("mfd: mfd-core: Ensure >>> disabled devices are ignored without error") but maybe not covering our >>> case. >> >> Well, it's not covering our enabled devices. >> >>> >>> So, well, I don't know what's the best option to this change. Moreover, >>> I would say that all other USART related properties go into the child >>> not if there is a need for one. >>> >>> Lee, I suspect that we're not the only ones experiencing this ugly >>> warning during the boot log: can you point us out how to deal with it >>> for our existing atmel_serial.c users? >> >> My understading is that platform devices registered by MFD should have a >> correspondig DT node. The parrent properties are also available for the >> other usart device (usart-spi), so I think we should keep them in the >> parrent. > > Device Tree and MFD are unrelated. MFDs don't even exist - they are a > figment of a Linux Kernel Engineer's imagination - we made them up! > > The DT should describe the hardware and nothing else. If we wish to > mess with devices for our own gain i.e. organise them into different > subsystems, we have to do that in software. That's what MFD is for. You are right, I mixed up things. We are using the MFD here to describe a hardware USART IP that can also function as an SPI, but not at the same time. The decision of whether the IP works as a normal USART or an SPI is DT configurable, at this moment. It is doing more than just describing the HW, but I don't know how to describe it otherwise. Best regards, Codrin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel