From: Christopher Obbard <chris.obbard@collabora.com>
To: Eugen Hristev <eugen.hristev@collabora.com>,
linux-mediatek@lists.infradead.org
Cc: krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com,
devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, conor+dt@kernel.org,
kernel@collabora.com
Subject: Re: [PATCH 2/2] arm64: dts: mediatek: fix t-phy unit name
Date: Fri, 11 Aug 2023 14:10:15 +0100 [thread overview]
Message-ID: <6317dfe358f0181aaac3fc4a9d6207a5a7d7efe8.camel@collabora.com> (raw)
In-Reply-To: <20230811130700.72787-2-eugen.hristev@collabora.com>
Hi Eugen,
On Fri, 2023-08-11 at 16:07 +0300, Eugen Hristev wrote:
> Fix:
> Warning (unit_address_vs_reg): /t-phy@1a243000: node has a unit name, but no reg or ranges property
> Warning (unit_address_vs_reg): /soc/t-phy@11c00000: node has a unit name, but no reg or ranges property
>
> The ranges is empty thus removing the `@1a243000`, `@11c00000` from
> the node name.
Does this patch need a Fixes: tag?
It would be also quite nice to say in your commit messsage where the error comes from (make dtbs_check) :-)
>
> Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com>
> ---
> arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 +-
> arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> index 36ef2dbe8add..3ee9266fa8e9 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> @@ -905,7 +905,7 @@ sata: sata@1a200000 {
> status = "disabled";
> };
>
> - sata_phy: t-phy@1a243000 {
> + sata_phy: t-phy {
> compatible = "mediatek,mt7622-tphy",
> "mediatek,generic-tphy-v1";
> #address-cells = <2>;
> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
> index 68539ea788df..24eda00e320d 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
> @@ -434,7 +434,7 @@ pcie_intc: interrupt-controller {
> };
> };
>
> - pcie_phy: t-phy@11c00000 {
> + pcie_phy: t-phy {
> compatible = "mediatek,mt7986-tphy",
> "mediatek,generic-tphy-v2";
> #address-cells = <2>;
> --
> 2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-08-11 13:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 13:06 [PATCH 1/2] dt-bindings: phy: mediatek,tphy: allow simple nodename pattern Eugen Hristev
2023-08-11 13:07 ` [PATCH 2/2] arm64: dts: mediatek: fix t-phy unit name Eugen Hristev
2023-08-11 13:10 ` Christopher Obbard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6317dfe358f0181aaac3fc4a9d6207a5a7d7efe8.camel@collabora.com \
--to=chris.obbard@collabora.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eugen.hristev@collabora.com \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox