From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9F89C43334 for ; Tue, 12 Jul 2022 20:14:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=luRjdhqTgmYUeU6SIZTs2b1s0Te1q7E/Jd/y0Ew/NJE=; b=Wbns58aM1iPh1G gtsrEt8BxjZPNUpSJW+ESgB3cnzCPbWgRkERbAKLcpg0n3vrEZuNdhLfbPzkXWqeBzGomsgIIqza+ 1s5YBQncWccxAFG9Ixqo8Uppnh07hXTjA/L9s+RKA6wScN3xO/41h3Vh0X+Sf6R5Y2dFSZcXzVJiM gMWOlEn8tRfksdWZgzvk0jaiDTwcIS08hhd7jlsowTX/rHzmsNoGx28VgXRC/yoZoQuAwCwzfce0X 6/gQ9Au31PzN+tBtnoP1wcquBmzAU1vXdI5XZ1duzuZhHaGqD7ySqPUinJ39EJh4BkKaOjXv0X4Je yDNBMayWxm/LJrbfkKzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBMGW-00ESfZ-Uf; Tue, 12 Jul 2022 20:13:53 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBMGT-00ESWO-HK for linux-arm-kernel@lists.infradead.org; Tue, 12 Jul 2022 20:13:51 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 08874165C; Tue, 12 Jul 2022 13:13:32 -0700 (PDT) Received: from [10.57.85.194] (unknown [10.57.85.194]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 218E23F70D; Tue, 12 Jul 2022 13:13:29 -0700 (PDT) Message-ID: <632f5c80-2be3-ace5-6b0d-ee0c9e5560ff@arm.com> Date: Tue, 12 Jul 2022 21:13:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [RESEND PATCH v3 1/2] perf: coresight_pmu: Add support for ARM CoreSight PMU driver Content-Language: en-GB To: Mathieu Poirier , Besar Wicaksono Cc: Suzuki K Poulose , "catalin.marinas@arm.com" , "will@kernel.org" , "mark.rutland@arm.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "sudeep.holla@arm.com" , "thanu.rangarajan@arm.com" , "Michael.Williams@arm.com" , Thierry Reding , Jonathan Hunter , Vikram Sethi , "mike.leach@linaro.org" , "leo.yan@linaro.org" References: <20220621055035.31766-1-bwicaksono@nvidia.com> <20220621055035.31766-2-bwicaksono@nvidia.com> <73dafe08-d1f1-90b6-995e-7d38e9e1dce7@arm.com> <20220712163638.GA2945984@p14s> From: Robin Murphy In-Reply-To: <20220712163638.GA2945984@p14s> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220712_131349_702581_C4B1A67F X-CRM114-Status: GOOD ( 18.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022-07-12 17:36, Mathieu Poirier wrote: [...] >>> If we have decied to call this arm_system_pmu, (which I am perfectly >>> happy with), could we please stick to that name for functions that we >>> export ? >>> >>> e.g, >>> s/coresight_pmu_sysfs_event_show/arm_system_pmu_event_show()/ >>> >> >> Just want to confirm, is it just the public functions or do we need to replace >> all that has "coresight" naming ? Including the static functions, structs, filename. > > I think all references to "coresight" should be changed to "arm_system_pmu", > including filenames. That way there is no doubt this IP block is not > related, and does not interoperate, with the any of the "coresight" IP blocks > already supported[1] in the kernel. > > I have looked at the documentation[2] in the cover letter and I agree > with an earlier comment from Sudeep that this IP has very little to do with any > of the other CoreSight IP blocks found in the CoreSight framework[1]. Using the > "coresight" naming convention in this driver would be _extremely_ confusing, > especially when it comes to exported functions. But conversely, how is it not confusing to make up completely different names for things than what they're actually called? The CoreSight Performance Monitoring Unit is a part of the Arm CoreSight architecture, it says it right there on page 1. What if I instinctively associate the name Mathieu with someone more familiar to me, so to avoid confusion I'd prefer to call you Steve? Is that OK? As it happens, Steve, I do actually agree with you that "coresight_" is a bad prefix here, but only for the reason that it's too general. TBH I think that's true of the existing Linux subsystem too, but that damage is already done, and I'd concur that there's little value in trying to unpick that now, despite the clear existence of products like CoreSight DAP and CoreSight ELA which don't have all that much to do with program trace either. However, hindsight and inertia are hardly good reasons to double down on poor decisions, so if I was going to vote for anything here it would be "cspmu_", which is about as obviously-related-to-the-thing-it-actually-is as we can get while also being pleasantly concise. [ And no, this isn't bikeshedding. Naming things right is *important* ] Cheers, Robin. > > Thanks, > Steve > > [1]. drivers/hwtracing/coresight/ > [2]. https://developer.arm.com/documentation/ihi0091/latest _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel