From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1811C433EF for ; Wed, 25 May 2022 06:27:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:Cc: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uRvrULLVbuIDvurcCFAypMm/Ko5XNNLMuBRcSmlD+Zc=; b=yVFstZ+X257aAV e8B4bNhjGaqn3z5If8j7rDprX1ivQ4TrbxJMHyHUNULwXI5SIPrfN7MpVuIlzePUBZWzrrL1cwTVX f/2gInACswPJ0w5Fj9YxYxMYV2NgSmgDw4YKMbOgfn3HMthyRVarOB11XLFCDWG6qhh0/7YTTf+li 2O3faGOYC1k8YU7ueWT5EzcNMdkaoXIkqeckICzyCEs9F84AgM3MCumW5JcNIixhHUnuBTtz6DBEL 0o2YVu/HM1VZDv8nsBEDAPm3r1ez2pBg/G6UYSIhnvkwy16izQDUzrcEHMtNysqmNj7M5g6Bl9lMG 3nOc1X4soGZbUaKiuUQA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ntkTn-00A4Mi-VD; Wed, 25 May 2022 06:26:48 +0000 Received: from mga12.intel.com ([192.55.52.136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ntkTj-00A4Kj-VW for linux-arm-kernel@lists.infradead.org; Wed, 25 May 2022 06:26:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653460003; x=1684996003; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=lbi++CXcaekGLCTBDHq57kBFex4czpZ+/tgqoBHU1dU=; b=JM9B03qEqZ5sfIAHWQQhE69hIbZY5sdAuFKUveIgAOT2teHDcUPa8PF1 O7lzTfxoGbcUBXaNLZuZX2igYSFccpPQBG4pV7TdrZLcSAkifH4b31RQb G8Mue0WJ49rc2TWNZGnAD71E7i8NgoLj0o61pF1fLenbXqmSyL1tqyiH3 kRwbrnpTlNrN1GnVlNoC+JdtJYWD0pxuePv98az4B9e3MOHX5ldZiyT28 8ZGiPT1BFzrcLy6U3d9TfUsqYXRDpM47gPrjlCyufgcwzgTPmxvktm9/M mXlIUWREkz5OgfCNOw5nU0+lmuhPtnPqGjwNqBAwMd9uWWG3aLcwtPRkc Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10357"; a="253603715" X-IronPort-AV: E=Sophos;i="5.91,250,1647327600"; d="scan'208";a="253603715" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2022 23:26:41 -0700 X-IronPort-AV: E=Sophos;i="5.91,250,1647327600"; d="scan'208";a="601683714" Received: from jwang96-mobl.ccr.corp.intel.com (HELO [10.255.29.139]) ([10.255.29.139]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2022 23:26:38 -0700 Message-ID: <63369db0-cf7f-aa53-bf9f-de2b0b2289ac@linux.intel.com> Date: Wed, 25 May 2022 14:26:37 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Cc: baolu.lu@linux.intel.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, yuji2.ishikawa@toshiba.co.jp, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/3] iommu: Add Visconti5 IOMMU driver Content-Language: en-US To: Nobuhiro Iwamatsu , Joerg Roedel , Will Deacon , Rob Herring , Jason Gunthorpe References: <20220525013147.2215355-1-nobuhiro1.iwamatsu@toshiba.co.jp> <20220525013147.2215355-2-nobuhiro1.iwamatsu@toshiba.co.jp> From: Baolu Lu In-Reply-To: <20220525013147.2215355-2-nobuhiro1.iwamatsu@toshiba.co.jp> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220524_232644_069007_B3A6F23F X-CRM114-Status: UNSURE ( 9.17 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022/5/25 09:31, Nobuhiro Iwamatsu wrote: > +static const struct iommu_ops visconti_atu_ops = { > + .domain_alloc = visconti_atu_domain_alloc, > + .probe_device = visconti_atu_probe_device, > + .release_device = visconti_atu_release_device, > + .device_group = generic_device_group, > + .of_xlate = visconti_atu_of_xlate, > + .pgsize_bitmap = ATU_IOMMU_PGSIZE_BITMAP, > + .default_domain_ops = &(const struct iommu_domain_ops) { > + .attach_dev = visconti_atu_attach_device, > + .detach_dev = visconti_atu_detach_device, The detach_dev callback is about to be deprecated. The new drivers should implement the default domain and blocking domain instead. > + .map = visconti_atu_map, > + .unmap = visconti_atu_unmap, > + .iova_to_phys = visconti_atu_iova_to_phys, > + .free = visconti_atu_domain_free, > + } > +}; Best regards, baolu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel