From mboxrd@z Thu Jan  1 00:00:00 1970
From: linus.ml.walleij@gmail.com (Linus Walleij)
Date: Wed, 2 Sep 2009 23:39:54 +0200
Subject: [PATCH 2/2] U300 AB3100 boardinfo v3
In-Reply-To: <20090902184234.GB10581@rakim.wolfsonmicro.main>
References: <1251756324-24216-1-git-send-email-linus.walleij@stericsson.com>
	<20090902184234.GB10581@rakim.wolfsonmicro.main>
Message-ID: <63386a3d0909021439k784bc80et7e5cfa38987afefb@mail.gmail.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

2009/9/2 Mark Brown <broonie@opensource.wolfsonmicro.com>:

> On Tue, Sep 01, 2009 at 12:05:24AM +0200, Linus Walleij wrote:
>> This defines regulator platform data and board power
>> regulator hogs for the ST-Ericsson U300 platform.
>
> This is pretty much OK, just...
>
>> +static struct regulator_consumer_supply supply_ldo_a[] = {
>> + ? ? {
>> + ? ? ? ? ? ? .dev = NULL,
>> + ? ? ? ? ? ? .supply = "vrad", /* Powers the radio */
>> + ? ? },
>> +};
>
> Now you're using the regulator init stuff to set the voltages you should
> be able to drop most of the deviceless supplies. ?I'd expect that you'd
> want to keep the CPU core supplies for cpufreq support but the others
> shouldn't need to be defined. ?The names can be set in the constraints
> - if set there they will be displayed to user space which normally makes
> the diagnostics easier to follow for board users.

OK I'll drop them. I've got some other small fixups here so will push a v4
once we clarified the initsettings too.

Yours,
Linus Walleij