From mboxrd@z Thu Jan  1 00:00:00 1970
From: linus.ml.walleij@gmail.com (Linus Walleij)
Date: Mon, 22 Mar 2010 22:13:53 +0100
Subject: [PATCH 05/07] Basic IO mappings for mach-tcc8k
In-Reply-To: <20100322192748.GK2040@bluebox.local>
References: <20100322191900.GF2040@bluebox.local>
	<20100322192748.GK2040@bluebox.local>
Message-ID: <63386a3d1003221413p29784233rc0952fba5d921e18@mail.gmail.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

2010/3/22 Hans J. Koch <hjk@linutronix.de>:

> Map the IO ranges of TCC8xxx peripherals.
> (...)
> + ? ? ? {
> + ? ? ? ? ? ? ? .virtual ? ? ? ?= DATA_TCM_BASE_VIRT, ? /* Data TCM */
> + ? ? ? ? ? ? ? .pfn ? ? ? ? ? ?= __phys_to_pfn(DATA_TCM_BASE),
> + ? ? ? ? ? ? ? .length ? ? ? ? = DATA_TCM_SIZE,
> + ? ? ? ? ? ? ? .type ? ? ? ? ? = MT_DEVICE
> + ? ? ? },

Hey, that no peripheral, that's onchip TCM memory, MT_DEVICE is
very inappropriate since it will cause readthrough/writethrough.

Please use the generic TCM memory support as described in
Documentation/arm/tcm.txt for your TCM memory, example of
a platform using this can be found in arch/arm/mach-u300,
just grep -r for TCM. Note the flag in arch/arm/Kconfig as well.

Any problems, ask.

Yours,
Linus Walleij