From: linus.ml.walleij@gmail.com (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Including device.h and resource.h header files in linux/amba/bus.h
Date: Sat, 27 Mar 2010 21:57:04 +0100 [thread overview]
Message-ID: <63386a3d1003271357i7cb5aa84w35a447ed34db8d72@mail.gmail.com> (raw)
In-Reply-To: <22dbbef21003270455i1e7175cbxbbd2e2112931c192@mail.gmail.com>
[Viresh]
> On Sat, Mar 27, 2010 at 2:43 PM, Linus Walleij
>> On the other hand Documentation/SubmitChecklist contains this:
>>
>> 1: If you use a facility then #include the file that defines/declares
>> ? that facility. ?Don't depend on other header files pulling in ones
>> ? that you use.
>
> I agree on the above statement.
>
>(...)
> Again, according to above statement from submitchecklist:
> shouldn't bus.h include device.h and resource.h, as it is using
> these facilities.
Yes I think you're right, looks like it should be applied then!
Acked-by:
Yours,
Linus Walleij
next prev parent reply other threads:[~2010-03-27 20:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 10:03 [PATCH] Including device.h and resource.h header files in linux/amba/bus.h Viresh KUMAR
2010-03-25 10:03 ` [PATCH] removing compilation warning comming from clkdev.h Viresh KUMAR
2010-03-27 21:42 ` Russell King - ARM Linux
2010-03-26 17:31 ` [PATCH] Including device.h and resource.h header files in linux/amba/bus.h Linus Walleij
2010-03-27 5:07 ` viresh kumar
2010-03-27 9:13 ` Linus Walleij
2010-03-27 11:55 ` viresh kumar
2010-03-27 20:57 ` Linus Walleij [this message]
2010-03-29 17:16 ` H Hartley Sweeten
2010-03-29 17:19 ` Russell King - ARM Linux
2010-03-29 17:23 ` H Hartley Sweeten
2010-03-27 21:42 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63386a3d1003271357i7cb5aa84w35a447ed34db8d72@mail.gmail.com \
--to=linus.ml.walleij@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).