[Patch V2 2/2] i2c: mv64xxx: Remove internal compatible string from Documentation

Jason Cooper
2014-07-28T13:22:51Z

Andrew,

I'm fine with this series wrt to fixing Linux, however:

On Sat, Jul 26, 2014 at 07:20:38PM +0200, Andrew Lunn wrote:
> The compatible string "marvell,mv78230-a0-i2c" should only be used
> internally when at run time we detect an Armada XP with broken
> hardware offload. This string should never appear in DT blobs passed
> to the kernel. Hence remove it from the binding Documentation.
>
> Patch proposed by Arnd Bergmann <arnd@arndb.de>
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
> Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt b/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
> index 5c30026921ae..6eb6f6e40ba1 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
> @@ -9,11 +9,6 @@ Required properties :
> - "allwinner,sun6i-a31-i2c"
> - "marvell,mv64xxx-i2c"
> - "marvell,mv78230-i2c"
> - - "marvell,mv78230-a0-i2c"
> - * Note: Only use "marvell,mv78230-a0-i2c" for a
> - very rare, initial version of the SoC which
> - had broken offload support. Linux
> - auto-detects this and sets it appropriately.

I think we're losing knowledge here. *We* know that attempting to
enable transaction offload on A0 SoCs is bad news. Other OS's would now
need to dig through the Linux kernel code for clues as to what's
happening.

Perhaps we should retain the info in the form of a note at the bottom of
this file?

thx,

Jason.