From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42C80C43603 for ; Mon, 16 Dec 2019 11:21:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 17F6E206D3 for ; Mon, 16 Dec 2019 11:21:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uTmnyuNI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 17F6E206D3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rjwysocki.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eTACstvekBy2OdPxN17cFM599Yk9Tk5EH2VGCLAARxI=; b=uTmnyuNIlPAAlx ++zi5aDKNkDAcx8mGXddaGHlqUQDPL2L2j7LvmT5kf6Zku+ShFAsOSy/fDDJAkKL3OOINk8RKFna8 iv0dXErXmp9TzwSD/uZ4zLSqLBedy1HuDXBdOiidVFQ4UDVL9PeTslTv6t58oi2F4tYo4AQFkVV36 yzqZ2r93F5wacjQXzNif3jMFQtjDojuwpcM2LltILeC8BdnPz9oYVSo2SMnPAH1LyO+tYnKQMxVOI kaSXuYt2G879yaX9ulZIFfhPocho/O+HAQtUuxP7A+vm6tEyzgBi4zN94N0mvh/5pGw/oStmRX5a8 PkW/9LonhcCNBcp+KgLw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1igoRm-0006go-1W; Mon, 16 Dec 2019 11:21:54 +0000 Received: from cloudserver094114.home.pl ([79.96.170.134]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1igoR4-00062B-CE for linux-arm-kernel@lists.infradead.org; Mon, 16 Dec 2019 11:21:12 +0000 Received: from 79.184.253.1.ipv4.supernova.orange.pl (79.184.253.1) (HELO kreacher.localnet) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer 0.83.320) id e45c4e508fae84d8; Mon, 16 Dec 2019 12:21:07 +0100 From: "Rafael J. Wysocki" To: Yangtao Li Subject: Re: [PATCH 1/2] cpuidle: kirkwood: convert to devm_platform_ioremap_resource Date: Mon, 16 Dec 2019 12:21:07 +0100 Message-ID: <6350875.0eM1BVzdex@kreacher> In-Reply-To: <20191215130206.30265-2-tiny.windzz@gmail.com> References: <20191215130206.30265-1-tiny.windzz@gmail.com> <20191215130206.30265-2-tiny.windzz@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191216_032110_621125_C8AC6AE2 X-CRM114-Status: GOOD ( 11.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org, linux-arm-kernel@lists.infradead.org, shc_work@mail.ru, linux-pm@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sunday, December 15, 2019 2:02:06 PM CET Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li > --- > drivers/cpuidle/cpuidle-kirkwood.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/cpuidle/cpuidle-kirkwood.c b/drivers/cpuidle/cpuidle-kirkwood.c > index d23d8f468c12..511c4f46027a 100644 > --- a/drivers/cpuidle/cpuidle-kirkwood.c > +++ b/drivers/cpuidle/cpuidle-kirkwood.c > @@ -55,10 +55,7 @@ static struct cpuidle_driver kirkwood_idle_driver = { > /* Initialize CPU idle by registering the idle states */ > static int kirkwood_cpuidle_probe(struct platform_device *pdev) > { > - struct resource *res; > - > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - ddr_operation_base = devm_ioremap_resource(&pdev->dev, res); > + ddr_operation_base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(ddr_operation_base)) > return PTR_ERR(ddr_operation_base); > > Daniel, any concerns here? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel