From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6103FC433FE for ; Mon, 14 Nov 2022 14:24:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Fb+kP0MUEhAJPL+OgVzGTV/KxdrvS8Ukom3iJecTAls=; b=Pmui6WNpvafwvS h8Ink1Fo9uw4FcrFZHKAKHZSUr0PfXiyv41PURRV1v6ER9BMIsR1UizVxdYLY3DJgajUHi1HIqZ5I W/bLbVp1s1WskjfJnqMto73E6oZgW2aVGO+9aLqZSEKtyX2dXPJMCRANmSHbsSKQ9mkWK3lBdBhL+ RTZGVb6JmgwYlv9Q0K76a5z7kXQQi4YPg2RMCpVYJ2CPiROQKZo6jVTnEi3FXbKxsbMuDRW3sh2WY m22Kxn3der0z5rZOTn6x4dXkROAhcENPiKcj4i1X+vgD9g19SBET+huEgO+ChLeATHZI9tq0k6zav CauELrV3kGOXthZWzD3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouaMt-001gRf-9q; Mon, 14 Nov 2022 14:23:23 +0000 Received: from mail-ot1-x32e.google.com ([2607:f8b0:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouaMm-001gM1-Ts; Mon, 14 Nov 2022 14:23:18 +0000 Received: by mail-ot1-x32e.google.com with SMTP id db10-20020a0568306b0a00b0066d43e80118so6561665otb.1; Mon, 14 Nov 2022 06:23:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=kH9QzbbcRu9iwTWJWajkxWF77cOgRT2OE94g2xrIoiM=; b=A5Id6FqS1f0oJKc1ia6EwCy68P8oQDdPJtvfNpMfSzAgHl+0FuMKavZY/UhoZEZeys QbfTIeGFsiFbnb91UmXaMpW/ENyOp7ZH5Ys+mUbNV6SrzEuDElFcsJ2PSCFm54qUHSFr f/iAfiKs9VEX58sHmCrqgEPHWPFIYB0a+JEoDoggcAA3J4UuYBxx42kZEdH7I8k2a7H0 edWZQFPyEHg3SZyoWWNvkJDVLOz2XYD3jbqgevRtr35mmnHZaUWeNxNmA6QtxoC5k3mG 9rUF1F9pHI0lcOfynaqYc6KegzuiW55zt4aFvzdE9JrKqqTrCSAhESovOIQ4XKL3ciQt QfNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kH9QzbbcRu9iwTWJWajkxWF77cOgRT2OE94g2xrIoiM=; b=rg22JCXCuG8RlfbaXh47GH16CS4eC24fkfDLbhjmC2EW+V1Nz4tnRiDcWrK1KIPp7s d+vUhDDPVkezfyvfQqeexOlBDdIlpfdf5382qaYM6zZeK6lVaXB+gYBFfxiRLjq7o4h9 1Hpcu6oh7jGAMAuwiHRxxmg53ERsHH0i+G3YqZ0jpK1dE3lYe8er5QMvNrrTgQNhoTLp lQqUD4y/Zj4+x36HtGKpjGvgyFzOqFXxOsCA2v2k3n6UuWFVMxo7+w2ersLHzLav5Myt v4DZU0G3psry2if76+OXpvzsLeh4MyVXQMEFtzEd1/Hcb0Rtk2rQH2h+krPeIe5uPHDb NQ0g== X-Gm-Message-State: ANoB5pk46Qo2MkP5fvtYlBd8YDKuu9K4TSIXGNZ9LXAZEYTzsELfFKt2 JqzIRpMWCqJmll1p18Q7vsk= X-Google-Smtp-Source: AA0mqf7SuCQEC8YQKm62BP1norgJltMmnDS9FCxT0FsecW5FiKMNuF5A/+M6HGq9bxlmdT1ml16tqw== X-Received: by 2002:a9d:7406:0:b0:66d:6b64:dfd with SMTP id n6-20020a9d7406000000b0066d6b640dfdmr5461208otk.2.1668435794297; Mon, 14 Nov 2022 06:23:14 -0800 (PST) Received: from wintermute. (76-244-6-13.lightspeed.rcsntx.sbcglobal.net. [76.244.6.13]) by smtp.gmail.com with ESMTPSA id h24-20020a9d6f98000000b00661b46cc26bsm4128816otq.9.2022.11.14.06.23.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Nov 2022 06:23:13 -0800 (PST) Message-ID: <63724f51.9d0a0220.bdb2c.ea2e@mx.google.com> X-Google-Original-Message-ID: <20221114142305.GA9693@wintermute.> Date: Mon, 14 Nov 2022 08:23:05 -0600 From: Chris Morgan To: Maya Matuszczyk Cc: linux-rockchip@lists.infradead.org, Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , =?iso-8859-1?Q?Jo=E3o_H_=2E?= Spies , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 5/5] arm64: dts: rockchip: Add Anbernic RG351M References: <20221112143411.517906-1-maccraft123mc@gmail.com> <20221112143411.517906-6-maccraft123mc@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221112143411.517906-6-maccraft123mc@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221114_062316_991252_8520DAA3 X-CRM114-Status: GOOD ( 26.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Nov 12, 2022 at 03:34:11PM +0100, Maya Matuszczyk wrote: > This device is a clone of Odroid Go Advance, with added PWM motor, internal > gamepad connected on USB instead of just having it be on GPIO + ADC, and > missing battery shunt resistor. I have concerns about using the rk817 battery driver with no shunt resistor. For the moment, that would result in wrong values being given for battery capacity and current. What could be done is to update the driver to only check voltage values when the shunt resistor is missing (since it's the current values and columb counter that gets affected with no resistor in place). For now though, I'd just remove the battery and charger since it's going to report the wrong data to users. > > There's also an LED on GPIO 77(I *guess* PB5 on &gpio2), that is controlled in a weird way: > > - It is set to red by setting output value to 1 > - Set to green by setting output value to 0 > - Set to yellow by setting gpio direction to input > > I have no idea how to describe that in DTS, without adding a custom > driver, for now it's just left out. Check out this document, it says you'd group them together under a multicolor led node: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml > > Signed-off-by: Maya Matuszczyk > --- > arch/arm64/boot/dts/rockchip/Makefile | 1 + > .../dts/rockchip/rk3326-anbernic-rg351m.dts | 54 +++++++++++++++++++ > 2 files changed, 55 insertions(+) > create mode 100644 arch/arm64/boot/dts/rockchip/rk3326-anbernic-rg351m.dts > > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile > index 142c83d2e5aa..b379516c15eb 100644 > --- a/arch/arm64/boot/dts/rockchip/Makefile > +++ b/arch/arm64/boot/dts/rockchip/Makefile > @@ -7,6 +7,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3308-evb.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3308-roc-cc.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3308-rock-pi-s.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3318-a95x-z2.dtb > +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3326-anbernic-rg351m.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3326-odroid-go2.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3326-odroid-go2-v11.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3326-odroid-go3.dtb > diff --git a/arch/arm64/boot/dts/rockchip/rk3326-anbernic-rg351m.dts b/arch/arm64/boot/dts/rockchip/rk3326-anbernic-rg351m.dts > new file mode 100644 > index 000000000000..7f4726d4130e > --- /dev/null > +++ b/arch/arm64/boot/dts/rockchip/rk3326-anbernic-rg351m.dts > @@ -0,0 +1,54 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2019 Hardkernel Co., Ltd > + * Copyright (c) 2020 Theobroma Systems Design und Consulting GmbH > + * Copyright (c) 2022 Maya Matuszczyk > + */ > + > +/dts-v1/; > +#include "rk3326-odroid-go.dtsi" > + > +/ { > + model = "Anbernic RG351M"; > + compatible = "anbernic,rg351m", "rockchip,rk3326"; > + > + battery: battery { > + compatible = "simple-battery"; > + charge-full-design-microamp-hours = <3450000>; > + charge-term-current-microamp = <300000>; > + constant-charge-current-max-microamp = <2000000>; > + constant-charge-voltage-max-microvolt = <4200000>; > + factory-internal-resistance-micro-ohms = <100000>; > + voltage-max-design-microvolt = <4100000>; > + voltage-min-design-microvolt = <3500000>; > + > + ocv-capacity-celsius = <20>; > + ocv-capacity-table-0 = <4046950 100>, <4001920 95>, <3967900 90>, <3919950 85>, > + <3888450 80>, <3861850 75>, <3831540 70>, <3799130 65>, > + <3768190 60>, <3745650 55>, <3726610 50>, <3711630 45>, > + <3696720 40>, <3685660 35>, <3674950 30>, <3663050 25>, > + <3649470 20>, <3635260 15>, <3616920 10>, <3592440 5>, > + <3574170 0>; > + }; > + > + vibrator { > + compatible = "pwm-vibrator"; > + pwms = <&pwm0 0 1000000 0>; > + pwm-names = "enable"; > + }; > +}; > + > +/delete-node/ &builtin_gamepad; > +/delete-node/ &vcc_host; /* conflicts with pwm vibration motor */ > + > +&internal_display { > + compatible = "elida,kd35t133"; > +}; > + > +&pwm0 { > + status = "okay"; > +}; > + > +&rk817_charger { > + monitored-battery = <&battery>; > +}; > -- > 2.38.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel